You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Nate Cole <nc...@hortonworks.com> on 2014/02/18 16:52:53 UTC

Review Request 18215: Hive Metastore alerts still shows in UI when Hive is in Maint. Mode

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18215/
-----------------------------------------------------------

Review request for Ambari, Sid Wagle and Tom Beerbower.


Bugs: AMBARI-4712
    https://issues.apache.org/jira/browse/AMBARI-4712


Repository: ambari


Description
-------

* Hive service/component name not taken into account
* Hive status check puts the whole stack trace, leaving key information at the end


Diffs
-----

  ambari-server/src/main/java/org/apache/ambari/server/controller/nagios/NagiosPropertyProvider.java a57c87b 
  ambari-server/src/main/resources/stacks/HDP/1.3.2/services/NAGIOS/package/files/check_wrapper.sh ece44b2 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/NAGIOS/package/files/check_wrapper.sh a1b6a12 
  ambari-server/src/test/java/org/apache/ambari/server/controller/nagios/NagiosPropertyProviderTest.java 209e04a 
  ambari-server/src/test/resources/nagios_alerts.txt a90f445 

Diff: https://reviews.apache.org/r/18215/diff/


Testing
-------

Added test case for "complex" Hive error output.  No tests for check_wrapper.sh (we don't have any tests for Nagios plugins)


Thanks,

Nate Cole


Re: Review Request 18215: Hive Metastore alerts still shows in UI when Hive is in Maint. Mode

Posted by Tom Beerbower <tb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18215/#review34700
-----------------------------------------------------------

Ship it!


Ship It!

- Tom Beerbower


On Feb. 18, 2014, 3:52 p.m., Nate Cole wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18215/
> -----------------------------------------------------------
> 
> (Updated Feb. 18, 2014, 3:52 p.m.)
> 
> 
> Review request for Ambari, Sid Wagle and Tom Beerbower.
> 
> 
> Bugs: AMBARI-4712
>     https://issues.apache.org/jira/browse/AMBARI-4712
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> * Hive service/component name not taken into account
> * Hive status check puts the whole stack trace, leaving key information at the end
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/nagios/NagiosPropertyProvider.java a57c87b 
>   ambari-server/src/main/resources/stacks/HDP/1.3.2/services/NAGIOS/package/files/check_wrapper.sh ece44b2 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/NAGIOS/package/files/check_wrapper.sh a1b6a12 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/nagios/NagiosPropertyProviderTest.java 209e04a 
>   ambari-server/src/test/resources/nagios_alerts.txt a90f445 
> 
> Diff: https://reviews.apache.org/r/18215/diff/
> 
> 
> Testing
> -------
> 
> Added test case for "complex" Hive error output.  No tests for check_wrapper.sh (we don't have any tests for Nagios plugins)
> 
> 
> Thanks,
> 
> Nate Cole
> 
>