You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/10/10 17:32:19 UTC

[GitHub] [beam] robertwb opened a new pull request, #23557: Remove obsolete and deprecated bigquery native read.

robertwb opened a new pull request, #23557:
URL: https://github.com/apache/beam/pull/23557

   Defers to builtin read with a warning rather than raising an exception.
   
   ------------------------
   
   Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
   
    - [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
    - [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
    - [ ] Update `CHANGES.md` with noteworthy changes.
    - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/get-started-contributing/#make-the-reviewers-job-easier).
   
   To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
   
   GitHub Actions Tests Status (on master branch)
   ------------------------------------------------------------------------------------------------
   [![Build python source distribution and wheels](https://github.com/apache/beam/workflows/Build%20python%20source%20distribution%20and%20wheels/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
   [![Python tests](https://github.com/apache/beam/workflows/Python%20tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
   [![Java tests](https://github.com/apache/beam/workflows/Java%20Tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
   [![Go tests](https://github.com/apache/beam/workflows/Go%20tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
   
   See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [beam] github-actions[bot] commented on pull request #23557: Remove obsolete and deprecated bigquery native read.

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #23557:
URL: https://github.com/apache/beam/pull/23557#issuecomment-1273629548

   Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [beam] robertwb commented on pull request #23557: Remove obsolete and deprecated bigquery native read.

Posted by GitBox <gi...@apache.org>.
robertwb commented on PR #23557:
URL: https://github.com/apache/beam/pull/23557#issuecomment-1274920925

   Run Python_PVR_Flink PreCommit


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [beam] Abacn commented on pull request #23557: Remove obsolete and deprecated bigquery native read.

Posted by GitBox <gi...@apache.org>.
Abacn commented on PR #23557:
URL: https://github.com/apache/beam/pull/23557#issuecomment-1274926664

   Hi robertwb@, I meant I understand now the original approach (also remove bigquery_tools.BigQueryReader) makes sense to me than my first comment. Sorry for confusion


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [beam] Abacn commented on pull request #23557: Remove obsolete and deprecated bigquery native read.

Posted by GitBox <gi...@apache.org>.
Abacn commented on PR #23557:
URL: https://github.com/apache/beam/pull/23557#issuecomment-1273635543

   Thanks! Is there an GitHub Issue for the deprecation? If not could we create one and refer to it in CHANGES?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [beam] codecov[bot] commented on pull request #23557: Remove obsolete and deprecated bigquery native read.

Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #23557:
URL: https://github.com/apache/beam/pull/23557#issuecomment-1273797209

   # [Codecov](https://codecov.io/gh/apache/beam/pull/23557?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#23557](https://codecov.io/gh/apache/beam/pull/23557?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (bbf3b81) into [master](https://codecov.io/gh/apache/beam/commit/0e61b026ea7accd666fc443f3aeec7f93147a3b6?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (0e61b02) will **decrease** coverage by `0.09%`.
   > The diff coverage is `33.33%`.
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #23557      +/-   ##
   ==========================================
   - Coverage   73.46%   73.37%   -0.10%     
   ==========================================
     Files         718      718              
     Lines       95935    95826     -109     
   ==========================================
   - Hits        70477    70308     -169     
   - Misses      24147    24207      +60     
     Partials     1311     1311              
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | python | `83.10% <33.33%> (-0.12%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/beam/pull/23557?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [sdks/python/apache\_beam/io/gcp/bigquery\_tools.py](https://codecov.io/gh/apache/beam/pull/23557/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vZ2NwL2JpZ3F1ZXJ5X3Rvb2xzLnB5) | `76.61% <ø> (-9.12%)` | :arrow_down: |
   | [...on/apache\_beam/runners/dataflow/dataflow\_runner.py](https://codecov.io/gh/apache/beam/pull/23557/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9kYXRhZmxvdy9kYXRhZmxvd19ydW5uZXIucHk=) | `83.40% <ø> (+0.48%)` | :arrow_up: |
   | [sdks/python/apache\_beam/io/gcp/bigquery.py](https://codecov.io/gh/apache/beam/pull/23557/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vZ2NwL2JpZ3F1ZXJ5LnB5) | `73.16% <33.33%> (-1.09%)` | :arrow_down: |
   | [sdks/python/apache\_beam/internal/gcp/json\_value.py](https://codecov.io/gh/apache/beam/pull/23557/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW50ZXJuYWwvZ2NwL2pzb25fdmFsdWUucHk=) | `85.50% <0.00%> (-2.90%)` | :arrow_down: |
   | [sdks/python/apache\_beam/runners/runner.py](https://codecov.io/gh/apache/beam/pull/23557/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9ydW5uZXIucHk=) | `72.39% <0.00%> (-1.85%)` | :arrow_down: |
   | [sdks/python/apache\_beam/runners/direct/executor.py](https://codecov.io/gh/apache/beam/pull/23557/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9kaXJlY3QvZXhlY3V0b3IucHk=) | `96.46% <0.00%> (-0.55%)` | :arrow_down: |
   | [sdks/python/apache\_beam/io/iobase.py](https://codecov.io/gh/apache/beam/pull/23557/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vaW9iYXNlLnB5) | `85.92% <0.00%> (-0.50%)` | :arrow_down: |
   | [sdks/python/apache\_beam/transforms/combiners.py](https://codecov.io/gh/apache/beam/pull/23557/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdHJhbnNmb3Jtcy9jb21iaW5lcnMucHk=) | `93.05% <0.00%> (-0.39%)` | :arrow_down: |
   | ... and [2 more](https://codecov.io/gh/apache/beam/pull/23557/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [beam] Abacn commented on pull request #23557: Remove obsolete and deprecated bigquery native read.

Posted by GitBox <gi...@apache.org>.
Abacn commented on PR #23557:
URL: https://github.com/apache/beam/pull/23557#issuecomment-1273957586

   Thanks for clarifying that this is an internal-only class. In this case I agree it is good time to remove it now. And I think better remove both than removing tests and leave the class alone. The commit `bbf3b81` looks good to me.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [beam] Abacn commented on pull request #23557: Remove obsolete and deprecated bigquery native read.

Posted by GitBox <gi...@apache.org>.
Abacn commented on PR #23557:
URL: https://github.com/apache/beam/pull/23557#issuecomment-1273913235

   One thing I notice is that the removed `bigquery_tools.BigQueryReader` class is a documented one ([documentation](https://beam.apache.org/releases/pydoc/current/apache_beam.io.gcp.bigquery_tools.html#apache_beam.io.gcp.bigquery_tools.BigQueryReader)) and never marked as deprecated, although classes using it were marked as deprecated (`bigquery._BigQuerySource` and `bigquery.BigQueryReader`). `bigquery_tools.py` also had no doctoring warning the module was for internal usage only.
   
   I would recommend we mark `bigquery_tools.BigQueryReader` class as deprecated for now, and remove it and its tests in a future version (after upcoming 2.43.0).
   
   The changes in `bigquery.py` and its tests look good to me.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [beam] robertwb merged pull request #23557: Remove obsolete and deprecated bigquery native read.

Posted by GitBox <gi...@apache.org>.
robertwb merged PR #23557:
URL: https://github.com/apache/beam/pull/23557


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [beam] robertwb commented on pull request #23557: Remove obsolete and deprecated bigquery native read.

Posted by GitBox <gi...@apache.org>.
robertwb commented on PR #23557:
URL: https://github.com/apache/beam/pull/23557#issuecomment-1273628481

   R: @abacn
   CC: @pabloem 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [beam] robertwb commented on pull request #23557: Remove obsolete and deprecated bigquery native read.

Posted by GitBox <gi...@apache.org>.
robertwb commented on PR #23557:
URL: https://github.com/apache/beam/pull/23557#issuecomment-1273920597

   OK, I've left BigQueryReader for now, though technically it's really an internal-only class. We'll remove it later. Its only public entrypoint is already marked as deprecated since 2.11.0. (It didn't have any self-contained unit tests, and it didn't seem worth refactoring the other tests at this point.)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [beam] robertwb commented on pull request #23557: Remove obsolete and deprecated bigquery native read.

Posted by GitBox <gi...@apache.org>.
robertwb commented on PR #23557:
URL: https://github.com/apache/beam/pull/23557#issuecomment-1273746444

   > Thanks! Is there an GitHub Issue for the deprecation? If not could we create one and refer to it in CHANGES?
   
   Done.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [beam] robertwb commented on pull request #23557: Remove obsolete and deprecated bigquery native read.

Posted by GitBox <gi...@apache.org>.
robertwb commented on PR #23557:
URL: https://github.com/apache/beam/pull/23557#issuecomment-1274920643

   The failure at apache_beam.runners.portability.flink_runner_test.FlinkRunnerTestOptimized.test_assert_that looks irrelevent.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org