[jira] Commented: (LUCENE-1326) Inflater.end() method not always called in FieldsReader

["Uwe Schindler (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/LUCENE-1326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12610312#action_12610312 ] 

Uwe Schindler commented on LUCENE-1326:
---------------------------------------

I think a try {} finally {} around both places should be enough.

P.S.: Thank you for the comment, I fixed a missing close() around DeflaterOutputStream/InflaterInputStream and GZIP pendants in two of my servlets and a OAI harvester with Lucene.

> Inflater.end() method not always called in FieldsReader
> -------------------------------------------------------
>
>                 Key: LUCENE-1326
>                 URL: https://issues.apache.org/jira/browse/LUCENE-1326
>             Project: Lucene - Java
>          Issue Type: Bug
>    Affects Versions: 2.3.1
>            Reporter: Robert Newson
>
> We've just found an insidious memory leak in our own application as we did not always call Deflater.end() and Inflater.end(). As documented here;
> http://bugs.sun.com/view_bug.do?bug_id=4797189
> The non-heap memory that the native zlib code uses is not freed in a timely manner.
> FieldsWriter appears safe as no exception can be thrown between the Deflater's creation and end() as it uses a ByteArrayOutputStream
> FieldsReader, however, is not safe. In the event of a DataFormatException the call to end() will not occur.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org