[GitHub] [flink] reswqa opened a new pull request, #21856: [FLINK-30902][runtime] Partition reuse does not take effect on edges of hybrid selective type

["reswqa (via GitHub)" <gi...@apache.org>]

reswqa opened a new pull request, #21856:
URL: https://github.com/apache/flink/pull/21856

   ## What is the purpose of the change
   
   *Partition reuse only take effect for re-consumable edge, but hybrid selective result partition is not re-consumable. This optimization is very important to reduce the cost of the shuffle write phase. In the previous implementation, we will only force the broadcast edge to be of hybrid full(re-consumable) in the 'ResultPartitionTypeFactory'. As a result, for `ALL_ EXCHANGE_HYBRID_SELECTIVE` job, partition reuse cannot take effect for non-broadcast edges.
   In fact, we expected to replace all the edges that can be reused with hybrid full result partition.*
   
   
   ## Brief change log
   
     - *Change broadcast hybrid selective result partition type to hybrid full in compile phase instead of partition create phase.*
     - *Change reusable hybrid result partition to hybrid full to enable partition reuse optimization.*
   
   
   ## Verifying this change
   
   This change added tests in `StreamingJobGraphGeneratorTest`.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): no
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
     - The serializers: no
     - The runtime per-record code paths (performance sensitive): no
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
     - The S3 file system connector: no
   
   ## Documentation
   
     - Does this pull request introduce a new feature? no
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #21856: [FLINK-30902][runtime] Partition reuse does not take effect on edges of hybrid selective type

["flinkbot (via GitHub)" <gi...@apache.org>]

flinkbot commented on PR #21856:
URL: https://github.com/apache/flink/pull/21856#issuecomment-1418552002

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "dda88876116a01846a998c5125f315e8ae8e302d",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "dda88876116a01846a998c5125f315e8ae8e302d",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * dda88876116a01846a998c5125f315e8ae8e302d UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] xintongsong closed pull request #21856: [FLINK-30902][runtime] Partition reuse does not take effect on edges of hybrid selective type

["xintongsong (via GitHub)" <gi...@apache.org>]

xintongsong closed pull request #21856: [FLINK-30902][runtime] Partition reuse does not take effect on edges of hybrid selective type 
URL: https://github.com/apache/flink/pull/21856


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org