You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by GitBox <gi...@apache.org> on 2022/09/13 17:25:35 UTC
[GitHub] [solr] janhoy opened a new pull request, #1008: SOLR-16141 Upgrade Apache Tika to 1.28.4
janhoy opened a new pull request, #1008:
URL: https://github.com/apache/solr/pull/1008
https://issues.apache.org/jira/browse/SOLR-16141
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] janhoy merged pull request #1008: SOLR-16141 Upgrade Apache Tika to 1.28.4
Posted by GitBox <gi...@apache.org>.
janhoy merged PR #1008:
URL: https://github.com/apache/solr/pull/1008
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] risdenk commented on a diff in pull request #1008: SOLR-16141 Upgrade Apache Tika to 1.28.4
Posted by GitBox <gi...@apache.org>.
risdenk commented on code in PR #1008:
URL: https://github.com/apache/solr/pull/1008#discussion_r970129470
##########
versions.props:
##########
@@ -50,7 +50,7 @@ org.apache.kerby:*=1.0.1
org.apache.logging.log4j:*=2.17.1
Review Comment:
It doesn't matter in this case - but since the version got bumped - been trying to keep things in `versions.props` up to whatever version is already chosen. Easier to see and not have two conflicting pieces of information when it isn't necessary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] risdenk commented on a diff in pull request #1008: SOLR-16141 Upgrade Apache Tika to 1.28.4
Posted by GitBox <gi...@apache.org>.
risdenk commented on code in PR #1008:
URL: https://github.com/apache/solr/pull/1008#discussion_r969991839
##########
versions.props:
##########
@@ -50,7 +50,7 @@ org.apache.kerby:*=1.0.1
org.apache.logging.log4j:*=2.17.1
Review Comment:
This should be bumped to 2.17.2 based on `versions.lock`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] janhoy commented on a diff in pull request #1008: SOLR-16141 Upgrade Apache Tika to 1.28.4
Posted by GitBox <gi...@apache.org>.
janhoy commented on code in PR #1008:
URL: https://github.com/apache/solr/pull/1008#discussion_r970129021
##########
versions.props:
##########
@@ -50,7 +50,7 @@ org.apache.kerby:*=1.0.1
org.apache.logging.log4j:*=2.17.1
Review Comment:
Done (not sure why it would matter though).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] janhoy commented on pull request #1008: SOLR-16141 Upgrade Apache Tika to 1.28.4
Posted by GitBox <gi...@apache.org>.
janhoy commented on PR #1008:
URL: https://github.com/apache/solr/pull/1008#issuecomment-1245791076
I ran all tests, and the only failures I saw was unrelated. The modules/extraction tests all run fine. Will commit tomorrow if no objections, and backport to 9x
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org