You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@gobblin.apache.org by GitBox <gi...@apache.org> on 2020/03/13 02:49:38 UTC
[GitHub] [incubator-gobblin] codecov-io edited a comment on issue #2925:
[GOBBLIN-1080] Add configuration to add schema creation time in converter
codecov-io edited a comment on issue #2925: [GOBBLIN-1080] Add configuration to add schema creation time in converter
URL: https://github.com/apache/incubator-gobblin/pull/2925#issuecomment-598522021
# [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2925?src=pr&el=h1) Report
> Merging [#2925](https://codecov.io/gh/apache/incubator-gobblin/pull/2925?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-gobblin/commit/5796bb4c890cf4c7e48c061907232289cfb08ab9&el=desc) will **increase** coverage by `0.00%`.
> The diff coverage is `53.84%`.
[](https://codecov.io/gh/apache/incubator-gobblin/pull/2925?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #2925 +/- ##
=========================================
Coverage 45.46% 45.47%
+ Complexity 9109 9108 -1
=========================================
Files 1936 1936
Lines 73059 73070 +11
Branches 8051 8054 +3
=========================================
+ Hits 33217 33228 +11
+ Misses 36782 36778 -4
- Partials 3060 3064 +4
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-gobblin/pull/2925?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pache/gobblin/configuration/ConfigurationKeys.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2925/diff?src=pr&el=tree#diff-Z29iYmxpbi1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vY29uZmlndXJhdGlvbi9Db25maWd1cmF0aW9uS2V5cy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...c/main/java/org/apache/gobblin/util/AvroUtils.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2925/diff?src=pr&el=tree#diff-Z29iYmxpbi11dGlsaXR5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3V0aWwvQXZyb1V0aWxzLmphdmE=) | `57.33% <0.00%> (-0.40%)` | `81.00 <0.00> (ø)` | |
| [...er/GobblinTrackingEventFlattenFilterConverter.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2925/diff?src=pr&el=tree#diff-Z29iYmxpbi1jb3JlLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vY29udmVydGVyL2ZpbHRlci9Hb2JibGluVHJhY2tpbmdFdmVudEZsYXR0ZW5GaWx0ZXJDb252ZXJ0ZXIuamF2YQ==) | `69.64% <66.66%> (-0.17%)` | `9.00 <0.00> (ø)` | |
| [...blin/converter/filter/AvroProjectionConverter.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2925/diff?src=pr&el=tree#diff-Z29iYmxpbi1jb3JlLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vY29udmVydGVyL2ZpbHRlci9BdnJvUHJvamVjdGlvbkNvbnZlcnRlci5qYXZh) | `75.00% <83.33%> (ø)` | `6.00 <2.00> (ø)` | |
| [...lin/elasticsearch/writer/FutureCallbackHolder.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2925/diff?src=pr&el=tree#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4tZWxhc3RpY3NlYXJjaC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZ29iYmxpbi9lbGFzdGljc2VhcmNoL3dyaXRlci9GdXR1cmVDYWxsYmFja0hvbGRlci5qYXZh) | `61.42% <0.00%> (-1.43%)` | `4.00% <0.00%> (ø%)` | |
| [...e/gobblin/runtime/locks/ZookeeperBasedJobLock.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2925/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvbG9ja3MvWm9va2VlcGVyQmFzZWRKb2JMb2NrLmphdmE=) | `63.33% <0.00%> (-1.12%)` | `15.00% <0.00%> (-1.00%)` | |
| [...main/java/org/apache/gobblin/util/HadoopUtils.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2925/diff?src=pr&el=tree#diff-Z29iYmxpbi11dGlsaXR5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3V0aWwvSGFkb29wVXRpbHMuamF2YQ==) | `30.20% <0.00%> (-0.68%)` | `24.00% <0.00%> (-1.00%)` | |
| [...in/java/org/apache/gobblin/cluster/HelixUtils.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2925/diff?src=pr&el=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvSGVsaXhVdGlscy5qYXZh) | `38.26% <0.00%> (+2.60%)` | `14.00% <0.00%> (+1.00%)` | |
| [...e/gobblin/runtime/app/ServiceBasedAppLauncher.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2925/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvYXBwL1NlcnZpY2VCYXNlZEFwcExhdW5jaGVyLmphdmE=) | `49.51% <0.00%> (+5.82%)` | `12.00% <0.00%> (ø%)` | |
| [...lin/util/filesystem/FileSystemInstrumentation.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2925/diff?src=pr&el=tree#diff-Z29iYmxpbi11dGlsaXR5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3V0aWwvZmlsZXN5c3RlbS9GaWxlU3lzdGVtSW5zdHJ1bWVudGF0aW9uLmphdmE=) | `92.85% <0.00%> (+7.14%)` | `3.00% <0.00%> (ø%)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2925?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2925?src=pr&el=footer). Last update [5796bb4...641c5ed](https://codecov.io/gh/apache/incubator-gobblin/pull/2925?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services