[GitHub] [doris] englefly commented on a diff in pull request #20905: [enhancement](nereids) Remove useless config option

["englefly (via GitHub)" <gi...@apache.org>]

englefly commented on code in PR #20905:
URL: https://github.com/apache/doris/pull/20905#discussion_r1233783728


##########
fe/fe-core/src/main/java/org/apache/doris/statistics/OlapAnalysisTask.java:
##########
@@ -108,10 +110,19 @@ public void execSQLs(List<String> partitionAnalysisSQLs) throws Exception {
 
     @VisibleForTesting
     public void execSQL(String sql) throws Exception {
-        QueryState queryState = StatisticsUtil.execUpdate(sql);
-        if (queryState.getStateType().equals(MysqlStateType.ERR)) {
-            throw new RuntimeException(String.format("Failed to analyze %s.%s.%s, error: %s",
-                    info.catalogName, info.dbName, info.colName, queryState.getErrorMessage()));
+        if (killed) {
+            return;

Review Comment:
    is this thread safe?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org