You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2022/04/07 18:26:49 UTC
[GitHub] [nifi] mattyb149 commented on a diff in pull request #5941: NIFI-9884 - JacksonCSVRecordReader ignores specified encoding
mattyb149 commented on code in PR #5941:
URL: https://github.com/apache/nifi/pull/5941#discussion_r845448314
##########
nifi-nar-bundles/nifi-standard-services/nifi-record-serialization-services-bundle/nifi-record-serialization-services/src/test/java/org/apache/nifi/csv/TestJacksonCSVRecordReader.java:
##########
@@ -69,7 +70,7 @@ public void testUTF8() throws IOException, MalformedRecordException {
fields.add(new RecordField("name", RecordFieldType.STRING.getDataType()));
final RecordSchema schema = new SimpleRecordSchema(fields);
- try (final InputStream bais = new ByteArrayInputStream(text.getBytes());
+ try (final InputStream bais = new ByteArrayInputStream(text.getBytes(StandardCharsets.UTF_8));
Review Comment:
Does this fail without the fix above? Wondering if we should have another unit test that specifies a different charset
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org