You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/08/12 18:44:28 UTC
[GitHub] [beam] udim opened a new pull request #11112: Color Jenkins logs support
udim opened a new pull request #11112:
URL: https://github.com/apache/beam/pull/11112
- Gradle: can force colors with --console=rich output, but without a terminal the captured Jenkins output contains a lot of repeated progress text.
https://github.com/gradle/gradle/issues/6843
- tox: colors can be forced with PY_COLORS=1
- pytest: can force colors with --colors=yes on the command line (pytest.ini didn't work for me). Looks ugly on a terminal, though (in color):
```
... [ 91%]
.======-------...0% EXECUTING [3m 1s]estPy37.cp ... . .... . . ... .
..s...s..................................... .
........ [ 93%]
```
However, with Gradle defaulting to --console=plain (no terminal control chars), this should be fine under Jenkins.
- docker output - always outputs color, looks fine (see :sdks:python:container:py35:docker in https://builds.apache.org/job/beam_PreCommit_Portable_Python_Phrase/576/console).
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
- [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/#make-reviewers-job-easier).
Post-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
Lang | SDK | Apex | Dataflow | Flink | Gearpump | Samza | Spark
--- | --- | --- | --- | --- | --- | --- | ---
Go | [](https://builds.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/) | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_Go_VR_Flink/lastCompletedBuild/) | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_Go_VR_Spark/lastCompletedBuild/)
Java | [](https://builds.apache.org/job/beam_PostCommit_Java/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Apex/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow_Java11/lastCompletedBuild/) | [](https://build
s.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Batch/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Streaming/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Gearpump/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Spark_Batch/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_SparkStructuredStreaming/lastCompletedBuild/)
Python | [](https://builds.apache.org/job/beam_PostCommit_Python2/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Python35/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Python36/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Python37/lastCompletedBuild/) | --- | [](https://builds.apache.org/job/beam_PostCommit_Py_VR_Dataflow/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Py_VR_Dataflow_V2/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Py_ValCont/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PreCommit_Python2_PVR_Flink_Cron/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Python35_VR_Flink/lastCompletedBuild/) | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_Python_VR_Spark/lastCompletedBuild/)
XLang | --- | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_XVR_Flink/lastCompletedBuild/) | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_XVR_Spark/lastCompletedBuild/)
Pre-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
--- |Java | Python | Go | Website
--- | --- | --- | --- | ---
Non-portable | [](https://builds.apache.org/job/beam_PreCommit_Java_Cron/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PreCommit_Python_Cron/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PreCommit_PythonLint_Cron/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PreCommit_Go_Cron/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PreCommit_Website_Cron/lastCompletedBuild/)
Portable | --- | [](https://builds.apache.org/job/beam_PreCommit_Portable_Python_Cron/lastCompletedBuild/) | --- | ---
See [.test-infra/jenkins/README](https://github.com/apache/beam/blob/master/.test-infra/jenkins/README.md) for trigger phrase, status and link of all Jenkins jobs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] udim commented on pull request #11112: Color Jenkins logs support
Posted by GitBox <gi...@apache.org>.
udim commented on pull request #11112:
URL: https://github.com/apache/beam/pull/11112#issuecomment-675767257
run python precommit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] tvalentyn commented on a change in pull request #11112: Color Jenkins logs support
Posted by GitBox <gi...@apache.org>.
tvalentyn commented on a change in pull request #11112:
URL: https://github.com/apache/beam/pull/11112#discussion_r473527933
##########
File path: .test-infra/jenkins/CommonJobProperties.groovy
##########
@@ -97,6 +97,7 @@ class CommonJobProperties {
string("COVERALLS_REPO_TOKEN", "beam-coveralls-token")
}
timestamps()
+ colorizeOutput()
Review comment:
For my education, where is this defined?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] udim commented on pull request #11112: Color Jenkins logs support
Posted by GitBox <gi...@apache.org>.
udim commented on pull request #11112:
URL: https://github.com/apache/beam/pull/11112#issuecomment-674272066
run seed job
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] udim commented on pull request #11112: Color Jenkins logs support
Posted by GitBox <gi...@apache.org>.
udim commented on pull request #11112:
URL: https://github.com/apache/beam/pull/11112#issuecomment-677748882
run python precommit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] udim commented on pull request #11112: Color Jenkins logs support
Posted by GitBox <gi...@apache.org>.
udim commented on pull request #11112:
URL: https://github.com/apache/beam/pull/11112#issuecomment-674278368
Run Python PreCommit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] udim commented on pull request #11112: Color Jenkins logs support
Posted by GitBox <gi...@apache.org>.
udim commented on pull request #11112:
URL: https://github.com/apache/beam/pull/11112#issuecomment-674282533
Run Python PreCommit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] udim commented on pull request #11112: Color Jenkins logs support
Posted by GitBox <gi...@apache.org>.
udim commented on pull request #11112:
URL: https://github.com/apache/beam/pull/11112#issuecomment-675781057
R: @tvalentyn
Sadly this doesn't fix the codecov link with ansi color code at the end. The code is not displayed but the link still has it:
`https://codecov.io/github/apache/beam/commit/2489cf1e6f7d9772449a052165de3139c5d2e8a1%1B[0m`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] udim commented on pull request #11112: Color Jenkins logs support
Posted by GitBox <gi...@apache.org>.
udim commented on pull request #11112:
URL: https://github.com/apache/beam/pull/11112#issuecomment-676545524
run python precommit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] udim merged pull request #11112: Color Jenkins logs support
Posted by GitBox <gi...@apache.org>.
udim merged pull request #11112:
URL: https://github.com/apache/beam/pull/11112
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] udim commented on pull request #11112: Color Jenkins logs support
Posted by GitBox <gi...@apache.org>.
udim commented on pull request #11112:
URL: https://github.com/apache/beam/pull/11112#issuecomment-674280614
Run Python PreCommit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] udim commented on a change in pull request #11112: Color Jenkins logs support
Posted by GitBox <gi...@apache.org>.
udim commented on a change in pull request #11112:
URL: https://github.com/apache/beam/pull/11112#discussion_r473552118
##########
File path: .test-infra/jenkins/CommonJobProperties.groovy
##########
@@ -97,6 +97,7 @@ class CommonJobProperties {
string("COVERALLS_REPO_TOKEN", "beam-coveralls-token")
}
timestamps()
+ colorizeOutput()
Review comment:
It's from the ansicolor plugin, which I recently asked Infra to install.
Technically, the Jenkins DSL plugin defines `colorizeOutput`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] udim commented on pull request #11112: Color Jenkins logs support
Posted by GitBox <gi...@apache.org>.
udim commented on pull request #11112:
URL: https://github.com/apache/beam/pull/11112#issuecomment-675765232
run seed job
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org