You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Todd Lipcon (Code Review)" <ge...@cloudera.org> on 2020/03/24 18:42:42 UTC

[kudu-CR] rpc: relax limit on number of sidecars

Hello Thomas Tauber-Marshall, Adar Dembo,

I'd like you to do a code review. Please visit

    http://gerrit.cloudera.org:8080/15547

to review the following change.


Change subject: rpc: relax limit on number of sidecars
......................................................................

rpc: relax limit on number of sidecars

Following the example of 0a7787f6563ae316a4a6207a9244c19ba8a7731f this
changes the the sidecars for outbound calls to use a
boost::container::small_vector instead of a fixed size array. This means
we no longer need such a strict limit.

This commit raises the limit to 10000 as a reasonable "can't see the
need for more than this" number.

This also fixes an issue where the underlying socket syscalls fail if
the number of slices in the iovec list is more than IOV_MAX. The new
test verifies the behavior.

Change-Id: I8e53d5b50753e4aa57d885718ad5b24558636f82
---
M src/kudu/rpc/inbound_call.cc
M src/kudu/rpc/inbound_call.h
M src/kudu/rpc/outbound_call.cc
M src/kudu/rpc/outbound_call.h
M src/kudu/rpc/rpc-test-base.h
M src/kudu/rpc/rpc-test.cc
M src/kudu/rpc/rpc_sidecar.cc
M src/kudu/rpc/rpc_sidecar.h
M src/kudu/rpc/rtest.proto
M src/kudu/rpc/transfer.cc
M src/kudu/rpc/transfer.h
11 files changed, 106 insertions(+), 74 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/47/15547/1
-- 
To view, visit http://gerrit.cloudera.org:8080/15547
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I8e53d5b50753e4aa57d885718ad5b24558636f82
Gerrit-Change-Number: 15547
Gerrit-PatchSet: 1
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>

[kudu-CR] rpc: relax limit on number of sidecars

Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15547 )

Change subject: rpc: relax limit on number of sidecars
......................................................................

rpc: relax limit on number of sidecars

Following the example of 0a7787f6563ae316a4a6207a9244c19ba8a7731f this
changes the the sidecars for outbound calls to use a
boost::container::small_vector instead of a fixed size array. This means
we no longer need such a strict limit.

This commit raises the limit to 10000 as a reasonable "can't see the
need for more than this" number.

This also fixes an issue where the underlying socket syscalls fail if
the number of slices in the iovec list is more than IOV_MAX. The new
test verifies the behavior.

Change-Id: I8e53d5b50753e4aa57d885718ad5b24558636f82
Reviewed-on: http://gerrit.cloudera.org:8080/15547
Tested-by: Kudu Jenkins
Reviewed-by: Adar Dembo <ad...@cloudera.com>
---
M src/kudu/rpc/inbound_call.cc
M src/kudu/rpc/inbound_call.h
M src/kudu/rpc/outbound_call.cc
M src/kudu/rpc/outbound_call.h
M src/kudu/rpc/rpc-test-base.h
M src/kudu/rpc/rpc-test.cc
M src/kudu/rpc/rpc_sidecar.cc
M src/kudu/rpc/rpc_sidecar.h
M src/kudu/rpc/rtest.proto
M src/kudu/rpc/transfer.cc
M src/kudu/rpc/transfer.h
11 files changed, 104 insertions(+), 74 deletions(-)

Approvals:
  Kudu Jenkins: Verified
  Adar Dembo: Looks good to me, approved

-- 
To view, visit http://gerrit.cloudera.org:8080/15547
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I8e53d5b50753e4aa57d885718ad5b24558636f82
Gerrit-Change-Number: 15547
Gerrit-PatchSet: 3
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>

[kudu-CR] rpc: relax limit on number of sidecars

Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Hello Thomas Tauber-Marshall, Tidy Bot, Kudu Jenkins, Adar Dembo, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/15547

to look at the new patch set (#2).

Change subject: rpc: relax limit on number of sidecars
......................................................................

rpc: relax limit on number of sidecars

Following the example of 0a7787f6563ae316a4a6207a9244c19ba8a7731f this
changes the the sidecars for outbound calls to use a
boost::container::small_vector instead of a fixed size array. This means
we no longer need such a strict limit.

This commit raises the limit to 10000 as a reasonable "can't see the
need for more than this" number.

This also fixes an issue where the underlying socket syscalls fail if
the number of slices in the iovec list is more than IOV_MAX. The new
test verifies the behavior.

Change-Id: I8e53d5b50753e4aa57d885718ad5b24558636f82
---
M src/kudu/rpc/inbound_call.cc
M src/kudu/rpc/inbound_call.h
M src/kudu/rpc/outbound_call.cc
M src/kudu/rpc/outbound_call.h
M src/kudu/rpc/rpc-test-base.h
M src/kudu/rpc/rpc-test.cc
M src/kudu/rpc/rpc_sidecar.cc
M src/kudu/rpc/rpc_sidecar.h
M src/kudu/rpc/rtest.proto
M src/kudu/rpc/transfer.cc
M src/kudu/rpc/transfer.h
11 files changed, 104 insertions(+), 74 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/47/15547/2
-- 
To view, visit http://gerrit.cloudera.org:8080/15547
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I8e53d5b50753e4aa57d885718ad5b24558636f82
Gerrit-Change-Number: 15547
Gerrit-PatchSet: 2
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Tidy Bot (241)

[kudu-CR] rpc: relax limit on number of sidecars

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15547 )

Change subject: rpc: relax limit on number of sidecars
......................................................................


Patch Set 2: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/15547
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8e53d5b50753e4aa57d885718ad5b24558636f82
Gerrit-Change-Number: 15547
Gerrit-PatchSet: 2
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Comment-Date: Tue, 24 Mar 2020 22:36:24 +0000
Gerrit-HasComments: No