You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by Mark Hobson <ma...@gmail.com> on 2007/07/03 15:48:32 UTC
[VOTE] Configure IDE plugins to download sources by default within Maven projects
Following the recent thread "Maven POM plugin config", this is a vote
to add downloadSources=true to both the eclipse and idea plugin
configurations in the maven-parent POM:
[ ] +1: I like Javadoc and easy debugging
[ ] +0: I'll go with the flow
[ ] -1: I like superfluous typing, guessing Javadoc and reading bytecode
+1 from me.
Mark
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: [VOTE] Configure IDE plugins to download sources by default within
Maven projects
Posted by Dennis Lundberg <de...@apache.org>.
+1
Mark Hobson wrote:
> Following the recent thread "Maven POM plugin config", this is a vote
> to add downloadSources=true to both the eclipse and idea plugin
> configurations in the maven-parent POM:
>
> [ ] +1: I like Javadoc and easy debugging
> [ ] +0: I'll go with the flow
> [ ] -1: I like superfluous typing, guessing Javadoc and reading bytecode
>
> +1 from me.
>
> Mark
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
--
Dennis Lundberg
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: [VOTE] Configure IDE plugins to download sources by default within Maven projects
Posted by Stephane Nicoll <st...@gmail.com>.
-1 (vote) in the way it's handled right now
When you have lots of dependencies, it takes way much time to generate
the project. I would go either into a FAQ explaining how to set this
up in the pluginsManagement section of a super pom.
Aligning the cache system from the eclipse plugin to the IDEA plugin
would probably change my vote.
Stéphane
On 7/3/07, Mark Hobson <ma...@gmail.com> wrote:
> Following the recent thread "Maven POM plugin config", this is a vote
> to add downloadSources=true to both the eclipse and idea plugin
> configurations in the maven-parent POM:
>
> [ ] +1: I like Javadoc and easy debugging
> [ ] +0: I'll go with the flow
> [ ] -1: I like superfluous typing, guessing Javadoc and reading bytecode
>
> +1 from me.
>
> Mark
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
>
--
Large Systems Suck: This rule is 100% transitive. If you build one,
you suck" -- S.Yegge
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: [VOTE] Configure IDE plugins to download sources by default within Maven projects
Posted by Edwin Punzalan <el...@gmail.com>.
+1
Its in my settings.xml too.
On 7/3/07, Mark Hobson <ma...@gmail.com> wrote:
>
> Following the recent thread "Maven POM plugin config", this is a vote
> to add downloadSources=true to both the eclipse and idea plugin
> configurations in the maven-parent POM:
>
> [ ] +1: I like Javadoc and easy debugging
> [ ] +0: I'll go with the flow
> [ ] -1: I like superfluous typing, guessing Javadoc and reading bytecode
>
> +1 from me.
>
> Mark
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
>
Re: [VOTE] Configure IDE plugins to download sources by default within
Maven projects
Posted by Reinhard Poetz <re...@apache.org>.
Jochen Wiedmann wrote:
> On 7/3/07, Mark Hobson <ma...@gmail.com> wrote:
>> Following the recent thread "Maven POM plugin config", this is a vote
>> to add downloadSources=true to both the eclipse and idea plugin
>> configurations in the maven-parent POM:
>>
>> [ ] +1: I like Javadoc and easy debugging
>> [ ] +0: I'll go with the flow
>> [ ] -1: I like superfluous typing, guessing Javadoc and reading bytecode
>
> -1 for both, although I like to have sources and javadocs attached to
> Eclipse. (Non-binding)
>
> Downloading sources (or javadocs) is an excellent thing, if the
> sources (or the javadocs) are available. Unfortunately this isn't the
> case in a real lot of cases. As a consequence, running the plugins can
> get darned slow.
For the same reasons I'm -1 on this proposal too (non-binding)
--
Reinhard
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: [VOTE] Configure IDE plugins to download sources by default within Maven projects
Posted by Mark Hobson <ma...@gmail.com>.
On 03/07/07, Jochen Wiedmann <jo...@gmail.com> wrote:
> -1 for both, although I like to have sources and javadocs attached to
> Eclipse. (Non-binding)
>
> Downloading sources (or javadocs) is an excellent thing, if the
> sources (or the javadocs) are available. Unfortunately this isn't the
> case in a real lot of cases. As a consequence, running the plugins can
> get darned slow.
Subsequent invocations are quick since missing jars are cached in
target/mvn-eclipse-cache.properties.
> Apart from that, why can't you simply run
>
> mvn dependency:sources
> mvn eclipse:eclipse
May as well run mvn eclipse:eclipse -DdownloadSources ;)
Mark
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: [VOTE] Configure IDE plugins to download sources by default within Maven projects
Posted by Jochen Wiedmann <jo...@gmail.com>.
I have had second thoughts on the proposal.
To me, we are discussing something, that clearly is a user preference.
As such, it belongs into either settings.xml or profiles.xml, possibly
with activeByDefault=true. It should not enter a projects POM, if it
is used by as many people as the Maven POM's.
Jochen
--
"Besides, manipulating elections is under penalty of law, resulting in
a preventative effect against manipulating elections.
The german government justifying the use of electronic voting machines
and obviously believing that we don't need a police, because all
illegal actions are forbidden.
http://dip.bundestag.de/btd/16/051/1605194.pdf
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: [VOTE] Configure IDE plugins to download sources by default within Maven projects
Posted by Brett Porter <br...@apache.org>.
On 04/07/2007, at 12:04 AM, Jochen Wiedmann wrote:
> Downloading sources (or javadocs) is an excellent thing, if the
> sources (or the javadocs) are available. Unfortunately this isn't the
> case in a real lot of cases. As a consequence, running the plugins can
> get darned slow.
>
> Apart from that, why can't you simply run
>
> mvn dependency:sources
> mvn eclipse:eclipse
I like this suggestion - have an option to use the ones downloaded
already, but not grab any more (to avoid redownloading missing stuff
all the time - though this could also be achieved by adding some
marker in the repository).
- Brett
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: [VOTE] Configure IDE plugins to download sources by default within Maven projects
Posted by Jochen Wiedmann <jo...@gmail.com>.
On 7/3/07, Mark Hobson <ma...@gmail.com> wrote:
> Following the recent thread "Maven POM plugin config", this is a vote
> to add downloadSources=true to both the eclipse and idea plugin
> configurations in the maven-parent POM:
>
> [ ] +1: I like Javadoc and easy debugging
> [ ] +0: I'll go with the flow
> [ ] -1: I like superfluous typing, guessing Javadoc and reading bytecode
-1 for both, although I like to have sources and javadocs attached to
Eclipse. (Non-binding)
Downloading sources (or javadocs) is an excellent thing, if the
sources (or the javadocs) are available. Unfortunately this isn't the
case in a real lot of cases. As a consequence, running the plugins can
get darned slow.
Apart from that, why can't you simply run
mvn dependency:sources
mvn eclipse:eclipse
--
"Besides, manipulating elections is under penalty of law, resulting in
a preventative effect against manipulating elections.
The german government justifying the use of electronic voting machines
and obviously believing that we don't need a police, because all
illegal actions are forbidden.
http://dip.bundestag.de/btd/16/051/1605194.pdf
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: [VOTE] Configure IDE plugins to download sources by default within Maven projects
Posted by Christian Gruber <ch...@gmail.com>.
+1 for both (non binding), but the unavailability of either shouldn't
spam consoles. Small concise warnings would be sufficient, if at all.
Christian.
On Jul 3, 2007, at 9:48 AM, Mark Hobson wrote:
> Following the recent thread "Maven POM plugin config", this is a vote
> to add downloadSources=true to both the eclipse and idea plugin
> configurations in the maven-parent POM:
>
> [ ] +1: I like Javadoc and easy debugging
> [ ] +0: I'll go with the flow
> [ ] -1: I like superfluous typing, guessing Javadoc and reading
> bytecode
>
> +1 from me.
>
> Mark
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: [VOTE] Configure IDE plugins to download sources by default within Maven projects
Posted by Rahul Thakur <ra...@gmail.com>.
Same here.
+1 to Javadoc
-1 to download sources
Cheers,
Rahul
----- Original Message -----
From: "Brett Porter" <br...@apache.org>
To: "Maven Developers List" <de...@maven.apache.org>
Sent: Wednesday, July 04, 2007 1:50 AM
Subject: Re: [VOTE] Configure IDE plugins to download sources by default
within Maven projects
> +1 to Javadoc
>
> -1 to sources (just a vote, not a veto :)
>
> On 03/07/2007, at 11:48 PM, Mark Hobson wrote:
>
>> Following the recent thread "Maven POM plugin config", this is a vote
>> to add downloadSources=true to both the eclipse and idea plugin
>> configurations in the maven-parent POM:
>>
>> [ ] +1: I like Javadoc and easy debugging
>> [ ] +0: I'll go with the flow
>> [ ] -1: I like superfluous typing, guessing Javadoc and reading
>> bytecode
>>
>> +1 from me.
>>
>> Mark
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>> For additional commands, e-mail: dev-help@maven.apache.org
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: [VOTE] Configure IDE plugins to download sources by default within Maven projects
Posted by Stephane Nicoll <st...@gmail.com>.
On 7/3/07, Cabasson Denis <de...@insee.fr> wrote:
> Can you be a little more specific about the behaviour of the IDEA plugin you would want to port to the eclipse plugin?
It's the other way around. When you generate the project using the
eclise plugin it marks the dependencies that have not been resolved
(sources & javadocs). Hence, further execution are faster since it
does not try to contact the repo again for those deps.
The IDEA plugin does not have this functionnality.
Hope it clarifies
Stéphane
>
> Injection of properties (taken from IdeaModuleMojo) : linkModules should be pretty straight forward
> Injection of properties (taken from IdeaModuleMojo) : downloadSources, downloadJavadocs, sourceClassifier, javadocClassifier now, that was exactly what I was talking about.
>
> Use of private static Map attemptedDownloads = new HashMap(); instead of maven-eclipse-cache.properties, looks really ugly to me but could be possible (if you'd care to explain the point to me).
>
> But I guess it's none of the above behaviours you were looking forward to.
>
> Denis.
>
> > -----Message d'origine-----
> > De : Stephane Nicoll [mailto:stephane.nicoll@gmail.com]
> > Envoyé : Tuesday, July 03, 2007 5:00 PM
> > À : Maven Developers List
> > Objet : Re: [VOTE] Configure IDE plugins to download sources
> > by default within Maven projects
> >
> > And make this consistent with the IDEA plugin as well.
> >
> > On 7/3/07, Cabasson Denis <de...@insee.fr> wrote:
> > > About this link, why couldn't we have a consistent
> > behaviour for javadoc and sources jar?
> > >
> > > Why not adding a downloadJavadoc property, which, when set
> > to true, would download and attach the javadoc to the dependency.
> > >
> > > I don't really see why javadoc should be a fallback if
> > sources are not available.
> > >
> > > Some developpers might prefer to have javadoc linked, some
> > sources linked and some both. Shouldn't the eclipse plugin
> > allow for all the possiblities instead of stating that the
> > preferred option is always to get the sources instead of the Javadoc?
> > >
> > > To be followed in :
> > > http://jira.codehaus.org/browse/MECLIPSE-292
> > >
> > > Denis.
> > >
> > >
> > > > -----Message d'origine-----
> > > > De : Mark Hobson [mailto:markhobson@gmail.com] Envoyé : Tuesday,
> > > > July 03, 2007 4:08 PM À : Maven Developers List Objet :
> > Re: [VOTE]
> > > > Configure IDE plugins to download sources by default within Maven
> > > > projects
> > > >
> > > > On 03/07/07, Brett Porter <br...@apache.org> wrote:
> > > > > +1 to Javadoc
> > > > >
> > > > > -1 to sources (just a vote, not a veto :)
> > > >
> > > > In the eclipse plugin, the downloadSources flag controls
> > them both:
> > > > http://maven.apache.org/plugins/maven-eclipse-plugin/faq.html#
> > > > import-javadoc
> > > >
> > > > Mark
> > > >
> > > >
> > --------------------------------------------------------------------
> > > > - To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org For
> > > > additional commands, e-mail: dev-help@maven.apache.org
> > > >
> > > >
> > >
> > >
> > ---------------------------------------------------------------------
> > > To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org For
> > > additional commands, e-mail: dev-help@maven.apache.org
> > >
> > >
> >
> >
> > --
> > Large Systems Suck: This rule is 100% transitive. If you
> > build one, you suck" -- S.Yegge
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org For
> > additional commands, e-mail: dev-help@maven.apache.org
> >
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
>
--
Large Systems Suck: This rule is 100% transitive. If you build one,
you suck" -- S.Yegge
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
RE: [VOTE] Configure IDE plugins to download sources by default within Maven projects
Posted by Cabasson Denis <de...@insee.fr>.
Can you be a little more specific about the behaviour of the IDEA plugin you would want to port to the eclipse plugin?
Injection of properties (taken from IdeaModuleMojo) : linkModules should be pretty straight forward
Injection of properties (taken from IdeaModuleMojo) : downloadSources, downloadJavadocs, sourceClassifier, javadocClassifier now, that was exactly what I was talking about.
Use of private static Map attemptedDownloads = new HashMap(); instead of maven-eclipse-cache.properties, looks really ugly to me but could be possible (if you'd care to explain the point to me).
But I guess it's none of the above behaviours you were looking forward to.
Denis.
> -----Message d'origine-----
> De : Stephane Nicoll [mailto:stephane.nicoll@gmail.com]
> Envoyé : Tuesday, July 03, 2007 5:00 PM
> À : Maven Developers List
> Objet : Re: [VOTE] Configure IDE plugins to download sources
> by default within Maven projects
>
> And make this consistent with the IDEA plugin as well.
>
> On 7/3/07, Cabasson Denis <de...@insee.fr> wrote:
> > About this link, why couldn't we have a consistent
> behaviour for javadoc and sources jar?
> >
> > Why not adding a downloadJavadoc property, which, when set
> to true, would download and attach the javadoc to the dependency.
> >
> > I don't really see why javadoc should be a fallback if
> sources are not available.
> >
> > Some developpers might prefer to have javadoc linked, some
> sources linked and some both. Shouldn't the eclipse plugin
> allow for all the possiblities instead of stating that the
> preferred option is always to get the sources instead of the Javadoc?
> >
> > To be followed in :
> > http://jira.codehaus.org/browse/MECLIPSE-292
> >
> > Denis.
> >
> >
> > > -----Message d'origine-----
> > > De : Mark Hobson [mailto:markhobson@gmail.com] Envoyé : Tuesday,
> > > July 03, 2007 4:08 PM À : Maven Developers List Objet :
> Re: [VOTE]
> > > Configure IDE plugins to download sources by default within Maven
> > > projects
> > >
> > > On 03/07/07, Brett Porter <br...@apache.org> wrote:
> > > > +1 to Javadoc
> > > >
> > > > -1 to sources (just a vote, not a veto :)
> > >
> > > In the eclipse plugin, the downloadSources flag controls
> them both:
> > > http://maven.apache.org/plugins/maven-eclipse-plugin/faq.html#
> > > import-javadoc
> > >
> > > Mark
> > >
> > >
> --------------------------------------------------------------------
> > > - To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org For
> > > additional commands, e-mail: dev-help@maven.apache.org
> > >
> > >
> >
> >
> ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org For
> > additional commands, e-mail: dev-help@maven.apache.org
> >
> >
>
>
> --
> Large Systems Suck: This rule is 100% transitive. If you
> build one, you suck" -- S.Yegge
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org For
> additional commands, e-mail: dev-help@maven.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: [VOTE] Configure IDE plugins to download sources by default within Maven projects
Posted by Stephane Nicoll <st...@gmail.com>.
And make this consistent with the IDEA plugin as well.
On 7/3/07, Cabasson Denis <de...@insee.fr> wrote:
> About this link, why couldn't we have a consistent behaviour for javadoc and sources jar?
>
> Why not adding a downloadJavadoc property, which, when set to true, would download and attach the javadoc to the dependency.
>
> I don't really see why javadoc should be a fallback if sources are not available.
>
> Some developpers might prefer to have javadoc linked, some sources linked and some both. Shouldn't the eclipse plugin allow for all the possiblities instead of stating that the preferred option is always to get the sources instead of the Javadoc?
>
> To be followed in :
> http://jira.codehaus.org/browse/MECLIPSE-292
>
> Denis.
>
>
> > -----Message d'origine-----
> > De : Mark Hobson [mailto:markhobson@gmail.com]
> > Envoyé : Tuesday, July 03, 2007 4:08 PM
> > À : Maven Developers List
> > Objet : Re: [VOTE] Configure IDE plugins to download sources
> > by default within Maven projects
> >
> > On 03/07/07, Brett Porter <br...@apache.org> wrote:
> > > +1 to Javadoc
> > >
> > > -1 to sources (just a vote, not a veto :)
> >
> > In the eclipse plugin, the downloadSources flag controls them both:
> > http://maven.apache.org/plugins/maven-eclipse-plugin/faq.html#
> > import-javadoc
> >
> > Mark
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org For
> > additional commands, e-mail: dev-help@maven.apache.org
> >
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
>
--
Large Systems Suck: This rule is 100% transitive. If you build one,
you suck" -- S.Yegge
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: [VOTE] Configure IDE plugins to download sources by default within
Maven projects
Posted by Kenney Westerhof <ke...@apache.org>.
Brian E. Fox wrote:
>> So I propose:
>
>> - if -DdownloadSources is specified, download sources and fallback to javadoc, just as it is now
>> - if -DdownloadJavaDoc is specified, download javadoc (possibly fallback to sources)
>> - if both are specified, download both.
>
>> And:
>
>> - don't make this a default; the default behaviour of attaching
>> either source or javadoc when it's present in the local repo
>> is fine though, but turning this on by default is just too slow.
>
> This is already done in Eclipse 2.4 although it doesn't fallback to the javadoc.
Cool though the fallback has been there a long time ago, and still was until a few days ago
(just svn upped and it was gone; a few days ago this still was present...).
Guess the fallback isn't really required so it's fine like this imho.
>
> http://jira.codehaus.org/browse/MECLIPSE-292
>
> --Brian
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
RE: [VOTE] Configure IDE plugins to download sources by default within Maven projects
Posted by "Brian E. Fox" <br...@reply.infinity.nu>.
>So I propose:
>- if -DdownloadSources is specified, download sources and fallback to javadoc, just as it is now
>- if -DdownloadJavaDoc is specified, download javadoc (possibly fallback to sources)
>- if both are specified, download both.
>And:
>- don't make this a default; the default behaviour of attaching
> either source or javadoc when it's present in the local repo
> is fine though, but turning this on by default is just too slow.
This is already done in Eclipse 2.4 although it doesn't fallback to the javadoc.
http://jira.codehaus.org/browse/MECLIPSE-292
--Brian
Re: [VOTE] Configure IDE plugins to download sources by default within
Maven projects
Posted by Kenney Westerhof <ke...@apache.org>.
Ok, if you really need both sources and javadoc then that should
be possible. I never heard of the shift-f2 but indeed it doesn't work here.
I either use the tooltip when I hover over an element and possibly f2 for focus,
or open the javadoc view which displays the javadoc as soon as I select any element, which
does work with sources - no javadoc needed. This seems more of a bug
in eclipse than anything else though.
So I propose:
- if -DdownloadSources is specified, download sources and fallback to javadoc, just as it is now
- if -DdownloadJavaDoc is specified, download javadoc (possibly fallback to sources)
- if both are specified, download both.
And:
- don't make this a default; the default behaviour of attaching
either source or javadoc when it's present in the local repo
is fine though, but turning this on by default is just too slow.
-- Kenney
Mark Hobson wrote:
> On 05/07/07, Cabasson Denis <de...@insee.fr> wrote:
>> Well, I kinda changed the suject of the discussion.
>>
>> The matter here is whether the eclipse-plugin should be able to
>> download "sources AND javadoc" or only (as is the cas right now)
>> "sources, and only javadoc as a fallback if sources are missing". I'd
>> like to get the plugin download and link both for me.
>>
>> But I agree with you on the matter that is not the original
>> discussion, but it's closely related.
>> I don't really see how the original discussion could do with the
>> actual version of the plugin BTW.
>
> I agree that the eclipse plugin should be able to attach source jars,
> javadoc jars or both (MECLIPSE-292), but I think the original
> proposition proved to be too contentious. I'm happy to leave it to
> users' discretion for now.
>
> Mark
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: [VOTE] Configure IDE plugins to download sources by default within Maven projects
Posted by Mark Hobson <ma...@gmail.com>.
On 05/07/07, Cabasson Denis <de...@insee.fr> wrote:
> Well, I kinda changed the suject of the discussion.
>
> The matter here is whether the eclipse-plugin should be able to download "sources AND javadoc" or only (as is the cas right now) "sources, and only javadoc as a fallback if sources are missing". I'd like to get the plugin download and link both for me.
>
> But I agree with you on the matter that is not the original discussion, but it's closely related.
> I don't really see how the original discussion could do with the actual version of the plugin BTW.
I agree that the eclipse plugin should be able to attach source jars,
javadoc jars or both (MECLIPSE-292), but I think the original
proposition proved to be too contentious. I'm happy to leave it to
users' discretion for now.
Mark
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
RE: [VOTE] Configure IDE plugins to download sources by default within Maven projects
Posted by Cabasson Denis <de...@insee.fr>.
Well, I kinda changed the suject of the discussion.
The matter here is whether the eclipse-plugin should be able to download "sources AND javadoc" or only (as is the cas right now) "sources, and only javadoc as a fallback if sources are missing". I'd like to get the plugin download and link both for me.
But I agree with you on the matter that is not the original discussion, but it's closely related.
I don't really see how the original discussion could do with the actual version of the plugin BTW.
Denis.
> -----Message d'origine-----
> De : Jochen Wiedmann [mailto:jochen.wiedmann@gmail.com]
> Envoyé : Thursday, July 05, 2007 11:42 AM
> À : Maven Developers List
> Objet : Re: [VOTE] Configure IDE plugins to download sources
> by default within Maven projects
>
> On 7/5/07, Cabasson Denis <de...@insee.fr> wrote:
>
> > Basically, I tend to agree with you Kenney. But I have
> users who love to use Shift+F2 within eclipse (which opens a
> browser like window with the view of the javadoc in eclipse),
> and I don't really see why those users should be denied to
> use their eclipse the way they want.
>
> Noone denies them doing so. The question is simply, whether
> the required configuration snippet must go into the Maven
> POM's or whether one can expect that those users who want it
> (which includes me, btw, although I am voting against the
> proposal) can add the same snippet to a settings.xml or profiles.xml.
>
> Jochen
>
> --
> "Besides, manipulating elections is under penalty of law,
> resulting in a preventative effect against manipulating elections.
>
> The german government justifying the use of electronic voting
> machines and obviously believing that we don't need a
> police, because all illegal actions are forbidden.
>
> http://dip.bundestag.de/btd/16/051/1605194.pdf
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org For
> additional commands, e-mail: dev-help@maven.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: [VOTE] Configure IDE plugins to download sources by default within Maven projects
Posted by Jochen Wiedmann <jo...@gmail.com>.
On 7/5/07, Cabasson Denis <de...@insee.fr> wrote:
> Basically, I tend to agree with you Kenney. But I have users who love to use Shift+F2 within eclipse (which opens a browser like window with the view of the javadoc in eclipse), and I don't really see why those users should be denied to use their eclipse the way they want.
Noone denies them doing so. The question is simply, whether the
required configuration snippet must go into the Maven POM's or whether
one can expect that those users who want it (which includes me, btw,
although I am voting against the proposal) can add the same snippet to
a settings.xml or profiles.xml.
Jochen
--
"Besides, manipulating elections is under penalty of law, resulting in
a preventative effect against manipulating elections.
The german government justifying the use of electronic voting machines
and obviously believing that we don't need a police, because all
illegal actions are forbidden.
http://dip.bundestag.de/btd/16/051/1605194.pdf
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
RE: [VOTE] Configure IDE plugins to download sources by default within Maven projects
Posted by Cabasson Denis <de...@insee.fr>.
Basically, I tend to agree with you Kenney. But I have users who love to use Shift+F2 within eclipse (which opens a browser like window with the view of the javadoc in eclipse), and I don't really see why those users should be denied to use their eclipse the way they want.
I have attached a path to MECLIPSE-292 which adds a downloadJavadoc parameter, working the way Sources is working. This way everybody will be able to choose.
Right now fallback from sources to javadoc isn't available, but if you think this feature is worth it, I can fix it.
Denis.
> -----Message d'origine-----
> De : Kenney Westerhof [mailto:kenney@apache.org]
> Envoyé : Wednesday, July 04, 2007 3:05 PM
> À : Maven Developers List
> Objet : Re: [VOTE] Configure IDE plugins to download sources
> by default within Maven projects
>
>
>
> Cabasson Denis wrote:
> > About this link, why couldn't we have a consistent
> behaviour for javadoc and sources jar?
> >
> > Why not adding a downloadJavadoc property, which, when set
> to true, would download and attach the javadoc to the dependency.
> >
> > I don't really see why javadoc should be a fallback if
> sources are not available.
>
> I wrote that, so I'll comment.
>
> You do NOT need javadoc if you have sources available in
> eclipse. Eclipse will use the javadoc from the sources.
>
> -1 on all votes btw. If you want sources, tell the plugin. It
> will get _all_ sources (and possibly _all_ javadocs if you
> want that), which can take a few hours to do on a reasonably
> sized project. If you really need to, or want to, make a
> profile in settings.xml or config in a root pom.
>
> -- Kenney
>
>
> >
> > Some developpers might prefer to have javadoc linked, some
> sources linked and some both. Shouldn't the eclipse plugin
> allow for all the possiblities instead of stating that the
> preferred option is always to get the sources instead of the Javadoc?
> >
> > To be followed in :
> > http://jira.codehaus.org/browse/MECLIPSE-292
> >
> > Denis.
> >
> >
> >> -----Message d'origine-----
> >> De : Mark Hobson [mailto:markhobson@gmail.com] Envoyé :
> Tuesday, July
> >> 03, 2007 4:08 PM À : Maven Developers List Objet : Re: [VOTE]
> >> Configure IDE plugins to download sources by default within Maven
> >> projects
> >>
> >> On 03/07/07, Brett Porter <br...@apache.org> wrote:
> >>> +1 to Javadoc
> >>>
> >>> -1 to sources (just a vote, not a veto :)
> >> In the eclipse plugin, the downloadSources flag controls them both:
> >> http://maven.apache.org/plugins/maven-eclipse-plugin/faq.html#
> >> import-javadoc
> >>
> >> Mark
> >>
> >>
> ---------------------------------------------------------------------
> >> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org For
> >> additional commands, e-mail: dev-help@maven.apache.org
> >>
> >>
> >
> >
> ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org For
> > additional commands, e-mail: dev-help@maven.apache.org
> >
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org For
> additional commands, e-mail: dev-help@maven.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: [VOTE] Configure IDE plugins to download sources by default within
Maven projects
Posted by Kenney Westerhof <ke...@apache.org>.
Cabasson Denis wrote:
> About this link, why couldn't we have a consistent behaviour for javadoc and sources jar?
>
> Why not adding a downloadJavadoc property, which, when set to true, would download and attach the javadoc to the dependency.
>
> I don't really see why javadoc should be a fallback if sources are not available.
I wrote that, so I'll comment.
You do NOT need javadoc if you have sources available in eclipse. Eclipse will use the javadoc
from the sources.
-1 on all votes btw. If you want sources, tell the plugin. It will get _all_ sources
(and possibly _all_ javadocs if you want that), which can take a few hours to do on
a reasonably sized project. If you really need to, or want to, make a profile in settings.xml
or config in a root pom.
-- Kenney
>
> Some developpers might prefer to have javadoc linked, some sources linked and some both. Shouldn't the eclipse plugin allow for all the possiblities instead of stating that the preferred option is always to get the sources instead of the Javadoc?
>
> To be followed in :
> http://jira.codehaus.org/browse/MECLIPSE-292
>
> Denis.
>
>
>> -----Message d'origine-----
>> De : Mark Hobson [mailto:markhobson@gmail.com]
>> Envoyé : Tuesday, July 03, 2007 4:08 PM
>> À : Maven Developers List
>> Objet : Re: [VOTE] Configure IDE plugins to download sources
>> by default within Maven projects
>>
>> On 03/07/07, Brett Porter <br...@apache.org> wrote:
>>> +1 to Javadoc
>>>
>>> -1 to sources (just a vote, not a veto :)
>> In the eclipse plugin, the downloadSources flag controls them both:
>> http://maven.apache.org/plugins/maven-eclipse-plugin/faq.html#
>> import-javadoc
>>
>> Mark
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org For
>> additional commands, e-mail: dev-help@maven.apache.org
>>
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
RE: [VOTE] Configure IDE plugins to download sources by default within Maven projects
Posted by Cabasson Denis <de...@insee.fr>.
About this link, why couldn't we have a consistent behaviour for javadoc and sources jar?
Why not adding a downloadJavadoc property, which, when set to true, would download and attach the javadoc to the dependency.
I don't really see why javadoc should be a fallback if sources are not available.
Some developpers might prefer to have javadoc linked, some sources linked and some both. Shouldn't the eclipse plugin allow for all the possiblities instead of stating that the preferred option is always to get the sources instead of the Javadoc?
To be followed in :
http://jira.codehaus.org/browse/MECLIPSE-292
Denis.
> -----Message d'origine-----
> De : Mark Hobson [mailto:markhobson@gmail.com]
> Envoyé : Tuesday, July 03, 2007 4:08 PM
> À : Maven Developers List
> Objet : Re: [VOTE] Configure IDE plugins to download sources
> by default within Maven projects
>
> On 03/07/07, Brett Porter <br...@apache.org> wrote:
> > +1 to Javadoc
> >
> > -1 to sources (just a vote, not a veto :)
>
> In the eclipse plugin, the downloadSources flag controls them both:
> http://maven.apache.org/plugins/maven-eclipse-plugin/faq.html#
> import-javadoc
>
> Mark
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org For
> additional commands, e-mail: dev-help@maven.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: [VOTE] Configure IDE plugins to download sources by default within Maven projects
Posted by Mark Hobson <ma...@gmail.com>.
On 03/07/07, Brett Porter <br...@apache.org> wrote:
> +1 to Javadoc
>
> -1 to sources (just a vote, not a veto :)
In the eclipse plugin, the downloadSources flag controls them both:
http://maven.apache.org/plugins/maven-eclipse-plugin/faq.html#import-javadoc
Mark
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: [VOTE] Configure IDE plugins to download sources by default within Maven projects
Posted by Brett Porter <br...@apache.org>.
+1 to Javadoc
-1 to sources (just a vote, not a veto :)
On 03/07/2007, at 11:48 PM, Mark Hobson wrote:
> Following the recent thread "Maven POM plugin config", this is a vote
> to add downloadSources=true to both the eclipse and idea plugin
> configurations in the maven-parent POM:
>
> [ ] +1: I like Javadoc and easy debugging
> [ ] +0: I'll go with the flow
> [ ] -1: I like superfluous typing, guessing Javadoc and reading
> bytecode
>
> +1 from me.
>
> Mark
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
RE: [VOTE] Configure IDE plugins to download sources by default within Maven projects
Posted by "Brian E. Fox" <br...@reply.infinity.nu>.
I would be +1 except that this will break the current tests in eclipse. We need to solve that first, and then I'm good. (see my reply to the previous thread) and http://jira.codehaus.org/browse/MECLIPSE-288
since this will break the eclipse tests, I have to say -1 until we can be sure it won't or find a way around it.
________________________________
From: Mark Hobson [mailto:markhobson@gmail.com]
Sent: Tue 7/3/2007 9:48 AM
To: Maven Developers List
Subject: [VOTE] Configure IDE plugins to download sources by default within Maven projects
Following the recent thread "Maven POM plugin config", this is a vote
to add downloadSources=true to both the eclipse and idea plugin
configurations in the maven-parent POM:
[ ] +1: I like Javadoc and easy debugging
[ ] +0: I'll go with the flow
[ ] -1: I like superfluous typing, guessing Javadoc and reading bytecode
+1 from me.
Mark
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org