You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/06/18 20:59:54 UTC
[GitHub] [superset] michael-s-molina opened a new pull request #15265: chore: Migrates ControlHeader icons
michael-s-molina opened a new pull request #15265:
URL: https://github.com/apache/superset/pull/15265
### SUMMARY
Migrates ControlHeader icons.
@pkdotson
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<img width="309" alt="Screen Shot 2021-06-18 at 2 30 07 PM" src="https://user-images.githubusercontent.com/70410625/122597571-ee09bf80-d041-11eb-818a-b1ffdb344f02.png">
<img width="310" alt="Screen Shot 2021-06-18 at 2 19 46 PM" src="https://user-images.githubusercontent.com/70410625/122597578-f06c1980-d041-11eb-8131-ca18aca85220.png">
<img width="307" alt="Screen Shot 2021-06-18 at 2 30 43 PM" src="https://user-images.githubusercontent.com/70410625/122597592-f530cd80-d041-11eb-98c0-516ebb54c4c3.png">
<img width="311" alt="Screen Shot 2021-06-18 at 2 27 38 PM" src="https://user-images.githubusercontent.com/70410625/122597599-f8c45480-d041-11eb-9cf6-31b8856ef62a.png">
### TESTING INSTRUCTIONS
1 - Go to explore
2 - Change the controls to show the icons
### ADDITIONAL INFORMATION
- [ ] Has associated issue:
- [x] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] github-actions[bot] commented on pull request #15265: chore: Migrates ControlHeader icons
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #15265:
URL: https://github.com/apache/superset/pull/15265#issuecomment-868746404
Ephemeral environment shutdown and build artifacts deleted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] pkdotson commented on pull request #15265: chore: Migrates ControlHeader icons
Posted by GitBox <gi...@apache.org>.
pkdotson commented on pull request #15265:
URL: https://github.com/apache/superset/pull/15265#issuecomment-864253839
/testenv up
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] michael-s-molina commented on pull request #15265: chore: Migrates ControlHeader icons
Posted by GitBox <gi...@apache.org>.
michael-s-molina commented on pull request #15265:
URL: https://github.com/apache/superset/pull/15265#issuecomment-864397115
> I notice they are a little different but that's probably because the new icons aren't exactly the same.
@pkdotson Exactly. The new warning and error icons are different.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] pkdotson commented on pull request #15265: chore: Migrates ControlHeader icons
Posted by GitBox <gi...@apache.org>.
pkdotson commented on pull request #15265:
URL: https://github.com/apache/superset/pull/15265#issuecomment-864283257
@michael-s-molina did the new icons get design signoff? I notice they are a little different but that's probably because the new icons aren't exactly the same.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] michael-s-molina merged pull request #15265: chore: Migrates ControlHeader icons
Posted by GitBox <gi...@apache.org>.
michael-s-molina merged pull request #15265:
URL: https://github.com/apache/superset/pull/15265
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] michael-s-molina commented on pull request #15265: chore: Migrates ControlHeader icons
Posted by GitBox <gi...@apache.org>.
michael-s-molina commented on pull request #15265:
URL: https://github.com/apache/superset/pull/15265#issuecomment-868746132
> One small detail to consider... I noticed that the icons are a little high up, vertically. It seems the `anticon` class has a `vertical-align` of `-.125em` for some reason. If I override that with `vertical-align: middle;` it aligns much better with the text.
>
> 
>
> While this _sounds_ like a sensible global change, I'm not sure what fallout/misalignments it might cause. We can pus this PR through as is, or stop and poke around at this. Your call. If you want to merge as is, maybe we can make a project board of "Things to try when we have visual regression testing"
Someone probably fixed this while changing another requirement. This is the current state with latest `master`:
<img width="313" alt="Screen Shot 2021-06-25 at 3 10 04 PM" src="https://user-images.githubusercontent.com/70410625/123467922-78649d00-d5c7-11eb-8389-3731be7ca79a.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #15265: chore: Migrates ControlHeader icons
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #15265:
URL: https://github.com/apache/superset/pull/15265#issuecomment-864196722
# [Codecov](https://codecov.io/gh/apache/superset/pull/15265?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#15265](https://codecov.io/gh/apache/superset/pull/15265?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (4f2d1b3) into [master](https://codecov.io/gh/apache/superset/commit/2cf99467fc49e9a99045215544bf92982655cdb0?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (2cf9946) will **decrease** coverage by `0.23%`.
> The diff coverage is `100.00%`.
> :exclamation: Current head 4f2d1b3 differs from pull request most recent head 62d1ae0. Consider uploading reports for the commit 62d1ae0 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/15265?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #15265 +/- ##
==========================================
- Coverage 77.26% 77.03% -0.24%
==========================================
Files 971 972 +1
Lines 50308 50316 +8
Branches 6140 6140
==========================================
- Hits 38869 38759 -110
- Misses 11235 11353 +118
Partials 204 204
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `?` | |
| javascript | `71.80% <100.00%> (+<0.01%)` | :arrow_up: |
| presto | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/15265?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...-frontend/src/explore/components/ControlHeader.jsx](https://codecov.io/gh/apache/superset/pull/15265/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9Db250cm9sSGVhZGVyLmpzeA==) | `86.20% <100.00%> (+0.49%)` | :arrow_up: |
| [superset/db\_engine\_specs/ascend.py](https://codecov.io/gh/apache/superset/pull/15265/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2FzY2VuZC5weQ==) | `100.00% <100.00%> (ø)` | |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/15265/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-82.15%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/15265/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `69.20% <0.00%> (-17.21%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/15265/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `83.36% <0.00%> (-6.95%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/superset/pull/15265/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `81.03% <0.00%> (-1.73%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/superset/pull/15265/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `88.15% <0.00%> (-1.66%)` | :arrow_down: |
| [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/superset/pull/15265/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `87.97% <0.00%> (-0.41%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/superset/pull/15265/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `89.76% <0.00%> (-0.27%)` | :arrow_down: |
| [superset/utils/core.py](https://codecov.io/gh/apache/superset/pull/15265/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdXRpbHMvY29yZS5weQ==) | `88.93% <0.00%> (-0.13%)` | :arrow_down: |
| ... and [1 more](https://codecov.io/gh/apache/superset/pull/15265/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/15265?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/15265?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [2cf9946...62d1ae0](https://codecov.io/gh/apache/superset/pull/15265?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas commented on pull request #15265: chore: Migrates ControlHeader icons
Posted by GitBox <gi...@apache.org>.
rusackas commented on pull request #15265:
URL: https://github.com/apache/superset/pull/15265#issuecomment-865960588
One small detail to consider... I noticed that the icons are a little high up, vertically. It seems the `anticon` class has a `vertical-align` of `-.125em` for some reason. If I override that with `vertical-align: middle;` it aligns much better with the text.
While this _sounds_ like a sensible global change, I'm not sure what fallout/misalignments it might cause. We can pus this PR through as is, or stop and poke around at this. Your call. If you want to merge as is, maybe we can make a project board of "Things to try when we have visual regression testing"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] github-actions[bot] commented on pull request #15265: chore: Migrates ControlHeader icons
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #15265:
URL: https://github.com/apache/superset/pull/15265#issuecomment-864254661
@pkdotson Ephemeral environment spinning up at http://54.191.171.237:8080. Credentials are `admin`/`admin`. Please allow several minutes for bootstrapping and startup.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org