You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@lucene.apache.org by "Mike Drob (Jira)" <ji...@apache.org> on 2020/06/11 19:23:00 UTC

[jira] [Resolved] (SOLR-8392) SolrParam.get(String) returns String and shouldn't be used in other instanceof checks

     [ https://issues.apache.org/jira/browse/SOLR-8392?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Mike Drob resolved SOLR-8392.
-----------------------------
    Fix Version/s:     (was: 7.0)
                   master (9.0)
       Resolution: Fixed

> SolrParam.get(String) returns String and shouldn't be used in other instanceof checks
> -------------------------------------------------------------------------------------
>
>                 Key: SOLR-8392
>                 URL: https://issues.apache.org/jira/browse/SOLR-8392
>             Project: Solr
>          Issue Type: Bug
>            Reporter: Mike Drob
>            Assignee: Mike Drob
>            Priority: Major
>             Fix For: master (9.0)
>
>         Attachments: SOLR-8392.patch, SOLR-8392.patch
>
>          Time Spent: 40m
>  Remaining Estimate: 0h
>
> There's a couple of places where we declare the return type of solrParams.get() as an Object and then do instanceof checks for other types. Since we know it will be a String, we can simplify this logic in several places.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org