[jira] [Commented] (BEAM-27) Add user-ready API for interacting with timers

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/BEAM-27?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15574420#comment-15574420 ] 

ASF GitHub Bot commented on BEAM-27:
------------------------------------

GitHub user kennknowles opened a pull request:

    https://github.com/apache/incubator-beam/pull/1102

    [BEAM-27] Add initial bits for DoFn Timer API

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [x] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [x] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [x] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
    
    ---
    
    R: @jkff 
    CC: @bjchambers who gave lots of good feedback on the `StateSpec` version of this PR. Time permitting, see if you have opinions about this simpler one.
    
    This adds the interfaces and annotations from the design for the user-facing timer API, with basic reflection and validation and some tests.
    
    (while putting this together, I noticed that there were state examples that were invalid in ways other than the way they were testing, so that commit is in this PR too)

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/kennknowles/incubator-beam TimerSpec

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-beam/pull/1102.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1102
    
----
commit 238b7eaa9425247ce7152b268d488581032e5411
Author: Kenneth Knowles <kl...@google.com>
Date:   2016-10-14T06:18:40Z

    Tighten up tests for StateId validation

commit b1aa85d764c70ce648e4d5c068ce1b7f1e36a2ac
Author: Kenneth Knowles <kl...@google.com>
Date:   2016-10-13T20:41:38Z

    Add Timer, TimerId, TimerSpec and TimerSpecs
    
    These are the simple specifications that describe
    a timer without instantiating it. Consists only of
    the time domain.

commit 0cd37b50ee0d92886060fe9cb8e28273e24e0c13
Author: Kenneth Knowles <kl...@google.com>
Date:   2016-10-14T02:53:31Z

    Add DoFnSignatures analysis of timer declarations

commit fe2cf1688068ac0731b67724c1a8f591f03ab159
Author: Kenneth Knowles <kl...@google.com>
Date:   2016-10-14T06:17:36Z

    Reject all timers in ParDo, for now

----


> Add user-ready API for interacting with timers
> ----------------------------------------------
>
>                 Key: BEAM-27
>                 URL: https://issues.apache.org/jira/browse/BEAM-27
>             Project: Beam
>          Issue Type: Sub-task
>          Components: sdk-java-core
>            Reporter: Kenneth Knowles
>            Assignee: Kenneth Knowles
>
> Pipeline authors will benefit from a different factorization of interaction with underlying timers. The current APIs are targeted at runner implementers.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)