You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/04/20 15:42:52 UTC

[GitHub] [airflow] jedcunningham commented on a diff in pull request #23121: Don't try to truncate tracebacks in Tasks outside of "user" code

jedcunningham commented on code in PR #23121:
URL: https://github.com/apache/airflow/pull/23121#discussion_r854290356


##########
airflow/models/taskinstance.py:
##########
@@ -1650,6 +1652,8 @@ def _execute_task(self, context, task_orig):
         except:  # noqa: E722
             _TASK_EXECUTION_FRAME_LOCAL_STORAGE.frame = currentframe()
             raise
+        finally:
+            del _TASK_EXECUTION_FRAME_LOCAL_STORAGE.in_user_code

Review Comment:
   Should we set this to False instead of deleting it? Might not actually matter, but could let us simplify `get_truncated_error_traceback`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org