You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/05/25 04:04:03 UTC

[GitHub] [arrow-rs] jorgecarleitao commented on a change in pull request #317: Add (simd) modulus op

jorgecarleitao commented on a change in pull request #317:
URL: https://github.com/apache/arrow-rs/pull/317#discussion_r638437150



##########
File path: arrow/src/error.rs
##########
@@ -110,6 +111,7 @@ impl Display for ArrowError {
             ArrowError::SchemaError(desc) => write!(f, "Schema error: {}", desc),
             ArrowError::ComputeError(desc) => write!(f, "Compute error: {}", desc),
             ArrowError::DivideByZero => write!(f, "Divide by zero error"),
+            ArrowError::ModulusByZero => write!(f, "Modulus by zero error"),

Review comment:
       I would not add a new error for this; can't we use `ComputeError` or `DivideByZero`?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org