You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@royale.apache.org by GitBox <gi...@apache.org> on 2021/11/13 00:10:37 UTC
[GitHub] [royale-asjs] estanglerbm opened a new pull request #1164: XML - Copy blank attribute values.
estanglerbm opened a new pull request #1164:
URL: https://github.com/apache/royale-asjs/pull/1164
Undoing a change made by @harbs in commit 6664fb4bb5308b376ba269635a48e63ba729ba7b.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@royale.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [royale-asjs] estanglerbm commented on pull request #1164: XML - Copy blank attribute values.
Posted by GitBox <gi...@apache.org>.
estanglerbm commented on pull request #1164:
URL: https://github.com/apache/royale-asjs/pull/1164#issuecomment-968175580
To be clear, you're talking about excessive memory usage because there are many empty strings (as part of parsing XML using DOMParser.parseFromString) besides attributes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@royale.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [royale-asjs] Harbs commented on pull request #1164: XML - Copy blank attribute values.
Posted by GitBox <gi...@apache.org>.
Harbs commented on pull request #1164:
URL: https://github.com/apache/royale-asjs/pull/1164#issuecomment-968095911
In fact, we're probably setting empty values in more places than we should.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@royale.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [royale-asjs] Harbs closed pull request #1164: XML - Copy blank attribute values.
Posted by GitBox <gi...@apache.org>.
Harbs closed pull request #1164:
URL: https://github.com/apache/royale-asjs/pull/1164
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@royale.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [royale-asjs] Harbs commented on pull request #1164: XML - Copy blank attribute values.
Posted by GitBox <gi...@apache.org>.
Harbs commented on pull request #1164:
URL: https://github.com/apache/royale-asjs/pull/1164#issuecomment-968095034
This causes empty attributes to use more memory.
That commit made a very big difference in memory usage of XML. The values are not being set on purpose.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@royale.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [royale-asjs] Harbs commented on pull request #1164: XML - Copy blank attribute values.
Posted by GitBox <gi...@apache.org>.
Harbs commented on pull request #1164:
URL: https://github.com/apache/royale-asjs/pull/1164#issuecomment-968219668
Exactly.
My use case made extensive use of `copy`, so fixing it in `copy` made a big difference. I should have done a better job on the optimization the first time around... 😉
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@royale.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [royale-asjs] Harbs commented on pull request #1164: XML - Copy blank attribute values.
Posted by GitBox <gi...@apache.org>.
Harbs commented on pull request #1164:
URL: https://github.com/apache/royale-asjs/pull/1164#issuecomment-968128710
Resolved in 4c4e9ee4e5f69d30b8bf25f3b236cf35aae70c4c
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@royale.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org