You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by "kezhenxu94 (via GitHub)" <gi...@apache.org> on 2023/08/24 06:26:26 UTC
[GitHub] [dolphinscheduler] kezhenxu94 opened a new pull request, #14803: Remove `@AccessLogAnnotation` annotation, replace with built-in access log
kezhenxu94 opened a new pull request, #14803:
URL: https://github.com/apache/dolphinscheduler/pull/14803
All http servers have already built in the access logs, we don't bother to replicate the features by ourselves, and reduce the annotations in the API controllers.
With the built in logs, users can:
- Modify the log format as they want, so that they can parse or analyze the logs in any system.
- Change the logs file location to wherever they like.
- Configure paths to ignore without rebuilding the package.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] kezhenxu94 commented on a diff in pull request #14803: Remove `@AccessLogAnnotation` annotation, replace with built-in access log
Posted by "kezhenxu94 (via GitHub)" <gi...@apache.org>.
kezhenxu94 commented on code in PR #14803:
URL: https://github.com/apache/dolphinscheduler/pull/14803#discussion_r1303863450
##########
dolphinscheduler-standalone-server/src/main/resources/application.yaml:
##########
@@ -242,6 +242,9 @@ server:
mime-types: text/html,text/xml,text/plain,text/css,text/javascript,application/javascript,application/json,application/xml
jetty:
max-http-form-post-size: 5000000
+ accesslog:
Review Comment:
It also only logs query string, not request body
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] kezhenxu94 commented on a diff in pull request #14803: Remove `@AccessLogAnnotation` annotation, replace with built-in access log
Posted by "kezhenxu94 (via GitHub)" <gi...@apache.org>.
kezhenxu94 commented on code in PR #14803:
URL: https://github.com/apache/dolphinscheduler/pull/14803#discussion_r1303862396
##########
dolphinscheduler-standalone-server/src/main/resources/application.yaml:
##########
@@ -242,6 +242,9 @@ server:
mime-types: text/html,text/xml,text/plain,text/css,text/javascript,application/javascript,application/json,application/xml
jetty:
max-http-form-post-size: 5000000
+ accesslog:
Review Comment:
> Will this configuration log `@RequestAttribute(value = Constants.SESSION_USER) User loginUser`? Seems there are some credentials in `User` object.
No, it logs the http request parameters, not the controller method's arguments. Obviously credentials are not in the request parameters, they are in headers
##########
dolphinscheduler-standalone-server/src/main/resources/application.yaml:
##########
@@ -242,6 +242,9 @@ server:
mime-types: text/html,text/xml,text/plain,text/css,text/javascript,application/javascript,application/json,application/xml
jetty:
max-http-form-post-size: 5000000
+ accesslog:
Review Comment:
> Will this configuration log `@RequestAttribute(value = Constants.SESSION_USER) User loginUser`? Seems there are some credentials in `User` object.
No, it logs the http request parameters, not the controller method's arguments. Obviously credentials are not in the request parameters, they are in http headers
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] EricGao888 commented on a diff in pull request #14803: Remove `@AccessLogAnnotation` annotation, replace with built-in access log
Posted by "EricGao888 (via GitHub)" <gi...@apache.org>.
EricGao888 commented on code in PR #14803:
URL: https://github.com/apache/dolphinscheduler/pull/14803#discussion_r1303861272
##########
dolphinscheduler-standalone-server/src/main/resources/application.yaml:
##########
@@ -242,6 +242,9 @@ server:
mime-types: text/html,text/xml,text/plain,text/css,text/javascript,application/javascript,application/json,application/xml
jetty:
max-http-form-post-size: 5000000
+ accesslog:
Review Comment:
Will this configuration log `@RequestAttribute(value = Constants.SESSION_USER) User loginUser`? Seems there are some credentials in `User` object.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] sonarcloud[bot] commented on pull request #14803: Remove `@AccessLogAnnotation` annotation, replace with built-in access log
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #14803:
URL: https://github.com/apache/dolphinscheduler/pull/14803#issuecomment-1691107046
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=14803)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=14803&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=14803&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=14803&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=14803&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=14803&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=14803&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=14803&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=14803&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=14803&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=14803&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=14803&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=14803&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=14803&metric=coverage&view=list) No Coverage information
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=14803&metric=duplicated_lines_density&view=list) No Duplication information
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] kezhenxu94 commented on pull request #14803: Remove `@AccessLogAnnotation` annotation, replace with built-in access log
Posted by "kezhenxu94 (via GitHub)" <gi...@apache.org>.
kezhenxu94 commented on PR #14803:
URL: https://github.com/apache/dolphinscheduler/pull/14803#issuecomment-1691129569
> LGTM. I tested on standalone,
>
> ```
> accesslog:
> enabled: true
> custom-format: '%{client}a - %u %t "%r" %s %O %{ms}Tms'
> ```
>
> it look like below
>
> ```
> 127.0.0.1 - - [24/Aug/2023:06:34:38 +0000] "GET /dolphinscheduler/projects/analysis/process-state-count?startDate=2023-08-24%2000%3A00%3A00&endDate=2023-08-24%2014%3A34%3A38&projectCode=0 HTTP/1.1" 200 230 15ms
> 127.0.0.1 - - [24/Aug/2023:06:34:38 +0000] "GET /dolphinscheduler/projects/analysis/task-state-count?startDate=2023-08-24%2000%3A00%3A00&endDate=2023-08-24%2014%3A34%3A38&projectCode=0 HTTP/1.1" 200 236 15ms
> 127.0.0.1 - - [24/Aug/2023:06:34:38 +0000] "GET /dolphinscheduler/projects/analysis/define-user-count?projectCode=0 HTTP/1.1" 200 103 16ms
> ```
>
> Can we log the username ? it seems `%u` doesn't work.
The `%u` doesn't work because the authentication is not done as in Spring way, I shall fix these in following PRs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] EricGao888 commented on a diff in pull request #14803: Remove `@AccessLogAnnotation` annotation, replace with built-in access log
Posted by "EricGao888 (via GitHub)" <gi...@apache.org>.
EricGao888 commented on code in PR #14803:
URL: https://github.com/apache/dolphinscheduler/pull/14803#discussion_r1303861272
##########
dolphinscheduler-standalone-server/src/main/resources/application.yaml:
##########
@@ -242,6 +242,9 @@ server:
mime-types: text/html,text/xml,text/plain,text/css,text/javascript,application/javascript,application/json,application/xml
jetty:
max-http-form-post-size: 5000000
+ accesslog:
Review Comment:
Will this configuration logs `@RequestAttribute(value = Constants.SESSION_USER) User loginUser`? Seems there are some credentials in `User` object.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] kezhenxu94 merged pull request #14803: Remove `@AccessLogAnnotation` annotation, replace with built-in access log
Posted by "kezhenxu94 (via GitHub)" <gi...@apache.org>.
kezhenxu94 merged PR #14803:
URL: https://github.com/apache/dolphinscheduler/pull/14803
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] kezhenxu94 commented on pull request #14803: Remove `@AccessLogAnnotation` annotation, replace with built-in access log
Posted by "kezhenxu94 (via GitHub)" <gi...@apache.org>.
kezhenxu94 commented on PR #14803:
URL: https://github.com/apache/dolphinscheduler/pull/14803#issuecomment-1691138573
Merging, will look into the API-Test CI issue, might be something configured wrong
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] sonarcloud[bot] commented on pull request #14803: Remove `@AccessLogAnnotation` annotation, replace with built-in access log
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #14803:
URL: https://github.com/apache/dolphinscheduler/pull/14803#issuecomment-1691114983
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=14803)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=14803&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=14803&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=14803&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=14803&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=14803&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=14803&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=14803&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=14803&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=14803&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=14803&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=14803&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=14803&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=14803&metric=coverage&view=list) No Coverage information
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=14803&metric=duplicated_lines_density&view=list) No Duplication information
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org