[jira] [Commented] (FLINK-5424) Improve Restart Strategy Logging

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-5424?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15805642#comment-15805642 ] 

ASF GitHub Bot commented on FLINK-5424:
---------------------------------------

GitHub user rehevkor5 opened a pull request:

    https://github.com/apache/flink/pull/3079

    [FLINK-5424] Improve Restart Strategy Logging

    - Added toString for FailureRateRestartStrategy (important for
    JobManager's "Using restart strategy $restartStrategy" log message)
    - Added explanation in log when the restart strategy is responsible
    for preventing job restart
    
    Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration.
    If your changes take all of the items into account, feel free to open your pull request. For more information and/or questions please refer to the [How To Contribute guide](http://flink.apache.org/how-to-contribute.html).
    In addition to going through the list, please provide a meaningful description of your changes.
    
    - [ ] General
      - The pull request references the related JIRA issue ("[FLINK-XXX] Jira title text")
      - The pull request addresses only one issue
      - Each commit in the PR has a meaningful commit message (including the JIRA id)
    
    - [ ] Documentation
      - Documentation has been added for new functionality
      - Old documentation affected by the pull request has been updated
      - JavaDoc for public methods has been added
    
    - [ ] Tests & Build
      - Functionality added by the pull request is covered by tests
      - `mvn clean verify` has been executed successfully locally or a Travis build has passed


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/rehevkor5/flink FLINK-5424

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/3079.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3079
    
----

----


> Improve Restart Strategy Logging
> --------------------------------
>
>                 Key: FLINK-5424
>                 URL: https://issues.apache.org/jira/browse/FLINK-5424
>             Project: Flink
>          Issue Type: Improvement
>          Components: Core
>            Reporter: Shannon Carey
>            Assignee: Shannon Carey
>            Priority: Minor
>
> I'll be submitting a PR which includes some minor improvements to logging related to restart strategies.
> Specifically, I added a toString so that the log contains better info about failure-rate restart strategy, and I added an explanation in the log when the restart strategy is responsible for preventing job restart (currently, there's no indication that the restart strategy had anything to do with it).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)