[GitHub] [incubator-superset] etr2460 commented on a change in pull request #9356: Enforcing linting of LESS

[GitBox <gi...@apache.org>]

etr2460 commented on a change in pull request #9356: Enforcing linting of LESS
URL: https://github.com/apache/incubator-superset/pull/9356#discussion_r397569330
 
 

 ##########
 File path: superset-frontend/package.json
 ##########
 @@ -16,7 +16,7 @@
     "prod": "node --max_old_space_size=4096 ./node_modules/webpack/bin/webpack.js --mode=production --colors --progress",
     "build-dev": "cross-env NODE_OPTIONS=--max_old_space_size=8192 NODE_ENV=development webpack --mode=development --colors --progress",
     "build": "cross-env NODE_OPTIONS=--max_old_space_size=8192 NODE_ENV=production webpack --mode=production --colors --progress",
-    "lint": "eslint --ignore-path=.eslintignore --ext .js,.jsx,.ts,.tsx .",
+    "lint": "eslint --ignore-path=.eslintignore --ext .js,.jsx,.ts,.tsx . && prettier --check '{src,stylesheets}/**/*.{css,less,sass,scss}'",
 
 Review comment:
   does eslint enforce the prettier checks already? Maybe we should move them out of eslint and into prettier if we're running the prettier checks anyway?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org