You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Qian Zhang <zh...@gmail.com> on 2019/10/17 09:45:12 UTC
Review Request 71629: Improved logging in Docker store and registry
puller.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71629/
-----------------------------------------------------------
Review request for mesos and Gilbert Song.
Bugs: MESOS-9964
https://issues.apache.org/jira/browse/MESOS-9964
Repository: mesos
Description
-------
Improved logging in Docker store and registry puller.
Diffs
-----
src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp 35b6afbb6b22575b90963927352443a8ddaf9885
src/slave/containerizer/mesos/provisioner/docker/store.cpp 286ee5f00933b4c86a96dc4e10e42f9e7eac0ce2
Diff: https://reviews.apache.org/r/71629/diff/1/
Testing
-------
Thanks,
Qian Zhang
Re: Review Request 71629: Improved logging in Docker store and
registry puller.
Posted by Gilbert Song <so...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71629/#review218286
-----------------------------------------------------------
Fix it, then Ship it!
src/slave/containerizer/mesos/provisioner/docker/store.cpp
Lines 430 (patched)
<https://reviews.apache.org/r/71629/#comment305953>
"moving layers from staging dir 'xxxx' to image store"?
- Gilbert Song
On Oct. 17, 2019, 5:58 p.m., Qian Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71629/
> -----------------------------------------------------------
>
> (Updated Oct. 17, 2019, 5:58 p.m.)
>
>
> Review request for mesos and Gilbert Song.
>
>
> Bugs: MESOS-9964
> https://issues.apache.org/jira/browse/MESOS-9964
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Improved logging in Docker store and registry puller.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp 35b6afbb6b22575b90963927352443a8ddaf9885
> src/slave/containerizer/mesos/provisioner/docker/store.cpp 286ee5f00933b4c86a96dc4e10e42f9e7eac0ce2
>
>
> Diff: https://reviews.apache.org/r/71629/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Qian Zhang
>
>
Re: Review Request 71629: Improved logging in Docker store and
registry puller.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71629/#review218288
-----------------------------------------------------------
Patch looks great!
Reviews applied: [71608, 71629]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On Oct. 18, 2019, 3:18 a.m., Qian Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71629/
> -----------------------------------------------------------
>
> (Updated Oct. 18, 2019, 3:18 a.m.)
>
>
> Review request for mesos and Gilbert Song.
>
>
> Bugs: MESOS-9964
> https://issues.apache.org/jira/browse/MESOS-9964
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Improved logging in Docker store and registry puller.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp 35b6afbb6b22575b90963927352443a8ddaf9885
> src/slave/containerizer/mesos/provisioner/docker/store.cpp 286ee5f00933b4c86a96dc4e10e42f9e7eac0ce2
>
>
> Diff: https://reviews.apache.org/r/71629/diff/3/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Qian Zhang
>
>
Re: Review Request 71629: Improved logging in Docker store and
registry puller.
Posted by Qian Zhang <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71629/
-----------------------------------------------------------
(Updated Oct. 18, 2019, 11:18 a.m.)
Review request for mesos and Gilbert Song.
Changes
-------
Addressed review comments.
Bugs: MESOS-9964
https://issues.apache.org/jira/browse/MESOS-9964
Repository: mesos
Description
-------
Improved logging in Docker store and registry puller.
Diffs (updated)
-----
src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp 35b6afbb6b22575b90963927352443a8ddaf9885
src/slave/containerizer/mesos/provisioner/docker/store.cpp 286ee5f00933b4c86a96dc4e10e42f9e7eac0ce2
Diff: https://reviews.apache.org/r/71629/diff/3/
Changes: https://reviews.apache.org/r/71629/diff/2-3/
Testing
-------
Thanks,
Qian Zhang
Re: Review Request 71629: Improved logging in Docker store and
registry puller.
Posted by Qian Zhang <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71629/
-----------------------------------------------------------
(Updated Oct. 18, 2019, 8:58 a.m.)
Review request for mesos and Gilbert Song.
Changes
-------
Addressed review comments.
Bugs: MESOS-9964
https://issues.apache.org/jira/browse/MESOS-9964
Repository: mesos
Description
-------
Improved logging in Docker store and registry puller.
Diffs (updated)
-----
src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp 35b6afbb6b22575b90963927352443a8ddaf9885
src/slave/containerizer/mesos/provisioner/docker/store.cpp 286ee5f00933b4c86a96dc4e10e42f9e7eac0ce2
Diff: https://reviews.apache.org/r/71629/diff/2/
Changes: https://reviews.apache.org/r/71629/diff/1-2/
Testing
-------
Thanks,
Qian Zhang
Re: Review Request 71629: Improved logging in Docker store and
registry puller.
Posted by Gilbert Song <so...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71629/#review218275
-----------------------------------------------------------
src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp
Lines 457-458 (original), 456-457 (patched)
<https://reviews.apache.org/r/71629/#comment305919>
Is this too verbose?
Each image may have 100 lines of this log
src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp
Lines 533-534 (original), 532-533 (patched)
<https://reviews.apache.org/r/71629/#comment305920>
ditto
src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp
Lines 544-545 (original), 543-544 (patched)
<https://reviews.apache.org/r/71629/#comment305921>
ditto
src/slave/containerizer/mesos/provisioner/docker/store.cpp
Lines 358 (patched)
<https://reviews.apache.org/r/71629/#comment305922>
we probably want to log this line in metadatamanager?
- Gilbert Song
On Oct. 17, 2019, 2:45 a.m., Qian Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71629/
> -----------------------------------------------------------
>
> (Updated Oct. 17, 2019, 2:45 a.m.)
>
>
> Review request for mesos and Gilbert Song.
>
>
> Bugs: MESOS-9964
> https://issues.apache.org/jira/browse/MESOS-9964
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Improved logging in Docker store and registry puller.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp 35b6afbb6b22575b90963927352443a8ddaf9885
> src/slave/containerizer/mesos/provisioner/docker/store.cpp 286ee5f00933b4c86a96dc4e10e42f9e7eac0ce2
>
>
> Diff: https://reviews.apache.org/r/71629/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Qian Zhang
>
>
Re: Review Request 71629: Improved logging in Docker store and
registry puller.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71629/#review218260
-----------------------------------------------------------
Patch looks great!
Reviews applied: [71608, 71629]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On Oct. 17, 2019, 9:45 a.m., Qian Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71629/
> -----------------------------------------------------------
>
> (Updated Oct. 17, 2019, 9:45 a.m.)
>
>
> Review request for mesos and Gilbert Song.
>
>
> Bugs: MESOS-9964
> https://issues.apache.org/jira/browse/MESOS-9964
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Improved logging in Docker store and registry puller.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp 35b6afbb6b22575b90963927352443a8ddaf9885
> src/slave/containerizer/mesos/provisioner/docker/store.cpp 286ee5f00933b4c86a96dc4e10e42f9e7eac0ce2
>
>
> Diff: https://reviews.apache.org/r/71629/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Qian Zhang
>
>