You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/09/28 20:28:43 UTC
[GitHub] [pulsar] michaeljmarshall opened a new pull request #12229: [Java Client] Remove unnecessary stats incremement
michaeljmarshall opened a new pull request #12229:
URL: https://github.com/apache/pulsar/pull/12229
### Motivation
The Java client currently increments a stat with the size of pending messages queue. This would make sense, except for the fact that the queue is cleared right before getting the size. Further, the stat in question is incremented within the `failPendingMessages` method, which is called right before the removed line.
### Modifications
* Remove the line `stats.incrementSendFailed();`, since it is unnecessary.
### Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
### Does this pull request potentially affect one of the following parts:
This change does not affect any public behavior.
### Documentation
No docs need updating.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] michaeljmarshall commented on pull request #12229: [Java Client] Remove unnecessary stats incremement
Posted by GitBox <gi...@apache.org>.
michaeljmarshall commented on pull request #12229:
URL: https://github.com/apache/pulsar/pull/12229#issuecomment-929637598
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] michaeljmarshall commented on pull request #12229: [Java Client] Remove unnecessary stats incremement
Posted by GitBox <gi...@apache.org>.
michaeljmarshall commented on pull request #12229:
URL: https://github.com/apache/pulsar/pull/12229#issuecomment-929677152
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] michaeljmarshall commented on pull request #12229: [Java Client] Remove unnecessary stats incremement
Posted by GitBox <gi...@apache.org>.
michaeljmarshall commented on pull request #12229:
URL: https://github.com/apache/pulsar/pull/12229#issuecomment-930356131
@merlimat @BewareMyPower - PTAL, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] michaeljmarshall commented on pull request #12229: [Java Client] Remove unnecessary stats incremement
Posted by GitBox <gi...@apache.org>.
michaeljmarshall commented on pull request #12229:
URL: https://github.com/apache/pulsar/pull/12229#issuecomment-929637598
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] merlimat merged pull request #12229: [Java Client] Remove unnecessary stats incremement
Posted by GitBox <gi...@apache.org>.
merlimat merged pull request #12229:
URL: https://github.com/apache/pulsar/pull/12229
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org