[jira] [Commented] (PARQUET-1939) Fix RemoteKmsClient API ambiguity

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/PARQUET-1939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17225466#comment-17225466 ] 

ASF GitHub Bot commented on PARQUET-1939:
-----------------------------------------

ggershinsky opened a new pull request #841:
URL: https://github.com/apache/parquet-mr/pull/841


   1. rename this class to LocalWrapKmsClient; it will be used only in rare situations where in-server wrapping in not supported. In all other situations, the basic KmsClient interface will be used directly.
   
   2. this also means the "wrap.locally" property is not needed anymore, making the API slighly simpler.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Fix RemoteKmsClient API ambiguity
> ---------------------------------
>
>                 Key: PARQUET-1939
>                 URL: https://issues.apache.org/jira/browse/PARQUET-1939
>             Project: Parquet
>          Issue Type: Improvement
>            Reporter: Gidon Gershinsky
>            Assignee: Gidon Gershinsky
>            Priority: Major
>
> Users complain that RemoteKmsClient name can be confusing, since this class covers both local and in-server (remote) key wrapping. Still, this class supports only remote KMS servers. But to remove any ambiguity, and to make the API simpler, we will rename this class to LocalWrapKmsClient; it will be used only in rare situations where in-server wrapping in not supported. In all other situations, the basic KmsClient interface will be used directly.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)