You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by "ASF subversion and git services (Jira)" <ji...@apache.org> on 2019/12/18 03:54:00 UTC

[jira] [Commented] (AIRFLOW-5072) gcs_hook causes out-of-memory error when downloading huge files

    [ https://issues.apache.org/jira/browse/AIRFLOW-5072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16998788#comment-16998788 ] 

ASF subversion and git services commented on AIRFLOW-5072:
----------------------------------------------------------

Commit e0850fed6690f935b2749560a600b9b21ec9ebca in airflow's branch refs/heads/v1-10-test from Tobias Kaymak
[ https://gitbox.apache.org/repos/asf?p=airflow.git;h=e0850fe ]

[AIRFLOW-5072] gcs_hook should download once (#5685)

(cherry-picked from 4ab6982f0b1d42f20c7d6d62734636445f7e0104)


> gcs_hook causes out-of-memory error when downloading huge files
> ---------------------------------------------------------------
>
>                 Key: AIRFLOW-5072
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-5072
>             Project: Apache Airflow
>          Issue Type: Bug
>          Components: gcp
>    Affects Versions: 1.10.3
>            Reporter: Tobias Kaymak
>            Assignee: Tobias Kaymak
>            Priority: Major
>             Fix For: 1.10.7
>
>
> Possibly there is an "else" missing here, but the gcs_hook's `download` method *always* downloads a blob as a string even when a filename was supplied. This causes the method to take twice as long when a filename is supplied and for huge blobs it can even cause out-of-memory errors.
> I think that there is an else missing?
> [https://github.com/apache/airflow/blob/05c01a97497e992c7d8b05a39a7855343dee1603/airflow/contrib/hooks/gcs_hook.py#L176]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)