[jira] [Commented] (BOOKKEEPER-475) BookieRecoveryTest#testSyncBookieRecoveryToRandomBookiesCheckForDupes() iterates too much

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/BOOKKEEPER-475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13504514#comment-13504514 ] 

Hadoop QA commented on BOOKKEEPER-475:
--------------------------------------

Testing JIRA BOOKKEEPER-475

WARNING: Running test-patch on a dirty local svn workspace

Patch <a href="/jira/secure/attachment/12554496/0001-Reduce-amount-of-iteratons-for-testSyncBookieRecover.patch">/jira/secure/attachment/12554496/0001-Reduce-amount-of-iteratons-for-testSyncBookieRecover.patch</a> downloaded at Tue Nov 27 10:20:32 UTC 2012

----------------------------

{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:green}+1 RAW_PATCH_ANALYSIS{color}
.    {color:green}+1{color} the patch does not introduce any @author tags
.    {color:green}+1{color} the patch does not introduce any tabs
.    {color:green}+1{color} the patch does not introduce any trailing spaces
.    {color:green}+1{color} the patch does not introduce any line longer than 120
.    {color:green}+1{color} the patch does adds/modifies 1 testcase(s)
{color:green}+1 RAT{color}
.    {color:green}+1{color} the patch does not seem to introduce new RAT warnings
{color:green}+1 JAVADOC{color}
.    {color:green}+1{color} the patch does not seem to introduce new Javadoc warnings
.    {color:red}WARNING{color}: the current HEAD has 8 Javadoc warning(s)
{color:green}+1 COMPILE{color}
.    {color:green}+1{color} HEAD compiles
.    {color:green}+1{color} patch compiles
.    {color:green}+1{color} the patch does not seem to introduce new javac warnings
.    {color:red}WARNING{color}: the current HEAD has 9 javac warning(s)
{color:green}+1 FINDBUGS{color}
.    {color:green}+1{color} the patch does not seem to introduce new Findbugs warnings
.    {color:red}WARNING: the current HEAD has  Findbugs warning(s), they should be addressed ASAP{color}
{color:green}+1 TESTS{color}
.    Tests run: 389
{color:green}+1 DISTRO{color}
.    {color:green}+1{color} distro tarball builds with the patch 

----------------------------
{color:green}*+1 Overall result, good!, no -1s*{color}

{color:red}.   There is at least one warning, please check{color}

The full output of the test-patch run is available at

.   https://builds.apache.org/job/bookkeeper-trunk-precommit-build/21/
                
> BookieRecoveryTest#testSyncBookieRecoveryToRandomBookiesCheckForDupes() iterates too much
> -----------------------------------------------------------------------------------------
>
>                 Key: BOOKKEEPER-475
>                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-475
>             Project: Bookkeeper
>          Issue Type: Bug
>            Reporter: Ivan Kelly
>            Assignee: Ivan Kelly
>             Fix For: 4.2.0
>
>         Attachments: 0001-Reduce-amount-of-iteratons-for-testSyncBookieRecover.patch
>
>
> This test exists to detect the case where a bookie is taken down, and the same another bookie is selected to replace it, but the other bookie is already in the ensemble. BOOKKEEPER-106 fixed this, so it shouldn't happen. However we still need to check. We iterate 10 times, but this is a parametered test, so effectively we iterate 40 times. There's 3 possible bookies to select, two of which are already in the ensemble, so a single iteration, if selecting randomly has a 66% chance of selecting a bad bookie. We have to run four times anyhow because it's a parameterized test, giving us a 66*4 % chance of hitting the bug if we only have one iteration. 
> Therefore, we should only iterate once. Also, we don't need to write much data. We only care about whats in zk for this test really.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira