You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Steve Carlin (Code Review)" <ge...@cloudera.org> on 2025/07/05 17:03:02 UTC
[Impala-ASF-CR] IMPALA-14166: Calcite Planner: Ensure 'unsupported' functions are handled correctly
Hello Aman Sinha, Fang-Yu Rao, Riza Suminto, Joe McDonnell, Michael Smith, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/23041
to look at the new patch set (#3).
Change subject: IMPALA-14166: Calcite Planner: Ensure 'unsupported' functions are handled correctly
......................................................................
IMPALA-14166: Calcite Planner: Ensure 'unsupported' functions are handled correctly
There are some datasketches functions which return a Function
object where the "isUnsupported" method returns true.
This needs to be explicitly handled in the Calcite code as unsupported.
Change-Id: Ic2c4a96005fc7571bde28643ea4cecda61839c77
---
M java/calcite-planner/src/main/java/org/apache/impala/calcite/functions/FunctionResolver.java
M testdata/workloads/functional-query/queries/QueryTest/calcite.test
2 files changed, 13 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/41/23041/3
--
To view, visit http://gerrit.cloudera.org:8080/23041
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ic2c4a96005fc7571bde28643ea4cecda61839c77
Gerrit-Change-Number: 23041
Gerrit-PatchSet: 3
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Steve Carlin <sc...@cloudera.com>