You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@tomee.apache.org by Jonathan Gallimore <jo...@gmail.com> on 2022/02/08 14:31:18 UTC

Version placeholder on the website

Hi All,

I've created a PR for the site generator project:
https://github.com/apache/tomee-site-generator/pull/32.

The idea here is to allow ${tomee.version} to be specified in the
documentation or example files, and it to be swapped for the specific
version string (which can be specified in the Configuration class). The
rationale here for pages to show an up-to-date version, rather than
referencing really old versions.

If folks are ok with this. I'll merge it in, and start working through the
relevant files to add in the ${tomee.version} placeholder in the right
places.

Thanks

Jon

Re: Version placeholder on the website

Posted by Jonathan Gallimore <jo...@gmail.com>.

Thanks for the feedback and +1s. I was just thinking that there may be some
legitimate uses of ${tomee.version} that we don't want to replace - e.g.
where we're showing a pom.xml file, and tomee.version is actually defined
as a property. I'm thinking I'll simply switch this to ${TOMEE_VERSION},
merge this in, and set about updating some of the documentation to
reference it.

Let me know if you have any objections to that.

Thanks

Jon

On Tue, Feb 8, 2022 at 2:31 PM Jonathan Gallimore <
jonathan.gallimore@gmail.com> wrote:

> Hi All,
>
> I've created a PR for the site generator project:
> https://github.com/apache/tomee-site-generator/pull/32.
>
> The idea here is to allow ${tomee.version} to be specified in the
> documentation or example files, and it to be swapped for the specific
> version string (which can be specified in the Configuration class). The
> rationale here for pages to show an up-to-date version, rather than
> referencing really old versions.
>
> If folks are ok with this. I'll merge it in, and start working through the
> relevant files to add in the ${tomee.version} placeholder in the right
> places.
>
> Thanks
>
> Jon
>

Re: Version placeholder on the website

Posted by Daniel Dias Dos Santos <da...@gmail.com>.

+1

On Tue, Feb 8, 2022, 11:53 Alex The Rocker <al...@gmail.com> wrote:

> +1 of course :)
>
> Alex
>
> Le mar. 8 févr. 2022 à 15:49, Jean-Louis Monteiro
> <jl...@tomitribe.com> a écrit :
> >
> > +1
> > Thanks
> > --
> > Jean-Louis Monteiro
> > http://twitter.com/jlouismonteiro
> > http://www.tomitribe.com
> >
> >
> > On Tue, Feb 8, 2022 at 3:39 PM Zowalla, Richard <
> > richard.zowalla@hs-heilbronn.de> wrote:
> >
> > > Hi Jon,
> > >
> > > I am fine with it: +1
> > >
> > > Might also be usefull for the documentation, which resides in the main
> > > repository.
> > >
> > > Gruß
> > > Richard
> > >
> > > Am Dienstag, dem 08.02.2022 um 14:31 +0000 schrieb Jonathan Gallimore:
> > > > Hi All,
> > > >
> > > > I've created a PR for the site generator project:
> > > > https://github.com/apache/tomee-site-generator/pull/32.
> > > >
> > > > The idea here is to allow ${tomee.version} to be specified in the
> > > > documentation or example files, and it to be swapped for the specific
> > > > version string (which can be specified in the Configuration class).
> > > > The
> > > > rationale here for pages to show an up-to-date version, rather than
> > > > referencing really old versions.
> > > >
> > > > If folks are ok with this. I'll merge it in, and start working
> > > > through the
> > > > relevant files to add in the ${tomee.version} placeholder in the
> > > > right
> > > > places.
> > > >
> > > > Thanks
> > > >
> > > > Jon
> > >
>

Re: Version placeholder on the website

Posted by Alex The Rocker <al...@gmail.com>.

+1 of course :)

Alex

Le mar. 8 févr. 2022 à 15:49, Jean-Louis Monteiro
<jl...@tomitribe.com> a écrit :
>
> +1
> Thanks
> --
> Jean-Louis Monteiro
> http://twitter.com/jlouismonteiro
> http://www.tomitribe.com
>
>
> On Tue, Feb 8, 2022 at 3:39 PM Zowalla, Richard <
> richard.zowalla@hs-heilbronn.de> wrote:
>
> > Hi Jon,
> >
> > I am fine with it: +1
> >
> > Might also be usefull for the documentation, which resides in the main
> > repository.
> >
> > Gruß
> > Richard
> >
> > Am Dienstag, dem 08.02.2022 um 14:31 +0000 schrieb Jonathan Gallimore:
> > > Hi All,
> > >
> > > I've created a PR for the site generator project:
> > > https://github.com/apache/tomee-site-generator/pull/32.
> > >
> > > The idea here is to allow ${tomee.version} to be specified in the
> > > documentation or example files, and it to be swapped for the specific
> > > version string (which can be specified in the Configuration class).
> > > The
> > > rationale here for pages to show an up-to-date version, rather than
> > > referencing really old versions.
> > >
> > > If folks are ok with this. I'll merge it in, and start working
> > > through the
> > > relevant files to add in the ${tomee.version} placeholder in the
> > > right
> > > places.
> > >
> > > Thanks
> > >
> > > Jon
> >

Re: Version placeholder on the website

Posted by Jean-Louis Monteiro <jl...@tomitribe.com>.

+1
Thanks
--
Jean-Louis Monteiro
http://twitter.com/jlouismonteiro
http://www.tomitribe.com


On Tue, Feb 8, 2022 at 3:39 PM Zowalla, Richard <
richard.zowalla@hs-heilbronn.de> wrote:

> Hi Jon,
>
> I am fine with it: +1
>
> Might also be usefull for the documentation, which resides in the main
> repository.
>
> Gruß
> Richard
>
> Am Dienstag, dem 08.02.2022 um 14:31 +0000 schrieb Jonathan Gallimore:
> > Hi All,
> >
> > I've created a PR for the site generator project:
> > https://github.com/apache/tomee-site-generator/pull/32.
> >
> > The idea here is to allow ${tomee.version} to be specified in the
> > documentation or example files, and it to be swapped for the specific
> > version string (which can be specified in the Configuration class).
> > The
> > rationale here for pages to show an up-to-date version, rather than
> > referencing really old versions.
> >
> > If folks are ok with this. I'll merge it in, and start working
> > through the
> > relevant files to add in the ${tomee.version} placeholder in the
> > right
> > places.
> >
> > Thanks
> >
> > Jon
>

Re: Version placeholder on the website

Posted by "Zowalla, Richard" <ri...@hs-heilbronn.de>.

Hi Jon,

I am fine with it: +1

Might also be usefull for the documentation, which resides in the main
repository.

Gruß
Richard

Am Dienstag, dem 08.02.2022 um 14:31 +0000 schrieb Jonathan Gallimore:
> Hi All,
> 
> I've created a PR for the site generator project:
> https://github.com/apache/tomee-site-generator/pull/32.
> 
> The idea here is to allow ${tomee.version} to be specified in the
> documentation or example files, and it to be swapped for the specific
> version string (which can be specified in the Configuration class).
> The
> rationale here for pages to show an up-to-date version, rather than
> referencing really old versions.
> 
> If folks are ok with this. I'll merge it in, and start working
> through the
> relevant files to add in the ${tomee.version} placeholder in the
> right
> places.
> 
> Thanks
> 
> Jon