You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@systemml.apache.org by "JC (JIRA)" <ji...@apache.org> on 2017/03/31 20:03:41 UTC

[jira] [Created] (SYSTEMML-1449) Potential bug in compare method

JC created SYSTEMML-1449:
----------------------------

             Summary: Potential bug in compare method
                 Key: SYSTEMML-1449
                 URL: https://issues.apache.org/jira/browse/SYSTEMML-1449
             Project: SystemML
          Issue Type: Bug
            Reporter: JC
            Priority: Minor


Hi

In recent github mirror, I've found the following issue.

Path: src/main/java/org/apache/sysml/hops/QuaternaryOp.java


{code:java}
1566 
1567                 //compare basic inputs and weights (always existing)
1568                 boolean ret = (_op == that2._op
1569                                 && getInput().size() == getInput().size()
1570                                 && getInput().get(0) == that2.getInput().get(0)
1571                                 && getInput().get(1) == that2.getInput().get(1)
1572                                 && getInput().get(2) == that2.getInput().get(2) );
1573 
{code}

 Line 1569 should be like this? Or, removing the line is just OK?
{code}
1569                                 && getInput().size() == that2.getInput().size()
{code}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)