You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@griffin.apache.org by guoyuepeng <gi...@git.apache.org> on 2018/12/13 14:59:53 UTC
[GitHub] griffin pull request #470: update hibernate_mysql_pom.xml
GitHub user guoyuepeng opened a pull request:
https://github.com/apache/griffin/pull/470
update hibernate_mysql_pom.xml
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/guoyuepeng/griffin sync_hibernate_mysql_pom
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/griffin/pull/470.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #470
----
commit 0b408ae2f1fcee2b4477d5d2db82183d45b19d6c
Author: William Guo <gu...@...>
Date: 2018-12-13T14:47:28Z
update hibernate_mysql_pom.xml
----
---
[GitHub] griffin pull request #470: update hibernate_mysql_pom.xml
Posted by guoyuepeng <gi...@git.apache.org>.
Github user guoyuepeng closed the pull request at:
https://github.com/apache/griffin/pull/470
---
[GitHub] griffin issue #470: update hibernate_mysql_pom.xml
Posted by ahutsunshine <gi...@git.apache.org>.
Github user ahutsunshine commented on the issue:
https://github.com/apache/griffin/pull/470
> @ahutsunshine
> could you verify and provide relate application-mysql.properties ?
ok， I‘ll verify it.
---
[GitHub] griffin issue #470: update hibernate_mysql_pom.xml
Posted by guoyuepeng <gi...@git.apache.org>.
Github user guoyuepeng commented on the issue:
https://github.com/apache/griffin/pull/470
> @guoyuepeng
> If we keep and update hibernate_mysql_pom.xml, we'd better make it similar to pom.xml. So we need to **update**
>
> ```
> <dependency>
> <groupId>org.springframework.boot</groupId>
> <artifactId>spring-boot-starter-web</artifactId>
> </dependency>
> ```
> **to**
>
> ```
> <dependency>
> <groupId>org.springframework.boot</groupId>
> <artifactId>spring-boot-starter-web</artifactId>
> <exclusions>
> <exclusion>
> <groupId>org.springframework.boot</groupId>
> <artifactId>spring-boot-starter-logging</artifactId>
> </exclusion>
> </exclusions>
> </dependency>
> ```
> and **update**
>
> ```
> <dependency>
> <groupId>org.apache.hive</groupId>
> <artifactId>hive-metastore</artifactId>
> <version>${hive.version}</version>
> </dependency>
> ```
> **to**
>
> ```
> <dependency>
> <groupId>org.apache.hive</groupId>
> <artifactId>hive-metastore</artifactId>
> <version>${hive.version}</version>
> <exclusions>
> <exclusion>
> <groupId>org.eclipse.jetty.aggregate</groupId>
> <artifactId>jetty-all</artifactId>
> </exclusion>
> <exclusion>
> <groupId>org.eclipse.jetty.orbit</groupId>
> <artifactId>javax.servlet</artifactId>
> </exclusion>
> <exclusion>
> <groupId>javax.servlet</groupId>
> <artifactId>servlet-api</artifactId>
> </exclusion>
> <exclusion>
> <groupId>de.ruedigermoeller</groupId>
> <artifactId>fst</artifactId>
> </exclusion>
> </exclusions>
> </dependency>
> ```.
> The first update is to prevent dependency conflicts and the second update is to remove some dependencies and prevent `Caused by: java.lang.NoSuchMethodError: org.eclipse.jetty.servlet.ServletMapping.setDefault` when using Griffin for the first time.
> ```
thanks, let me check whether we can leverage profile in apache community
---
[GitHub] griffin issue #470: update hibernate_mysql_pom.xml
Posted by guoyuepeng <gi...@git.apache.org>.
Github user guoyuepeng commented on the issue:
https://github.com/apache/griffin/pull/470
> Should we rather retire separate pom file and use maven profiles for that?
yeap, here a litter bit tricky is that hibernate and mysql's license, we cannot explicitly or implicitly say our preference for hibernate and mysql in apache.
---
[GitHub] griffin issue #470: update hibernate_mysql_pom.xml
Posted by guoyuepeng <gi...@git.apache.org>.
Github user guoyuepeng commented on the issue:
https://github.com/apache/griffin/pull/470
1. need to add two profile properties
2. limit EclipseLinkJpaConfig under profile eclipselink
---
[GitHub] griffin issue #470: update hibernate_mysql_pom.xml
Posted by guoyuepeng <gi...@git.apache.org>.
Github user guoyuepeng commented on the issue:
https://github.com/apache/griffin/pull/470
@ahutsunshine
could you verify and provide relate application-mysql.properties ?
---
[GitHub] griffin issue #470: update hibernate_mysql_pom.xml
Posted by ahutsunshine <gi...@git.apache.org>.
Github user ahutsunshine commented on the issue:
https://github.com/apache/griffin/pull/470
@guoyuepeng
If we keep and update hibernate_mysql_pom.xml, we'd better make it similar to pom.xml. So we need to **update**
```
<dependency>
<groupId>org.springframework.boot</groupId>
<artifactId>spring-boot-starter-web</artifactId>
</dependency>
```
**to**
```
<dependency>
<groupId>org.springframework.boot</groupId>
<artifactId>spring-boot-starter-web</artifactId>
<exclusions>
<exclusion>
<groupId>org.springframework.boot</groupId>
<artifactId>spring-boot-starter-logging</artifactId>
</exclusion>
</exclusions>
</dependency>
```
and **update**
```
<dependency>
<groupId>org.apache.hive</groupId>
<artifactId>hive-metastore</artifactId>
<version>${hive.version}</version>
</dependency>
```
**to**
```
<dependency>
<groupId>org.apache.hive</groupId>
<artifactId>hive-metastore</artifactId>
<version>${hive.version}</version>
<exclusions>
<exclusion>
<groupId>org.eclipse.jetty.aggregate</groupId>
<artifactId>jetty-all</artifactId>
</exclusion>
<exclusion>
<groupId>org.eclipse.jetty.orbit</groupId>
<artifactId>javax.servlet</artifactId>
</exclusion>
<exclusion>
<groupId>javax.servlet</groupId>
<artifactId>servlet-api</artifactId>
</exclusion>
<exclusion>
<groupId>de.ruedigermoeller</groupId>
<artifactId>fst</artifactId>
</exclusion>
</exclusions>
</dependency>
```.
The first update is to prevent dependency conflicts and the second update is to remove some dependencies and prevent `Caused by: java.lang.NoSuchMethodError: org.eclipse.jetty.servlet.ServletMapping.setDefault` when using Griffin for the first time.
---
[GitHub] griffin issue #470: update hibernate_mysql_pom.xml
Posted by guoyuepeng <gi...@git.apache.org>.
Github user guoyuepeng commented on the issue:
https://github.com/apache/griffin/pull/470
checked with apache, we better use eclipselink as jpa provider, we cannot use hibernate.
---
[GitHub] griffin issue #470: update hibernate_mysql_pom.xml
Posted by ahutsunshine <gi...@git.apache.org>.
Github user ahutsunshine commented on the issue:
https://github.com/apache/griffin/pull/470
@guoyuepeng
LGTM
---
[GitHub] griffin issue #470: update hibernate_mysql_pom.xml
Posted by ahutsunshine <gi...@git.apache.org>.
Github user ahutsunshine commented on the issue:
https://github.com/apache/griffin/pull/470
BTW, currently Griffin does not support mysql 8.0 or above versions. If we support it, we still need update mysql dependency.
e.g.
```
<dependency>
<groupId>mysql</groupId>
<artifactId>mysql-connector-java</artifactId>
<version>8.0.13</version>
</dependency>
```
---
[GitHub] griffin issue #470: update hibernate_mysql_pom.xml
Posted by chemikadze <gi...@git.apache.org>.
Github user chemikadze commented on the issue:
https://github.com/apache/griffin/pull/470
Should we rather retire separate pom file and use maven profiles for that?
---