You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/02/11 16:54:06 UTC

[GitHub] nandorKollar commented on a change in pull request #23721: [SPARK-26797][SQL][WIP][test-maven] Start using the new logical types API of Parquet 1.11.0 instead of the deprecated one

nandorKollar commented on a change in pull request #23721: [SPARK-26797][SQL][WIP][test-maven] Start using the new logical types API of Parquet 1.11.0 instead of the deprecated one
URL: https://github.com/apache/spark/pull/23721#discussion_r255597171
 
 

 ##########
 File path: dev/deps/spark-deps-hadoop-2.7
 ##########
 @@ -17,6 +17,7 @@ arpack_combined_all-0.1.jar
 arrow-format-0.12.0.jar
 arrow-memory-0.12.0.jar
 arrow-vector-0.12.0.jar
+audience-annotations-0.7.0.jar
 
 Review comment:
   @dongjoon-hyun it is a new dependency for Parquet to annotate which API is public and what is private. I don't think that we can exclude it from Parquet, since it is used there. The annotations are Yetus audience annotations with runtime retention policy (I think class retention policy would be more adequate), therefore I'm afraid the had to be present at runtime.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org