You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/02/15 16:04:40 UTC
[GitHub] [superset] dpgaspar opened a new pull request #13135: feat(reports): send notification on error with grace
dpgaspar opened a new pull request #13135:
URL: https://github.com/apache/superset/pull/13135
### SUMMARY
Sends a notification to all recipients when an Alert or Report errors. Also implements grace period on these error notifications.
### ADDITIONAL INFORMATION
- [ ] Has associated issue:
- [ ] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #13135: feat(reports): send notification on error with grace
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #13135:
URL: https://github.com/apache/superset/pull/13135#issuecomment-779343682
# [Codecov](https://codecov.io/gh/apache/superset/pull/13135?src=pr&el=h1) Report
> Merging [#13135](https://codecov.io/gh/apache/superset/pull/13135?src=pr&el=desc) (f627483) into [master](https://codecov.io/gh/apache/superset/commit/29d6420ecc2187db951f08dd47289277a11f4db5?el=desc) (29d6420) will **increase** coverage by `2.77%`.
> The diff coverage is `92.06%`.
[](https://codecov.io/gh/apache/superset/pull/13135?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13135 +/- ##
==========================================
+ Coverage 77.20% 79.97% +2.77%
==========================================
Files 872 300 -572
Lines 45101 24420 -20681
Branches 5435 0 -5435
==========================================
- Hits 34820 19530 -15290
+ Misses 10158 4890 -5268
+ Partials 123 0 -123
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `79.97% <92.06%> (-0.87%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13135?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/reports/commands/log\_prune.py](https://codecov.io/gh/apache/superset/pull/13135/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9jb21tYW5kcy9sb2dfcHJ1bmUucHk=) | `0.00% <ø> (ø)` | |
| [superset/reports/notifications/slack.py](https://codecov.io/gh/apache/superset/pull/13135/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9ub3RpZmljYXRpb25zL3NsYWNrLnB5) | `83.72% <71.42%> (-5.47%)` | :arrow_down: |
| [superset/reports/notifications/email.py](https://codecov.io/gh/apache/superset/pull/13135/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9ub3RpZmljYXRpb25zL2VtYWlsLnB5) | `97.87% <93.33%> (-2.13%)` | :arrow_down: |
| [superset/reports/commands/execute.py](https://codecov.io/gh/apache/superset/pull/13135/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9jb21tYW5kcy9leGVjdXRlLnB5) | `93.22% <100.00%> (+0.67%)` | :arrow_up: |
| [superset/reports/dao.py](https://codecov.io/gh/apache/superset/pull/13135/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9kYW8ucHk=) | `80.17% <100.00%> (+1.66%)` | :arrow_up: |
| [superset/reports/notifications/base.py](https://codecov.io/gh/apache/superset/pull/13135/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9ub3RpZmljYXRpb25zL2Jhc2UucHk=) | `95.65% <100.00%> (+0.19%)` | :arrow_up: |
| [superset/utils/core.py](https://codecov.io/gh/apache/superset/pull/13135/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY29yZS5weQ==) | `88.45% <100.00%> (ø)` | |
| [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/superset/pull/13135/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [superset/views/database/views.py](https://codecov.io/gh/apache/superset/pull/13135/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2Uvdmlld3MucHk=) | `62.69% <0.00%> (-24.88%)` | :arrow_down: |
| [superset/databases/commands/create.py](https://codecov.io/gh/apache/superset/pull/13135/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `83.67% <0.00%> (-8.17%)` | :arrow_down: |
| ... and [590 more](https://codecov.io/gh/apache/superset/pull/13135/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13135?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13135?src=pr&el=footer). Last update [29d6420...f627483](https://codecov.io/gh/apache/superset/pull/13135?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] willbarrett merged pull request #13135: feat(reports): send notification on error with grace
Posted by GitBox <gi...@apache.org>.
willbarrett merged pull request #13135:
URL: https://github.com/apache/superset/pull/13135
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #13135: feat(reports): send notification on error with grace
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #13135:
URL: https://github.com/apache/superset/pull/13135#issuecomment-779343682
# [Codecov](https://codecov.io/gh/apache/superset/pull/13135?src=pr&el=h1) Report
> Merging [#13135](https://codecov.io/gh/apache/superset/pull/13135?src=pr&el=desc) (f627483) into [master](https://codecov.io/gh/apache/superset/commit/29d6420ecc2187db951f08dd47289277a11f4db5?el=desc) (29d6420) will **increase** coverage by `2.75%`.
> The diff coverage is `92.06%`.
[](https://codecov.io/gh/apache/superset/pull/13135?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13135 +/- ##
==========================================
+ Coverage 77.20% 79.95% +2.75%
==========================================
Files 872 300 -572
Lines 45101 24392 -20709
Branches 5435 0 -5435
==========================================
- Hits 34820 19503 -15317
+ Misses 10158 4889 -5269
+ Partials 123 0 -123
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `79.95% <92.06%> (-0.89%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13135?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/reports/commands/log\_prune.py](https://codecov.io/gh/apache/superset/pull/13135/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9jb21tYW5kcy9sb2dfcHJ1bmUucHk=) | `0.00% <ø> (ø)` | |
| [superset/reports/notifications/slack.py](https://codecov.io/gh/apache/superset/pull/13135/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9ub3RpZmljYXRpb25zL3NsYWNrLnB5) | `83.72% <71.42%> (-5.47%)` | :arrow_down: |
| [superset/reports/notifications/email.py](https://codecov.io/gh/apache/superset/pull/13135/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9ub3RpZmljYXRpb25zL2VtYWlsLnB5) | `97.82% <93.33%> (-2.18%)` | :arrow_down: |
| [superset/reports/commands/execute.py](https://codecov.io/gh/apache/superset/pull/13135/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9jb21tYW5kcy9leGVjdXRlLnB5) | `93.22% <100.00%> (+0.67%)` | :arrow_up: |
| [superset/reports/dao.py](https://codecov.io/gh/apache/superset/pull/13135/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9kYW8ucHk=) | `80.17% <100.00%> (+1.66%)` | :arrow_up: |
| [superset/reports/notifications/base.py](https://codecov.io/gh/apache/superset/pull/13135/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9ub3RpZmljYXRpb25zL2Jhc2UucHk=) | `95.23% <100.00%> (-0.22%)` | :arrow_down: |
| [superset/utils/core.py](https://codecov.io/gh/apache/superset/pull/13135/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY29yZS5weQ==) | `88.45% <100.00%> (ø)` | |
| [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/superset/pull/13135/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [superset/views/database/views.py](https://codecov.io/gh/apache/superset/pull/13135/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2Uvdmlld3MucHk=) | `62.69% <0.00%> (-24.88%)` | :arrow_down: |
| [superset/databases/commands/create.py](https://codecov.io/gh/apache/superset/pull/13135/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `83.67% <0.00%> (-8.17%)` | :arrow_down: |
| ... and [596 more](https://codecov.io/gh/apache/superset/pull/13135/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13135?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13135?src=pr&el=footer). Last update [29d6420...f627483](https://codecov.io/gh/apache/superset/pull/13135?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io commented on pull request #13135: feat(reports): send notification on error with grace
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #13135:
URL: https://github.com/apache/superset/pull/13135#issuecomment-779343682
# [Codecov](https://codecov.io/gh/apache/superset/pull/13135?src=pr&el=h1) Report
> Merging [#13135](https://codecov.io/gh/apache/superset/pull/13135?src=pr&el=desc) (4a92071) into [master](https://codecov.io/gh/apache/superset/commit/2ce79823dfad61bce6196fcacd56a844f44818c0?el=desc) (2ce7982) will **decrease** coverage by `8.37%`.
> The diff coverage is `51.56%`.
[](https://codecov.io/gh/apache/superset/pull/13135?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13135 +/- ##
==========================================
- Coverage 53.06% 44.68% -8.38%
==========================================
Files 489 494 +5
Lines 17314 17385 +71
Branches 4482 4516 +34
==========================================
- Hits 9187 7768 -1419
- Misses 8127 9617 +1490
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `44.68% <51.56%> (-8.38%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13135?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...end/src/SqlLab/components/RunQueryActionButton.tsx](https://codecov.io/gh/apache/superset/pull/13135/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1J1blF1ZXJ5QWN0aW9uQnV0dG9uLnRzeA==) | `52.77% <ø> (ø)` | |
| [superset-frontend/src/chart/ChartContainer.jsx](https://codecov.io/gh/apache/superset/pull/13135/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0Q29udGFpbmVyLmpzeA==) | `100.00% <ø> (ø)` | |
| [superset-frontend/src/chart/ChartRenderer.jsx](https://codecov.io/gh/apache/superset/pull/13135/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0UmVuZGVyZXIuanN4) | `75.67% <0.00%> (-1.04%)` | :arrow_down: |
| [...perset-frontend/src/common/components/Dropdown.tsx](https://codecov.io/gh/apache/superset/pull/13135/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL0Ryb3Bkb3duLnRzeA==) | `50.00% <ø> (ø)` | |
| [...rontend/src/components/ListView/CardSortSelect.tsx](https://codecov.io/gh/apache/superset/pull/13135/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTGlzdFZpZXcvQ2FyZFNvcnRTZWxlY3QudHN4) | `78.94% <ø> (ø)` | |
| [...ontend/src/components/ListViewCard/ImageLoader.tsx](https://codecov.io/gh/apache/superset/pull/13135/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTGlzdFZpZXdDYXJkL0ltYWdlTG9hZGVyLnRzeA==) | `75.00% <0.00%> (ø)` | |
| [...set-frontend/src/components/URLShortLinkButton.jsx](https://codecov.io/gh/apache/superset/pull/13135/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvVVJMU2hvcnRMaW5rQnV0dG9uLmpzeA==) | `72.22% <ø> (-27.78%)` | :arrow_down: |
| [...rset-frontend/src/components/URLShortLinkModal.tsx](https://codecov.io/gh/apache/superset/pull/13135/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvVVJMU2hvcnRMaW5rTW9kYWwudHN4) | `77.77% <ø> (ø)` | |
| [...src/dashboard/components/HeaderActionsDropdown.jsx](https://codecov.io/gh/apache/superset/pull/13135/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0hlYWRlckFjdGlvbnNEcm9wZG93bi5qc3g=) | `61.64% <ø> (-5.93%)` | :arrow_down: |
| [...end/src/dashboard/components/StickyVerticalBar.tsx](https://codecov.io/gh/apache/superset/pull/13135/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1N0aWNreVZlcnRpY2FsQmFyLnRzeA==) | `100.00% <ø> (ø)` | |
| ... and [163 more](https://codecov.io/gh/apache/superset/pull/13135/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13135?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13135?src=pr&el=footer). Last update [2dbe92b...4a92071](https://codecov.io/gh/apache/superset/pull/13135?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #13135: feat(reports): send notification on error with grace
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #13135:
URL: https://github.com/apache/superset/pull/13135#issuecomment-779343682
# [Codecov](https://codecov.io/gh/apache/superset/pull/13135?src=pr&el=h1) Report
> Merging [#13135](https://codecov.io/gh/apache/superset/pull/13135?src=pr&el=desc) (730fa89) into [master](https://codecov.io/gh/apache/superset/commit/2ce79823dfad61bce6196fcacd56a844f44818c0?el=desc) (2ce7982) will **increase** coverage by `13.70%`.
> The diff coverage is `48.02%`.
[](https://codecov.io/gh/apache/superset/pull/13135?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13135 +/- ##
===========================================
+ Coverage 53.06% 66.76% +13.70%
===========================================
Files 489 492 +3
Lines 17314 29022 +11708
Branches 4482 0 -4482
===========================================
+ Hits 9187 19377 +10190
- Misses 8127 9645 +1518
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| python | `66.76% <48.02%> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13135?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/examples/birth\_names.py](https://codecov.io/gh/apache/superset/pull/13135/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `73.19% <ø> (ø)` | |
| [...43f2fdb\_add\_granularity\_to\_charts\_where\_missing.py](https://codecov.io/gh/apache/superset/pull/13135/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy8wNzBjMDQzZjJmZGJfYWRkX2dyYW51bGFyaXR5X3RvX2NoYXJ0c193aGVyZV9taXNzaW5nLnB5) | `0.00% <0.00%> (ø)` | |
| [...s/260bf0649a77\_migrate\_x\_dateunit\_in\_time\_range.py](https://codecov.io/gh/apache/superset/pull/13135/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy8yNjBiZjA2NDlhNzdfbWlncmF0ZV94X2RhdGV1bml0X2luX3RpbWVfcmFuZ2UucHk=) | `0.00% <0.00%> (ø)` | |
| [...ons/versions/41ce8799acc3\_rename\_pie\_label\_type.py](https://codecov.io/gh/apache/superset/pull/13135/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy80MWNlODc5OWFjYzNfcmVuYW1lX3BpZV9sYWJlbF90eXBlLnB5) | `0.00% <0.00%> (ø)` | |
| [superset/reports/commands/log\_prune.py](https://codecov.io/gh/apache/superset/pull/13135/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9jb21tYW5kcy9sb2dfcHJ1bmUucHk=) | `0.00% <ø> (ø)` | |
| [superset/connectors/sqla/views.py](https://codecov.io/gh/apache/superset/pull/13135/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL3ZpZXdzLnB5) | `62.43% <4.34%> (ø)` | |
| [superset/views/datasource.py](https://codecov.io/gh/apache/superset/pull/13135/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YXNvdXJjZS5weQ==) | `88.70% <16.66%> (ø)` | |
| [superset/viz.py](https://codecov.io/gh/apache/superset/pull/13135/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `58.82% <20.00%> (ø)` | |
| [superset/reports/notifications/slack.py](https://codecov.io/gh/apache/superset/pull/13135/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9ub3RpZmljYXRpb25zL3NsYWNrLnB5) | `83.72% <66.66%> (ø)` | |
| [superset/charts/commands/exceptions.py](https://codecov.io/gh/apache/superset/pull/13135/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2NvbW1hbmRzL2V4Y2VwdGlvbnMucHk=) | `92.85% <77.77%> (ø)` | |
| ... and [941 more](https://codecov.io/gh/apache/superset/pull/13135/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13135?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13135?src=pr&el=footer). Last update [2dbe92b...4a92071](https://codecov.io/gh/apache/superset/pull/13135?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] willbarrett commented on pull request #13135: feat(reports): send notification on error with grace
Posted by GitBox <gi...@apache.org>.
willbarrett commented on pull request #13135:
URL: https://github.com/apache/superset/pull/13135#issuecomment-780148504
Code looks reasonabe - would it be possible to add a link back to the alert in Superset to the error notification email? This would allow the user to quickly jump to the right place in the application to resolve the error.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] willbarrett edited a comment on pull request #13135: feat(reports): send notification on error with grace
Posted by GitBox <gi...@apache.org>.
willbarrett edited a comment on pull request #13135:
URL: https://github.com/apache/superset/pull/13135#issuecomment-780148504
Code looks reasonable - would it be possible to add a link back to the alert in Superset to the error notification email? This would allow the user to quickly jump to the right place in the application to resolve the error.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org