[GitHub] [skywalking-infra-e2e] kezhenxu94 commented on a change in pull request #71: update trigger docs

[GitBox <gi...@apache.org>]

kezhenxu94 commented on a change in pull request #71:
URL: https://github.com/apache/skywalking-infra-e2e/pull/71#discussion_r814714789



##########
File path: internal/components/trigger/http.go
##########
@@ -79,7 +79,8 @@ func (h *httpAction) Do() chan error {
 			case <-t.C:
 				err := h.execute()
 
-				// `h.times == h.executedCount` makes sure to only send the first error
+				// `send == false && h.times == h.executedCount` makes sure to only send firstly the error and
+				// ignore errors before.

Review comment:
       ```suggestion
   				// `err == nil`: if no error occurs, everything is OK and send `nil` to the channel to continue.
   				// `h.times == h.executedCount`: reach to the maximum retry count and send the `err`, no matter it's `nil` or not.
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org