You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "JonasJ-ap (via GitHub)" <gi...@apache.org> on 2023/03/18 05:32:39 UTC
[GitHub] [iceberg] JonasJ-ap opened a new issue, #7135: PyIceberg: Current Python CI ignore most unit tests
JonasJ-ap opened a new issue, #7135:
URL: https://github.com/apache/iceberg/issues/7135
### Apache Iceberg version
main (development)
### Query engine
None
### Please describe the bug 🐞
Currently, the two tasks: `Test S3` and `Test Adlfs` in Python CI only runs some tests in `test_fsspec.py`, ignoring most unit tests:
Screenshot of a recent Python CI log:
I also checked the Python CI (integration test) and it only runs tests in `test_integration.py`. So it seems most of the unit tests are ignored now.
I also noticed that there are two unit tests failing in the current master branch when running locally:
```bash
_____________________________________________________________________________________________________________________________________________ test_expr_is_nan_to_pyarrow ______________________________________________________________________________________________________________________________________________
bound_double_reference = BoundReference(field=NestedField(field_id=1, name='foo', field_type=DoubleType(), required=False), accessor=Accessor(position=0,inner=None))
def test_expr_is_nan_to_pyarrow(bound_double_reference: BoundReference[str]) -> None:
> assert (
repr(expression_to_pyarrow(BoundIsNaN(bound_double_reference)))
== "<pyarrow.compute.Expression (is_null(foo, {nan_is_null=true}) and is_valid(foo))>"
)
E AssertionError: assert '<pyarrow.com... is_nan(foo)>' == '<pyarrow.com..._valid(foo))>'
E - <pyarrow.compute.Expression (is_null(foo, {nan_is_null=true}) and is_valid(foo))>
E + <pyarrow.compute.Expression is_nan(foo)>
tests/io/test_pyarrow.py:453: AssertionError
_____________________________________________________________________________________________________________________________________________ test_expr_not_nan_to_pyarrow _____________________________________________________________________________________________________________________________________________
bound_double_reference = BoundReference(field=NestedField(field_id=1, name='foo', field_type=DoubleType(), required=False), accessor=Accessor(position=0,inner=None))
def test_expr_not_nan_to_pyarrow(bound_double_reference: BoundReference[str]) -> None:
> assert (
repr(expression_to_pyarrow(BoundNotNaN(bound_double_reference)))
== "<pyarrow.compute.Expression invert((is_null(foo, {nan_is_null=true}) and is_valid(foo)))>"
)
E AssertionError: assert '<pyarrow.com...is_nan(foo))>' == '<pyarrow.com...valid(foo)))>'
E - <pyarrow.compute.Expression invert((is_null(foo, {nan_is_null=true}) and is_valid(foo)))>
E + <pyarrow.compute.Expression invert(is_nan(foo))>
tests/io/test_pyarrow.py:460: AssertionError
```
Seems related to the changes made in #6398 . But before making any change, I want to post this issue to make sure I did not misunderstood anything.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] jackye1995 closed issue #7135: Python: Current Python CI ignore most of the unit tests
Posted by "jackye1995 (via GitHub)" <gi...@apache.org>.
jackye1995 closed issue #7135: Python: Current Python CI ignore most of the unit tests
URL: https://github.com/apache/iceberg/issues/7135
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org