You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by David McLaughlin <da...@dmclaughlin.com> on 2018/02/06 22:11:49 UTC
Re: Review Request 65537: Use overflow to prevent overlapping config
summary tables
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65537/
-----------------------------------------------------------
(Updated Feb. 6, 2018, 10:11 p.m.)
Review request for Aurora and Jordan Ly.
Summary (updated)
-----------------
Use overflow to prevent overlapping config summary tables
Repository: aurora
Description
-------
Previous approach seemed almost random with the way it used line breaks for words. Caused some weirdness for edge cases. This approach just caps the size of table cells, since only metadata can grow unbounded.
Diffs
-----
ui/src/main/sass/components/_job-page.scss 23fe3c41d859dd1c1bfc45dc24fbc18871f90ce1
Diff: https://reviews.apache.org/r/65537/diff/1/
Testing
-------
Tested in Vagrant (see screenshot).
File Attachments
----------------
scroll bar on long lines
https://reviews.apache.org/media/uploaded/files/2018/02/06/fdce991e-34f4-4c93-b89d-b25b87694e21__Screen_Shot_2018-02-06_at_2.08.56_PM.png
Thanks,
David McLaughlin
Re: Review Request 65537: Use overflow to prevent overlapping config
summary tables
Posted by Jordan Ly <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65537/#review196936
-----------------------------------------------------------
Ship it!
Ship It!
- Jordan Ly
On Feb. 6, 2018, 10:11 p.m., David McLaughlin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65537/
> -----------------------------------------------------------
>
> (Updated Feb. 6, 2018, 10:11 p.m.)
>
>
> Review request for Aurora and Jordan Ly.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Previous approach seemed almost random with the way it used line breaks for words. Caused some weirdness for edge cases. This approach just caps the size of table cells, since only metadata can grow unbounded.
>
>
> Diffs
> -----
>
> ui/src/main/sass/components/_job-page.scss 23fe3c41d859dd1c1bfc45dc24fbc18871f90ce1
>
>
> Diff: https://reviews.apache.org/r/65537/diff/1/
>
>
> Testing
> -------
>
> Tested in Vagrant (see screenshot).
>
>
> File Attachments
> ----------------
>
> scroll bar on long lines
> https://reviews.apache.org/media/uploaded/files/2018/02/06/fdce991e-34f4-4c93-b89d-b25b87694e21__Screen_Shot_2018-02-06_at_2.08.56_PM.png
>
>
> Thanks,
>
> David McLaughlin
>
>
Re: Review Request 65537: Use overflow to prevent overlapping config
summary tables
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65537/#review196938
-----------------------------------------------------------
Master (f6c7d6c) is red with this patch.
./build-support/jenkins/build.sh
WARN] Reached consecutive failure limit.
WARN] Reached consecutive failure limit.
WARN] Reached consecutive failure limit.
WARN] Reached consecutive failure limit.
WARN] Reached consecutive failure limit.
WARN] Reached consecutive failure limit.
WARN] Reached consecutive failure limit.
WARN] Reached consecutive failure limit.
WARN] Reached consecutive failure limit.
WARN] Reached consecutive failure limit.
WARN] Reached consecutive failure limit.
WARN] Reached consecutive failure limit.
WARN] Reached consecutive failure limit.
WARN] Reached consecutive failure limit.
WARN] Reached consecutive failure limit.
WARN] Reached consecutive failure limit.
WARN] Reached consecutive failure limit.
WARN] Reached consecutive failure limit.
WARN] Reached consecutive failure limit.
WARN] Reached consecutive failure limit.
WARN] Reached consecutive failure limit.
WARN] Reached consecutive failure limit.
WARN] Reached consecutive failure limit.
WARN] Reached consecutive failure limit.
WARN] Reached consecutive failure limit.
WARN] Reached consecutive failure limit.
--------------- Captured log call ----------------
health_checker.py 167 INFO INFO] Reached consecutive success limit.
health_checker.py 143 WARNING WARN] Health check failure: failure-2
health_checker.py 184 WARNING WARN] Ignoring failure of attempt: 2
health_checker.py 143 WARNING WARN] Health check failure: failure-3
health_checker.py 159 WARNING WARN] Reached consecutive failure limit.
3 failed, 797 passed, 6 skipped in 519.82 seconds
FAILURE
Waiting for background workers to finish.
22:28:28 09:19 [complete]
FAILURE
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On Feb. 6, 2018, 10:11 p.m., David McLaughlin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65537/
> -----------------------------------------------------------
>
> (Updated Feb. 6, 2018, 10:11 p.m.)
>
>
> Review request for Aurora and Jordan Ly.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Previous approach seemed almost random with the way it used line breaks for words. Caused some weirdness for edge cases. This approach just caps the size of table cells, since only metadata can grow unbounded.
>
>
> Diffs
> -----
>
> ui/src/main/sass/components/_job-page.scss 23fe3c41d859dd1c1bfc45dc24fbc18871f90ce1
>
>
> Diff: https://reviews.apache.org/r/65537/diff/1/
>
>
> Testing
> -------
>
> Tested in Vagrant (see screenshot).
>
>
> File Attachments
> ----------------
>
> scroll bar on long lines
> https://reviews.apache.org/media/uploaded/files/2018/02/06/fdce991e-34f4-4c93-b89d-b25b87694e21__Screen_Shot_2018-02-06_at_2.08.56_PM.png
>
>
> Thanks,
>
> David McLaughlin
>
>