[GitHub] potiuk edited a comment on issue #4537: Fix Google Cloud Base Hook warnings

[GitBox <gi...@apache.org>]

potiuk edited a comment on issue #4537: Fix Google Cloud Base Hook warnings
URL: https://github.com/apache/airflow/pull/4537#issuecomment-454559978
 
 
   OK I looked at it and I think this is the safest way of solving all problems with setting source=None as default in Base Hook and removing it from all other params.
   
   I do not know the history - but there was the unused source parameter in Base Hook. for whatever reason it was used before, it seems it's not used any more. 
   
   But since it is a BaseHook, I can imagine there are a number of Operators (maybe even not in the apache sources) that still use the constructor with source parameter. 
   
   I found a few in the airflow's code and removed them. But then I think it might also make sense to leave the source parameter and set default value to None so that it will work also for older code/hooks which are distributed as plugins (but removing it from all internal ones makes sense).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services