[GitHub] [iceberg] nastra commented on a diff in pull request #6023: Core: Don't fail scan planning if REST metric reporting fails

[GitBox <gi...@apache.org>]

nastra commented on code in PR #6023:
URL: https://github.com/apache/iceberg/pull/6023#discussion_r1000415611


##########
core/src/main/java/org/apache/iceberg/rest/RESTSessionCatalog.java:
##########
@@ -304,12 +304,16 @@ private void reportMetrics(
       MetricsReport report,
       Supplier<Map<String, String>> headers) {
     reporter.report(report);

Review Comment:
   we don't include this line into the `try-catch` because it's just using the `LoggingMetricsReporter`. Every metrics reporter should have its own "don't-fail-scan-planning-if-reporting-fails" and below is the one we're adding for REST metric reporting



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org