You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2022/07/07 21:24:37 UTC

[GitHub] [tvm] rafzi commented on pull request #12034: [TIR] fix crash when comparing IntImm to None

rafzi commented on PR #12034:
URL: https://github.com/apache/tvm/pull/12034#issuecomment-1178246916

   @junrushao1994 Thank you for your comments. The issue with the asserts is that the comparison would not be supported. It could also add mostly unnecessary code to a hot code path, but I did not profile.
   
   Your suggested change seems more appropriate to me.
   
   Any other opinions?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org