[GitHub] [iceberg] stevenzwu commented on a diff in pull request #5220: Flink: construct reader function in FLIP-27 source builder if not set

[GitBox <gi...@apache.org>]

stevenzwu commented on code in PR #5220:
URL: https://github.com/apache/iceberg/pull/5220#discussion_r915456528


##########
flink/v1.15/flink/src/main/java/org/apache/iceberg/flink/source/reader/RowDataReaderFunction.java:
##########
@@ -39,7 +39,7 @@ public class RowDataReaderFunction extends DataIteratorReaderFunction<RowData> {
   private final EncryptionManager encryption;
 
   public RowDataReaderFunction(
-      Configuration config, Schema tableSchema, Schema projectedSchema,
+      ReadableConfig config, Schema tableSchema, Schema projectedSchema,

Review Comment:
   switch to `ReadableConfig` interface. since this is not released, we can still make the breaking change.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org