You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/03/18 12:46:39 UTC

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #4815: tests: Extend wait time after interrupt

DaanHoogland commented on a change in pull request #4815:
URL: https://github.com/apache/cloudstack/pull/4815#discussion_r596833553



##########
File path: utils/src/test/java/com/cloud/utils/backoff/impl/ConstantTimeBackoffTest.java
##########
@@ -43,7 +43,7 @@ public void run() {
         Thread.sleep(100);
         Assert.assertFalse(backoff.getWaiters().isEmpty());
         waitThread.interrupt();
-        Thread.sleep(100);
+        Thread.sleep(500);

Review comment:
       @davidjumani, how did you get to 500? I think it would be good to make it at least a symbolic value.
   ```suggestion
           final static int TIMEOUT_AFTER_INTERUPT = 500;
           Thread.sleep(TIMEOUT_AFTER_INTERUPT);
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org