You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Gilbert Song <so...@gmail.com> on 2018/02/20 07:20:46 UTC
Review Request 65712: Added a unit test for docker daemon hangs while
pulling.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65712/
-----------------------------------------------------------
Review request for mesos, Andrei Budnik, Greg Mann, Jie Yu, and Vinod Kone.
Bugs: MESOS-8573
https://issues.apache.org/jira/browse/MESOS-8573
Repository: mesos
Description
-------
Added a unit test for docker daemon hangs while pulling.
Diffs
-----
src/tests/containerizer/docker_containerizer_tests.cpp d1e657050d623ad0412208b3aa3e3101e3654e99
src/tests/mock_docker.hpp 65bc00460dd93157c21cd7ed65403886f17b282f
Diff: https://reviews.apache.org/r/65712/diff/1/
Testing
-------
make check & sudo ./bin/mesos-tests.sh
Verified that the test failed without the fix patch.
Thanks,
Gilbert Song
Re: Review Request 65712: Added a unit test for docker daemon hangs
while pulling.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65712/#review197764
-----------------------------------------------------------
FAIL: Some of the unit tests failed. Please check the relevant logs.
Reviews applied: `['65711', '65689', '65712']`
Failed command: `Start-MesosCITesting`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65712
Relevant logs:
- [mesos-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65712/logs/mesos-tests-stdout.log):
```
[ RUN ] ExecutorAuthorizationTest.RunTaskGroup
[ OK ] ExecutorAuthorizationTest.RunTaskGroup (2226 ms)
[ RUN ] ExecutorAuthorizationTest.FailedSubscribe
[ OK ] ExecutorAuthorizationTest.FailedSubscribe (269 ms)
[ RUN ] ExecutorAuthorizationTest.FailedApiCalls
[ OK ] ExecutorAuthorizationTest.FailedApiCalls (395 ms)
[----------] 3 tests from ExecutorAuthorizationTest (2950 ms total)
[----------] 4 tests from SlaveCompatibilityTest
[ RUN ] SlaveCompatibilityTest.Equal
[ OK ] SlaveCompatibilityTest.Equal (6 ms)
[ RUN ] SlaveCompatibilityTest.Additive
[ OK ] SlaveCompatibilityTest.Additive (10 ms)
[ RUN ] SlaveCompatibilityTest.AdditiveWithReservations
[ OK ] SlaveCompatibilityTest.AdditiveWithReservations (4 ms)
[ RUN ] SlaveCompatibilityTest.Disks
[ OK ] SlaveCompatibilityTest.Disks (4 ms)
[----------] 4 tests from SlaveCompatibilityTest (27 ms total)
[----------] 75 tests from SlaveTest
[ RUN ] SlaveTest.Shutdown
[ OK ] SlaveTest.Shutdown (238 ms)
[ RUN ] SlaveTest.DuplicateTerminalUpdateBeforeAck
[ OK ] SlaveTest.DuplicateTerminalUpdateBeforeAck (291 ms)
[ RUN ] SlaveTest.ShutdownUnregisteredExecutor
D:\DCOS\mesos\mesos\src\tests\slave_tests.cpp(440): error: Failed to wait 15secs for status
D:\DCOS\mesos\mesos\src\tests\slave_tests.cpp(426): error: Actual function call count doesn't match EXPECT_CALL(sched, statusUpdate(&driver, _))...
Expected: to be called once
Actual: never called - unsatisfied and active
```
- [mesos-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65712/logs/mesos-tests-stderr.log):
```
I0220 08:03:30.996676 612 master.cpp:1422] Framework 3209feb6-7464-40c8-9833-1b3cc0df94eb-0000 (default) at scheduler-11106046-a8a2-404f-8044-998e010b112c@10.3.1.5:49156 disconnected
I0220 08:03:30.997678 612 master.cpp:3240] Deactivating framework 3209feb6-7464-40c8-9833-1b3cc0df94eb-0000 (default) at scheduler-11106046-a8a2-404f-8044-998e010b112c@10.3.1.5:49156
I0220 08:03:30.997678 612 master.cpp:3217] Disconnecting framework 3209feb6-7464-40c8-9833-1b3cc0df94eb-0000 (default) at scheduler-11106046-a8a2-404f-8044-998e010b112c@10.3.1.5:49156
I0220 08:03:30.997678 4800 hierarchical.cpp:405] Deactivated framework 3209feb6-7464-40c8-9833-1b3cc0df94eb-0000
I0220 08:03:30.997678 612 master.cpp:1437] Giving framework 3209feb6-7464-40c8-9833-1b3cc0df94eb-0000 (default) at scheduler-11106046-a8a2-404f-8044-998e010b112c@10.3.1.5:49156 0ns to failover
I0220 08:03:30.998677 3688 master.cpp:8668] Framework failover timeout, removing framework 3209feb6-7464-40c8-9833-1b3cc0df94eb-0000 (default) at scheduler-11106046-a8a2-404f-8044-998e010b112c@10.3.1.5:49156
I0220 08:03:30.998677 3688 master.cpp:9545] Removing framework 3209feb6-7464-40c8-9833-1b3cc0df94eb-0000 (default) at scheduler-11106046-a8a2-404f-8044-998e010b112c@10.3.1.5:49156
I0220 08:03:30.999676 3688 master.cpp:10249] Updating the state of task 1 of framework 3209feb6-7464-40c8-9833-1b3cc0df94eb-0000 (latest state: TASK_KILLED, status update state: TASK_KILLED)
I0220 08:03:31.001677 3688 master.cpp:10348] @ 00007FF69D84F35A )<process::ProcessBase * __ptr64
@ 00007FF69D87970C std::_Invoker_functor::_Call<lambda::internal::Partial<<lambda_886bf72aeafc85c12702c6da0cd81033>,mesos::FrameworkID,mesos::ExecutorID,process::Future<Option<mesos::slave::ContainerTermination> >,std::_Ph<1> >,process::ProcessBase * __ptr64>
@ 00007FF69D8FCCFC std::invoke<lambda::internal::Partial<<lambda_886bf72aeafc85c12702c6da0cd81033>,mesos::FrameworkID,mesos::ExecutorID,process::Future<Option<mesos::slave::ContainerTermination> >,std::_Ph<1> >,process::ProcessBase * __ptr64>
@ 00007FF69D857321 )<lambda::internal::Partial<<lambda_886bf72aeafc85c12702c6da0cd81033>,mesos::FrameworkID,mesos::ExecutorID,process::Future<Option<mesos::slave::ContainerTermination> >,std::_Ph<1> >,process::ProcessBase * __ptr64
@ 00007FF69D990FF6 process::ProcessBase * __ptr64)>::CallableFn<lambda::internal::Partial<<lambda_886bf72aeafc85c12702c6da0cd81033>,mesos::FrameworkID,mesos::ExecutorID,process::Future<Option<mesos::slave::ContainerTermination> >,std::_Ph<1> > >::operator(
@ 00007FF69F3D269D process::ProcessBase * __ptr64)>::operator(
@ 00007FF69F2AB969 process::ProcessBase::consume
@ 00007FF69F425F5A process::DispatchEvent::consume
@ 00007FF69B5FEF17 process::ProcessBase::serve
@ 00007FF69F2B9880 process::ProcessManager::resume
@ 00007FF69F3C2DF1 ??
@ 00007FF69F301AE0 std::_Invoker_functor::_Call<<lambda_124422ac022fa041208b80c1460630d7> >
@ 00007FF69F357730 std::invoke<<lambda_124422ac022fa041208b80c1460630d7> >
@ 00007FF69F31085C std::_LaunchPad<std::unique_ptr<std::tuple<<lambda_124422ac022fa041208b80c1460630d7> >,std::default_delete<std::tuple<<lambda_124422ac022fa041208b80c1460630d7> > > > >::_Execute<0>
@ 00007FF69F40E21A std::_LaunchPad<std::unique_ptr<std::tuple<<lambda_124422ac022fa041208b80c1460630d7> >,std::default_delete<std::tuple<<lambda_124422ac022fa041208b80c1460630d7> > > > >::_Run
@ 00007FF69F3FAD78 std::_LaunchPad<std::unique_ptr<std::tuple<<lambda_124422ac022fa041208b80c1460630d7> >,std::default_delete<std::tuple<<lambda_124422ac022fa041208b80c1460630d7> > > > >::_Go
@ 00007FF69F3E2D7D std::_Pad::_Call_func
@ 00007FF6A05FC3B8 invoke_thread_procedure
@ 00007FF6A05FBE61 __cdecl*)(void * __ptr64)
@ 00007FF8E3F91FE4 BaseThreadInitThunk
@ 00007FF8E6A4EFB1 RtlUserThreadStart
```
- Mesos Reviewbot Windows
On Feb. 20, 2018, 7:20 a.m., Gilbert Song wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65712/
> -----------------------------------------------------------
>
> (Updated Feb. 20, 2018, 7:20 a.m.)
>
>
> Review request for mesos, Andrei Budnik, Greg Mann, Jie Yu, and Vinod Kone.
>
>
> Bugs: MESOS-8573
> https://issues.apache.org/jira/browse/MESOS-8573
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added a unit test for docker daemon hangs while pulling.
>
>
> Diffs
> -----
>
> src/tests/containerizer/docker_containerizer_tests.cpp d1e657050d623ad0412208b3aa3e3101e3654e99
> src/tests/mock_docker.hpp 65bc00460dd93157c21cd7ed65403886f17b282f
>
>
> Diff: https://reviews.apache.org/r/65712/diff/1/
>
>
> Testing
> -------
>
> make check & sudo ./bin/mesos-tests.sh
>
> Verified that the test failed without the fix patch.
>
>
> Thanks,
>
> Gilbert Song
>
>