You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/07/09 14:32:16 UTC
[GitHub] [flink] wuchong commented on a change in pull request #9045:
[FLINK-12955][hbase] Support LookupableTableSource for HBase
wuchong commented on a change in pull request #9045: [FLINK-12955][hbase] Support LookupableTableSource for HBase
URL: https://github.com/apache/flink/pull/9045#discussion_r301619382
##########
File path: flink-connectors/flink-hbase/src/main/java/org/apache/flink/addons/hbase/HBaseTableSchema.java
##########
@@ -64,12 +73,31 @@ void addColumn(String family, String qualifier, Class<?> clazz) {
familyMap.put(family, qualifierMap);
}
+ /**
+ * Sets row key information in the table schema.
+ * @param rowKeyName the row key field name
+ * @param clazz the data type of the row key
+ */
+ public void setRowKey(String rowKeyName, Class<?> clazz) {
Review comment:
This method is used in `HBaseTableSource` and `HBaseTableFactory`. But I can make the methods as package-private.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services