You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Till Toenshoff <to...@me.com> on 2014/11/07 21:26:43 UTC
Review Request 27741: Fixed Authenticator SASL auxiliary memory
access.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27741/
-----------------------------------------------------------
Review request for mesos, Adam B and Vinod Kone.
Bugs: MESOS-2050
https://issues.apache.org/jira/browse/MESOS-2050
Repository: mesos-git
Description
-------
see summary.
Diffs
-----
src/authentication/authenticator.hpp 2f95db1
src/authentication/cram_md5/authenticator.hpp 601248d
src/master/master.cpp a860496
src/tests/cram_md5_authentication_tests.cpp 74ea2ad
Diff: https://reviews.apache.org/r/27741/diff/
Testing
-------
make check
Thanks,
Till Toenshoff
Re: Review Request 27741: Fixed Authenticator SASL auxiliary memory
access.
Posted by Till Toenshoff <to...@me.com>.
> On Nov. 7, 2014, 8:31 p.m., Adam B wrote:
> > LGTM, but we may want to warn people that the Authenticator interface is expected to change (slightly) in 0.22
Indeed - I shall add that to the interface definition right away.
- Till
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27741/#review60372
-----------------------------------------------------------
On Nov. 7, 2014, 8:26 p.m., Till Toenshoff wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27741/
> -----------------------------------------------------------
>
> (Updated Nov. 7, 2014, 8:26 p.m.)
>
>
> Review request for mesos, Adam B and Vinod Kone.
>
>
> Bugs: MESOS-2050
> https://issues.apache.org/jira/browse/MESOS-2050
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> see summary.
>
>
> Diffs
> -----
>
> src/authentication/authenticator.hpp 2f95db1
> src/authentication/cram_md5/authenticator.hpp 601248d
> src/master/master.cpp a860496
> src/tests/cram_md5_authentication_tests.cpp 74ea2ad
>
> Diff: https://reviews.apache.org/r/27741/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Till Toenshoff
>
>
Re: Review Request 27741: Fixed Authenticator SASL auxiliary memory
access.
Posted by Adam B <ad...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27741/#review60372
-----------------------------------------------------------
Ship it!
LGTM, but we may want to warn people that the Authenticator interface is expected to change (slightly) in 0.22
- Adam B
On Nov. 7, 2014, 12:26 p.m., Till Toenshoff wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27741/
> -----------------------------------------------------------
>
> (Updated Nov. 7, 2014, 12:26 p.m.)
>
>
> Review request for mesos, Adam B and Vinod Kone.
>
>
> Bugs: MESOS-2050
> https://issues.apache.org/jira/browse/MESOS-2050
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> see summary.
>
>
> Diffs
> -----
>
> src/authentication/authenticator.hpp 2f95db1
> src/authentication/cram_md5/authenticator.hpp 601248d
> src/master/master.cpp a860496
> src/tests/cram_md5_authentication_tests.cpp 74ea2ad
>
> Diff: https://reviews.apache.org/r/27741/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Till Toenshoff
>
>
Re: Review Request 27741: Fixed Authenticator SASL auxiliary memory
access.
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27741/#review60453
-----------------------------------------------------------
Patch looks great!
Reviews applied: [27741]
All tests passed.
- Mesos ReviewBot
On Nov. 7, 2014, 11:47 p.m., Till Toenshoff wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27741/
> -----------------------------------------------------------
>
> (Updated Nov. 7, 2014, 11:47 p.m.)
>
>
> Review request for mesos, Adam B and Vinod Kone.
>
>
> Bugs: MESOS-2050
> https://issues.apache.org/jira/browse/MESOS-2050
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> see summary.
>
>
> Diffs
> -----
>
> src/authentication/authenticator.hpp 2f95db1
> src/authentication/cram_md5/authenticator.hpp 601248d
> src/master/master.cpp a860496
> src/tests/cram_md5_authentication_tests.cpp 74ea2ad
>
> Diff: https://reviews.apache.org/r/27741/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Till Toenshoff
>
>
Re: Review Request 27741: Fixed Authenticator SASL auxiliary memory
access.
Posted by Till Toenshoff <to...@me.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27741/
-----------------------------------------------------------
(Updated Nov. 7, 2014, 11:47 p.m.)
Review request for mesos, Adam B and Vinod Kone.
Changes
-------
Addressed comments.
Bugs: MESOS-2050
https://issues.apache.org/jira/browse/MESOS-2050
Repository: mesos-git
Description
-------
see summary.
Diffs (updated)
-----
src/authentication/authenticator.hpp 2f95db1
src/authentication/cram_md5/authenticator.hpp 601248d
src/master/master.cpp a860496
src/tests/cram_md5_authentication_tests.cpp 74ea2ad
Diff: https://reviews.apache.org/r/27741/diff/
Testing
-------
make check
Thanks,
Till Toenshoff
Re: Review Request 27741: Fixed Authenticator SASL auxiliary memory
access.
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27741/#review60389
-----------------------------------------------------------
Patch looks great!
Reviews applied: [27741]
All tests passed.
- Mesos ReviewBot
On Nov. 7, 2014, 8:42 p.m., Till Toenshoff wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27741/
> -----------------------------------------------------------
>
> (Updated Nov. 7, 2014, 8:42 p.m.)
>
>
> Review request for mesos, Adam B and Vinod Kone.
>
>
> Bugs: MESOS-2050
> https://issues.apache.org/jira/browse/MESOS-2050
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> see summary.
>
>
> Diffs
> -----
>
> src/authentication/authenticator.hpp 2f95db1
> src/authentication/cram_md5/authenticator.hpp 601248d
> src/master/master.cpp a860496
> src/tests/cram_md5_authentication_tests.cpp 74ea2ad
>
> Diff: https://reviews.apache.org/r/27741/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Till Toenshoff
>
>
Re: Review Request 27741: Fixed Authenticator SASL auxiliary memory
access.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27741/#review60382
-----------------------------------------------------------
Ship it!
src/authentication/cram_md5/authenticator.hpp
<https://reviews.apache.org/r/27741/#comment101747>
Should this be void now?
- Vinod Kone
On Nov. 7, 2014, 8:42 p.m., Till Toenshoff wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27741/
> -----------------------------------------------------------
>
> (Updated Nov. 7, 2014, 8:42 p.m.)
>
>
> Review request for mesos, Adam B and Vinod Kone.
>
>
> Bugs: MESOS-2050
> https://issues.apache.org/jira/browse/MESOS-2050
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> see summary.
>
>
> Diffs
> -----
>
> src/authentication/authenticator.hpp 2f95db1
> src/authentication/cram_md5/authenticator.hpp 601248d
> src/master/master.cpp a860496
> src/tests/cram_md5_authentication_tests.cpp 74ea2ad
>
> Diff: https://reviews.apache.org/r/27741/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Till Toenshoff
>
>
Re: Review Request 27741: Fixed Authenticator SASL auxiliary memory
access.
Posted by Till Toenshoff <to...@me.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27741/
-----------------------------------------------------------
(Updated Nov. 7, 2014, 8:42 p.m.)
Review request for mesos, Adam B and Vinod Kone.
Changes
-------
Added comment announcing an upcoming change.
Bugs: MESOS-2050
https://issues.apache.org/jira/browse/MESOS-2050
Repository: mesos-git
Description
-------
see summary.
Diffs (updated)
-----
src/authentication/authenticator.hpp 2f95db1
src/authentication/cram_md5/authenticator.hpp 601248d
src/master/master.cpp a860496
src/tests/cram_md5_authentication_tests.cpp 74ea2ad
Diff: https://reviews.apache.org/r/27741/diff/
Testing
-------
make check
Thanks,
Till Toenshoff