[GitHub] [flink-ml] lindong28 commented on a diff in pull request #167: [FLINK-29786] VarianceThresholdSelector Uses FeaturesCol Incorrectly

[GitBox <gi...@apache.org>]

lindong28 commented on code in PR #167:
URL: https://github.com/apache/flink-ml/pull/167#discussion_r1007646156


##########
flink-ml-lib/src/main/java/org/apache/flink/ml/common/param/HasFeaturesCol.java:
##########
@@ -24,6 +24,14 @@
 import org.apache.flink.ml.param.WithParams;
 
 /** Interface for the shared featuresCol param. */
+
+/**
+ * Interface for the shared featuresCol param.

Review Comment:
   Should we remove the redundant description above?
   
   And it might be simpler and softer to use the following doc:
   
   ```
   /**
    * Interface for the shared featuresCol param.
    *
    * {@link HasFeaturesCol} is typically used for {@link Stage}s that implement {@link HasLabelCol}. It is preferred
    * to use {@link HasInputCol} for other cases.
    */
   ```
   
   Please also update the corresponding python doc if we make the change here.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org