You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "JNSimba (via GitHub)" <gi...@apache.org> on 2026/04/08 02:31:14 UTC
[PR] [feature](job) Support internal pass-through properties with "__" prefix in streaming job [doris]
JNSimba opened a new pull request, #62193:
URL: https://github.com/apache/doris/pull/62193
### What problem does this PR solve?
Issue Number: close #xxx
Problem Summary:
Currently, streaming job properties are strictly validated against a whitelist. This makes it impossible for users to attach custom metadata (e.g., distinguishing data source variants like `aws_aurora` vs standard `postgres` that share the same protocol) without modifying the kernel code and releasing a new version.
This PR allows properties prefixed with `__` to bypass validation and be stored as-is, enabling users to pass through custom metadata in job properties.
### Release note
Support internal pass-through properties with `__` prefix in streaming job PROPERTIES clause. These properties are stored as-is without validation, allowing users to attach custom metadata to streaming jobs.
### Check List (For Author)
- Test
- [x] Regression test
- [ ] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason
- Behavior changed:
- [x] Yes. Properties prefixed with `__` in streaming job PROPERTIES clause are now accepted and stored, previously they would be rejected as invalid.
- Does this need documentation?
- [ ] No.
- [x] Yes.
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](job) Support internal pass-through properties with "__" prefix in streaming job [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #62193:
URL: https://github.com/apache/doris/pull/62193#issuecomment-4203705883
# FE UT Coverage Report
Increment line coverage ` 0.00% (0/2)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/62193_f53dc5857d40354a83eca64e73b7e7fa3317ad89/fe_increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/62193_f53dc5857d40354a83eca64e73b7e7fa3317ad89/fe_report/index.html)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](job) Support internal pass-through properties with "__" prefix in streaming job [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #62193:
URL: https://github.com/apache/doris/pull/62193#issuecomment-4210951852
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](job) Support internal pass-through properties with "__" prefix in streaming job [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #62193:
URL: https://github.com/apache/doris/pull/62193#issuecomment-4210951959
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](job) Support internal pass-through properties with "__" prefix in streaming job [doris]
Posted by "JNSimba (via GitHub)" <gi...@apache.org>.
JNSimba commented on PR #62193:
URL: https://github.com/apache/doris/pull/62193#issuecomment-4203742024
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](job) Support internal pass-through properties with "__" prefix in streaming job [doris]
Posted by "JNSimba (via GitHub)" <gi...@apache.org>.
JNSimba merged PR #62193:
URL: https://github.com/apache/doris/pull/62193
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](job) Support internal pass-through properties with "__" prefix in streaming job [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on code in PR #62193:
URL: https://github.com/apache/doris/pull/62193#discussion_r3049571477
##########
fe/fe-core/src/main/java/org/apache/doris/job/extensions/insert/streaming/StreamingJobProperties.java:
##########
@@ -69,6 +70,12 @@ public StreamingJobProperties(Map<String, String> jobProperties) {
public void validate() throws AnalysisException {
List<String> invalidProps = new ArrayList<>();
for (String key : properties.keySet()) {
+ // Keys starting with "__" are internal pass-through properties
+ // that are stored as-is without validation, allowing users
+ // to attach custom metadata.
Review Comment:
Allowing every `__*` key through here also makes those keys persist into `StreamingInsertJob.properties`, and `StreamingInsertJob.getTvfInfo()` later serializes that map verbatim into the jobs metadata / SHOW output. Because this feature is explicitly framed as "internal pass-through properties", that becomes an unintended disclosure path for any opaque metadata callers attach here. Please either filter/redact `__*` keys on the display path or explicitly treat them as user-visible metadata instead of internal-only values.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](job) Support internal pass-through properties with "__" prefix in streaming job [doris]
Posted by "JNSimba (via GitHub)" <gi...@apache.org>.
JNSimba commented on PR #62193:
URL: https://github.com/apache/doris/pull/62193#issuecomment-4204264066
/review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feature](job) Support internal pass-through properties with "__" prefix in streaming job [doris]
Posted by "Thearas (via GitHub)" <gi...@apache.org>.
Thearas commented on PR #62193:
URL: https://github.com/apache/doris/pull/62193#issuecomment-4203411469
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR).
Please clearly describe your PR:
1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
3. What features were added. Why was this function added?
4. Which code was refactored and why was this part of the code refactored?
5. Which functions were optimized and what is the difference before and after the optimization?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](job) Support internal pass-through properties with "__" prefix in streaming job [doris]
Posted by "JNSimba (via GitHub)" <gi...@apache.org>.
JNSimba commented on PR #62193:
URL: https://github.com/apache/doris/pull/62193#issuecomment-4203429764
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org