You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@yunikorn.apache.org by GitBox <gi...@apache.org> on 2020/03/18 13:40:05 UTC
[GitHub] [incubator-yunikorn-web] akhilpb001 opened a new pull request #25:
YUNIKORN-38. YuniKorn UI behaves incorrectly when max resource is not set
akhilpb001 opened a new pull request #25: YUNIKORN-38. YuniKorn UI behaves incorrectly when max resource is not set
URL: https://github.com/apache/incubator-yunikorn-web/pull/25
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@yunikorn.apache.org
For additional commands, e-mail: dev-help@yunikorn.apache.org
[GitHub] [incubator-yunikorn-web] akhilpb001 commented on issue #25:
YUNIKORN-38. YuniKorn UI behaves incorrectly when max resource is not set
Posted by GitBox <gi...@apache.org>.
akhilpb001 commented on issue #25: YUNIKORN-38. YuniKorn UI behaves incorrectly when max resource is not set
URL: https://github.com/apache/incubator-yunikorn-web/pull/25#issuecomment-601058800
@yangwwei
1. I have updated the PR with the new logo for side nav bar
2. I think it would be better the scheduler to send the absUsedCapacity in the api response (which is used to show usage bar), because sometimes configured capacity could be empty and UI can not do that calculation in that case.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@yunikorn.apache.org
For additional commands, e-mail: dev-help@yunikorn.apache.org
[GitHub] [incubator-yunikorn-web] yangwwei edited a comment on issue #25:
YUNIKORN-38. YuniKorn UI behaves incorrectly when max resource is not set
Posted by GitBox <gi...@apache.org>.
yangwwei edited a comment on issue #25: YUNIKORN-38. YuniKorn UI behaves incorrectly when max resource is not set
URL: https://github.com/apache/incubator-yunikorn-web/pull/25#issuecomment-600877468
Hi @akhilpb001
Thanks for working on this!! I tested the changes locally and attached the screenshot here, there are 2 things I want to discuss
<img width="1679" alt="YuniKorn_UI" src="https://user-images.githubusercontent.com/14214570/77010331-cac80000-6926-11ea-85c6-6629b2e00a2c.png">
1. for the logo, can you please use the logos we have here: https://github.com/apache/incubator-yunikorn-core/tree/master/docs/images/logo. Since the background is dark blue, I think we can try the gray one.
2. for the usage bar, now it is nicer, but are they hard-coded to 20%? Can we calculate the relative percentage to the biggest queue-usage and use that for the usage-bar?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@yunikorn.apache.org
For additional commands, e-mail: dev-help@yunikorn.apache.org
[GitHub] [incubator-yunikorn-web] akhilpb001 commented on issue #25:
YUNIKORN-38. YuniKorn UI behaves incorrectly when max resource is not set
Posted by GitBox <gi...@apache.org>.
akhilpb001 commented on issue #25: YUNIKORN-38. YuniKorn UI behaves incorrectly when max resource is not set
URL: https://github.com/apache/incubator-yunikorn-web/pull/25#issuecomment-601007054
@yangwwei
1. Will use the new logo
2. I took the value from response. I thought they are calculated by scheduler itself. How do you want me to calculate this? I did not understand what you said above.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@yunikorn.apache.org
For additional commands, e-mail: dev-help@yunikorn.apache.org
[GitHub] [incubator-yunikorn-web] yangwwei commented on issue #25:
YUNIKORN-38. YuniKorn UI behaves incorrectly when max resource is not set
Posted by GitBox <gi...@apache.org>.
yangwwei commented on issue #25: YUNIKORN-38. YuniKorn UI behaves incorrectly when max resource is not set
URL: https://github.com/apache/incubator-yunikorn-web/pull/25#issuecomment-601330140
Great, looks good to me. +1
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@yunikorn.apache.org
For additional commands, e-mail: dev-help@yunikorn.apache.org
[GitHub] [incubator-yunikorn-web] yangwwei merged pull request #25:
YUNIKORN-38. YuniKorn UI behaves incorrectly when max resource is not set
Posted by GitBox <gi...@apache.org>.
yangwwei merged pull request #25: YUNIKORN-38. YuniKorn UI behaves incorrectly when max resource is not set
URL: https://github.com/apache/incubator-yunikorn-web/pull/25
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@yunikorn.apache.org
For additional commands, e-mail: dev-help@yunikorn.apache.org
[GitHub] [incubator-yunikorn-web] akhilpb001 commented on issue #25:
YUNIKORN-38. YuniKorn UI behaves incorrectly when max resource is not set
Posted by GitBox <gi...@apache.org>.
akhilpb001 commented on issue #25: YUNIKORN-38. YuniKorn UI behaves incorrectly when max resource is not set
URL: https://github.com/apache/incubator-yunikorn-web/pull/25#issuecomment-600628408
@yangwwei @sunilgovind @wilfred-s please review the PR
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@yunikorn.apache.org
For additional commands, e-mail: dev-help@yunikorn.apache.org
[GitHub] [incubator-yunikorn-web] yangwwei commented on issue #25:
YUNIKORN-38. YuniKorn UI behaves incorrectly when max resource is not set
Posted by GitBox <gi...@apache.org>.
yangwwei commented on issue #25: YUNIKORN-38. YuniKorn UI behaves incorrectly when max resource is not set
URL: https://github.com/apache/incubator-yunikorn-web/pull/25#issuecomment-600877468
Hi @akhilpb001
Thanks for working on this!! I tested the changes locally and attached the screenshot here, there are 2 things I want to discuss
<img width="1679" alt="YuniKorn_UI" src="https://user-images.githubusercontent.com/14214570/77010331-cac80000-6926-11ea-85c6-6629b2e00a2c.png">
1. for the logo, can you please use the logos we have here: https://github.com/apache/incubator-yunikorn-core/tree/master/docs/images/logo. Since the background is dark blue, I think we can try the gray one.
2. for the usage bar, now it is nicer, but are they static values? Can we calculate the relative percentage to the biggest queue-usage and use that for the usage-bar?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@yunikorn.apache.org
For additional commands, e-mail: dev-help@yunikorn.apache.org