You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@camel.apache.org by dmitrimedvedev <dm...@gmail.com> on 2014/07/23 00:05:48 UTC

camel-splunk streaming mode

When using camel-splunk consumer component I noticed that when large amount
of splunk
events is returned in a single poll it runs out of memory, because it
collects all polled results
into an array list.

To remedy this I added optional streaming support to the camel-splunk
consumer:

https://github.com/dmitrimedvedev/camel/commit/7e4b5e9b206c7a969e6012d9afa40ac7024ee515

Does it look correct? and if yes, how do I go about contributing this patch?

Thanks,

Dmitri



--
View this message in context: http://camel.465427.n5.nabble.com/camel-splunk-streaming-mode-tp5754269.html
Sent from the Camel Development mailing list archive at Nabble.com.

Re: camel-splunk streaming mode

Posted by dmitrimedvedev <dm...@gmail.com>.

Willem, thanks for reviewing it and for the comment.
I implemented your suggestion, created a jira and referenced the patch.
https://issues.apache.org/jira/browse/CAMEL-7632



--
View this message in context: http://camel.465427.n5.nabble.com/camel-splunk-streaming-mode-tp5754269p5754311.html
Sent from the Camel Development mailing list archive at Nabble.com.

Re: camel-splunk streaming mode

Posted by Willem Jiang <wi...@gmail.com>.

You can fill a JIRA[1] and send a pull request from your github with the comment of the JIRA number. In this way, the pull request and JIRA can be linked together.

BTW, I just had a quick look of your code, and added a comment for it.

[1]https://issues.apache.org/jira/browse/CAMEL

--  
Willem Jiang

Red Hat, Inc.
Web: http://www.redhat.com
Blog: http://willemjiang.blogspot.com (English)
http://jnn.iteye.com (Chinese)
Twitter: willemjiang  
Weibo: 姜宁willem

On July 23, 2014 at 6:06:14 AM, dmitrimedvedev (dmitri.medvedev@gmail.com) wrote:
> When using camel-splunk consumer component I noticed that when large amount
> of splunk
> events is returned in a single poll it runs out of memory, because it
> collects all polled results
> into an array list.
>  
> To remedy this I added optional streaming support to the camel-splunk
> consumer:
>  
> https://github.com/dmitrimedvedev/camel/commit/7e4b5e9b206c7a969e6012d9afa40ac7024ee515  
>  
> Does it look correct? and if yes, how do I go about contributing this patch?
>  
> Thanks,
>  
> Dmitri
>  
>  
>  
> --
> View this message in context: http://camel.465427.n5.nabble.com/camel-splunk-streaming-mode-tp5754269.html  
> Sent from the Camel Development mailing list archive at Nabble.com.
>