You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/04/12 01:27:58 UTC
[GitHub] [apisix] nic-chen opened a new pull request #4026: chore: cache deps for CI
nic-chen opened a new pull request #4026:
URL: https://github.com/apache/apisix/pull/4026
### What this PR does / why we need it:
<!--- Why is this change required? What problem does it solve? -->
<!--- If it fixes an open issue, please link to the issue here. -->
Cache the deps directory in ci.
The key of the cache is the hash value of the file content of rockspec/apisix-master-0.rockspec.
If the hash value is changed, the cache will not be used.
The cache will become invalid if it is not used within 7 days.
### Pre-submission checklist:
* [x] Did you explain what problem does this PR solve? Or what new features have been added?
* [ ] Have you added corresponding test cases?
* [ ] Have you modified the corresponding document?
* [x] Is this PR backward compatible? **If it is not backward compatible, please discuss on the [mailing list](https://github.com/apache/apisix/tree/master#community) first**
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander commented on pull request #4026: ci: cache deps
Posted by GitBox <gi...@apache.org>.
spacewander commented on pull request #4026:
URL: https://github.com/apache/apisix/pull/4026#issuecomment-818366833
Look like something wrong is cached?
https://github.com/apache/apisix/pull/4026/checks?check_run_id=2329191183
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander commented on pull request #4026: ci: cache deps
Posted by GitBox <gi...@apache.org>.
spacewander commented on pull request #4026:
URL: https://github.com/apache/apisix/pull/4026#issuecomment-817738669
The CI failed:
```
++ mv grpc_server_example build-cache/
mv: cannot move 'grpc_server_example' to 'build-cache/': Not a directory
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander commented on a change in pull request #4026: chore: cache deps for CI
Posted by GitBox <gi...@apache.org>.
spacewander commented on a change in pull request #4026:
URL: https://github.com/apache/apisix/pull/4026#discussion_r611505935
##########
File path: .github/workflows/centos7-ci.yml
##########
@@ -26,100 +26,108 @@ jobs:
ETCD_ADVERTISE_CLIENT_URLS: http://0.0.0.0:2379
steps:
- - name: Check out code
- uses: actions/checkout@v2
- with:
- submodules: recursive
-
- - name: Extract branch name
- if: ${{ startsWith(github.ref, 'refs/heads/release/') }}
- id: branch_env
- shell: bash
- run: |
- echo "##[set-output name=version;]$(echo ${GITHUB_REF##*/})"
-
- - name: Build rpm package
- if: ${{ startsWith(github.ref, 'refs/heads/release/') }}
- run: |
- export VERSION=${{ steps.branch_env.outputs.version }}
- sudo gem install --no-document fpm
- git clone https://github.com/api7/apisix-build-tools.git
- cd apisix-build-tools
- make package type=rpm app=apisix version=${VERSION} checkout=release/${VERSION}
- cd ..
- rm -rf $(ls -1 --ignore=apisix-build-tools --ignore=t --ignore=utils --ignore=ci --ignore=Makefile --ignore=rockspec)
-
- - name: Install Redis Cluster
- run: |
- docker run -d -p ${MASTER1_PORT}:6379 -p ${MASTER2_PORT}:6380 -p ${MASTER3_PORT}:6381 -p ${SLAVE1_PORT}:6382 -p ${SLAVE2_PORT}:6383 -p ${SLAVE3_PORT}:6384 --name redis-cluster vishnunair/docker-redis-cluster:latest
- env:
- MASTER1_PORT: 5000
- MASTER2_PORT: 5001
- MASTER3_PORT: 5002
- SLAVE1_PORT: 5003
- SLAVE2_PORT: 5004
- SLAVE3_PORT: 5005
-
- - name: Running Redis Cluster Test
- run: |
- sudo apt-get install -y redis-tools
- docker ps -a
- redis-cli -h 127.0.0.1 -p 5000 ping
- redis-cli -h 127.0.0.1 -p 5000 cluster nodes
-
- - name: Running etcd server with TLS
- run: |
- sudo docker run -d -p 12379:12379 -p 12380:12380 \
- -e ALLOW_NONE_AUTHENTICATION=yes \
- -e ETCD_ADVERTISE_CLIENT_URLS=https://0.0.0.0:12379 \
- -e ETCD_LISTEN_CLIENT_URLS=https://0.0.0.0:12379 \
- -e ETCD_CERT_FILE=/certs/etcd.pem \
- -e ETCD_KEY_FILE=/certs/etcd.key \
- -e GITHUB_ACTIONS=true \
- -e CI=true \
- -v /home/runner/work/apisix/apisix/t/certs:/certs \
- bitnami/etcd:3.4.0
-
- - name: Run centos7 docker and mapping apisix into container
- run: |
- docker run -itd -v /home/runner/work/apisix/apisix:/apisix --name centos7Instance --net="host" docker.io/centos:7 /bin/bash
- # docker exec centos7Instance bash -c "cp -r /tmp/apisix ./"
-
- - name: Run other docker containers for test
- run: |
- docker run --rm -itd -p 6379:6379 --name apisix_redis redis:3.0-alpine
- docker run --rm -itd -e HTTP_PORT=8888 -e HTTPS_PORT=9999 -p 8888:8888 -p 9999:9999 mendhak/http-https-echo
- docker run --rm -itd -e KEYCLOAK_USER=admin -e KEYCLOAK_PASSWORD=123456 -p 8090:8080 -p 8443:8443 sshniro/keycloak-apisix:1.0.0
- docker network create kafka-net --driver bridge
- docker run --name zookeeper-server -d -p 2181:2181 --network kafka-net -e ALLOW_ANONYMOUS_LOGIN=yes bitnami/zookeeper:3.6.0
- docker run --name kafka-server1 -d --network kafka-net -e ALLOW_PLAINTEXT_LISTENER=yes -e KAFKA_CFG_ZOOKEEPER_CONNECT=zookeeper-server:2181 -e KAFKA_CFG_ADVERTISED_LISTENERS=PLAINTEXT://127.0.0.1:9092 -p 9092:9092 -e KAFKA_CFG_AUTO_CREATE_TOPICS_ENABLE=true bitnami/kafka:latest
- docker run --name eureka -d -p 8761:8761 --env ENVIRONMENT=apisix --env spring.application.name=apisix-eureka --env server.port=8761 --env eureka.instance.ip-address=127.0.0.1 --env eureka.client.registerWithEureka=true --env eureka.client.fetchRegistry=false --env eureka.client.serviceUrl.defaultZone=http://127.0.0.1:8761/eureka/ bitinit/eureka
- sleep 5
- docker exec -i kafka-server1 /opt/bitnami/kafka/bin/kafka-topics.sh --create --zookeeper zookeeper-server:2181 --replication-factor 1 --partitions 1 --topic test2
- docker exec -i kafka-server1 /opt/bitnami/kafka/bin/kafka-topics.sh --create --zookeeper zookeeper-server:2181 --replication-factor 1 --partitions 3 --topic test3
- docker run --rm --name skywalking -d -p 1234:1234 -p 11800:11800 -p 12800:12800 apache/skywalking-oap-server:8.3.0-es6
- docker run --rm --name consul_1 -d -p 8500:8500 consul:1.7 consul agent -server -bootstrap-expect=1 -client 0.0.0.0 -log-level info -data-dir=/consul/data
- docker run --rm --name consul_2 -d -p 8600:8500 consul:1.7 consul agent -server -bootstrap-expect=1 -client 0.0.0.0 -log-level info -data-dir=/consul/data
-
- - name: Install dependencies
- run: |
- docker exec centos7Instance bash -c "cd apisix && ./utils/centos7-ci.sh install_dependencies"
-
- - name: Install rpm package
- if: ${{ startsWith(github.ref, 'refs/heads/release/') }}
- run: |
- docker exec centos7Instance bash -c "cd apisix && rpm -iv --prefix=/apisix ./apisix-build-tools/output/apisix-${{ steps.branch_env.outputs.version }}-0.x86_64.rpm"
- # Dependencies are attached with rpm, so revert `make deps`
- docker exec centos7Instance bash -c "cd apisix && rm -rf deps"
- docker exec centos7Instance bash -c "cd apisix && mv usr/bin . && mv usr/local/apisix/* ."
-
- - name: Run test cases
- run: |
- docker exec centos7Instance bash -c "cd apisix && ./utils/centos7-ci.sh run_case"
-
- - name: Publish Artifact
- if: ${{ startsWith(github.ref, 'refs/heads/release/') }}
- uses: actions/upload-artifact@v2.2.3
- with:
- name: "rpm"
- path: "./apisix-build-tools/output/apisix-${{ steps.branch_env.outputs.version }}-0.x86_64.rpm"
+ - name: Check out code
Review comment:
Better to avoid irrelevant change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] nic-chen commented on a change in pull request #4026: chore: cache deps for CI
Posted by GitBox <gi...@apache.org>.
nic-chen commented on a change in pull request #4026:
URL: https://github.com/apache/apisix/pull/4026#discussion_r611500155
##########
File path: .github/workflows/build.yml
##########
@@ -56,6 +56,14 @@ jobs:
with:
submodules: recursive
+ - name: Cache deps
+ uses: actions/cache@v2
+ env:
+ cache-name: cache-deps
+ with:
+ path: ~/deps
Review comment:
it's a typo, fixed. thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander commented on a change in pull request #4026: chore: cache deps for CI
Posted by GitBox <gi...@apache.org>.
spacewander commented on a change in pull request #4026:
URL: https://github.com/apache/apisix/pull/4026#discussion_r611283639
##########
File path: .github/workflows/centos7-ci.yml
##########
@@ -26,100 +26,108 @@ jobs:
ETCD_ADVERTISE_CLIENT_URLS: http://0.0.0.0:2379
steps:
- - name: Check out code
- uses: actions/checkout@v2
- with:
- submodules: recursive
-
- - name: Extract branch name
- if: ${{ startsWith(github.ref, 'refs/heads/release/') }}
- id: branch_env
- shell: bash
- run: |
- echo "##[set-output name=version;]$(echo ${GITHUB_REF##*/})"
-
- - name: Build rpm package
- if: ${{ startsWith(github.ref, 'refs/heads/release/') }}
- run: |
- export VERSION=${{ steps.branch_env.outputs.version }}
- sudo gem install --no-document fpm
- git clone https://github.com/api7/apisix-build-tools.git
- cd apisix-build-tools
- make package type=rpm app=apisix version=${VERSION} checkout=release/${VERSION}
- cd ..
- rm -rf $(ls -1 --ignore=apisix-build-tools --ignore=t --ignore=utils --ignore=ci --ignore=Makefile --ignore=rockspec)
-
- - name: Install Redis Cluster
- run: |
- docker run -d -p ${MASTER1_PORT}:6379 -p ${MASTER2_PORT}:6380 -p ${MASTER3_PORT}:6381 -p ${SLAVE1_PORT}:6382 -p ${SLAVE2_PORT}:6383 -p ${SLAVE3_PORT}:6384 --name redis-cluster vishnunair/docker-redis-cluster:latest
- env:
- MASTER1_PORT: 5000
- MASTER2_PORT: 5001
- MASTER3_PORT: 5002
- SLAVE1_PORT: 5003
- SLAVE2_PORT: 5004
- SLAVE3_PORT: 5005
-
- - name: Running Redis Cluster Test
- run: |
- sudo apt-get install -y redis-tools
- docker ps -a
- redis-cli -h 127.0.0.1 -p 5000 ping
- redis-cli -h 127.0.0.1 -p 5000 cluster nodes
-
- - name: Running etcd server with TLS
- run: |
- sudo docker run -d -p 12379:12379 -p 12380:12380 \
- -e ALLOW_NONE_AUTHENTICATION=yes \
- -e ETCD_ADVERTISE_CLIENT_URLS=https://0.0.0.0:12379 \
- -e ETCD_LISTEN_CLIENT_URLS=https://0.0.0.0:12379 \
- -e ETCD_CERT_FILE=/certs/etcd.pem \
- -e ETCD_KEY_FILE=/certs/etcd.key \
- -e GITHUB_ACTIONS=true \
- -e CI=true \
- -v /home/runner/work/apisix/apisix/t/certs:/certs \
- bitnami/etcd:3.4.0
-
- - name: Run centos7 docker and mapping apisix into container
- run: |
- docker run -itd -v /home/runner/work/apisix/apisix:/apisix --name centos7Instance --net="host" docker.io/centos:7 /bin/bash
- # docker exec centos7Instance bash -c "cp -r /tmp/apisix ./"
-
- - name: Run other docker containers for test
- run: |
- docker run --rm -itd -p 6379:6379 --name apisix_redis redis:3.0-alpine
- docker run --rm -itd -e HTTP_PORT=8888 -e HTTPS_PORT=9999 -p 8888:8888 -p 9999:9999 mendhak/http-https-echo
- docker run --rm -itd -e KEYCLOAK_USER=admin -e KEYCLOAK_PASSWORD=123456 -p 8090:8080 -p 8443:8443 sshniro/keycloak-apisix:1.0.0
- docker network create kafka-net --driver bridge
- docker run --name zookeeper-server -d -p 2181:2181 --network kafka-net -e ALLOW_ANONYMOUS_LOGIN=yes bitnami/zookeeper:3.6.0
- docker run --name kafka-server1 -d --network kafka-net -e ALLOW_PLAINTEXT_LISTENER=yes -e KAFKA_CFG_ZOOKEEPER_CONNECT=zookeeper-server:2181 -e KAFKA_CFG_ADVERTISED_LISTENERS=PLAINTEXT://127.0.0.1:9092 -p 9092:9092 -e KAFKA_CFG_AUTO_CREATE_TOPICS_ENABLE=true bitnami/kafka:latest
- docker run --name eureka -d -p 8761:8761 --env ENVIRONMENT=apisix --env spring.application.name=apisix-eureka --env server.port=8761 --env eureka.instance.ip-address=127.0.0.1 --env eureka.client.registerWithEureka=true --env eureka.client.fetchRegistry=false --env eureka.client.serviceUrl.defaultZone=http://127.0.0.1:8761/eureka/ bitinit/eureka
- sleep 5
- docker exec -i kafka-server1 /opt/bitnami/kafka/bin/kafka-topics.sh --create --zookeeper zookeeper-server:2181 --replication-factor 1 --partitions 1 --topic test2
- docker exec -i kafka-server1 /opt/bitnami/kafka/bin/kafka-topics.sh --create --zookeeper zookeeper-server:2181 --replication-factor 1 --partitions 3 --topic test3
- docker run --rm --name skywalking -d -p 1234:1234 -p 11800:11800 -p 12800:12800 apache/skywalking-oap-server:8.3.0-es6
- docker run --rm --name consul_1 -d -p 8500:8500 consul:1.7 consul agent -server -bootstrap-expect=1 -client 0.0.0.0 -log-level info -data-dir=/consul/data
- docker run --rm --name consul_2 -d -p 8600:8500 consul:1.7 consul agent -server -bootstrap-expect=1 -client 0.0.0.0 -log-level info -data-dir=/consul/data
-
- - name: Install dependencies
- run: |
- docker exec centos7Instance bash -c "cd apisix && ./utils/centos7-ci.sh install_dependencies"
-
- - name: Install rpm package
- if: ${{ startsWith(github.ref, 'refs/heads/release/') }}
- run: |
- docker exec centos7Instance bash -c "cd apisix && rpm -iv --prefix=/apisix ./apisix-build-tools/output/apisix-${{ steps.branch_env.outputs.version }}-0.x86_64.rpm"
- # Dependencies are attached with rpm, so revert `make deps`
- docker exec centos7Instance bash -c "cd apisix && rm -rf deps"
- docker exec centos7Instance bash -c "cd apisix && mv usr/bin . && mv usr/local/apisix/* ."
-
- - name: Run test cases
- run: |
- docker exec centos7Instance bash -c "cd apisix && ./utils/centos7-ci.sh run_case"
-
- - name: Publish Artifact
- if: ${{ startsWith(github.ref, 'refs/heads/release/') }}
- uses: actions/upload-artifact@v2.2.3
- with:
- name: "rpm"
- path: "./apisix-build-tools/output/apisix-${{ steps.branch_env.outputs.version }}-0.x86_64.rpm"
+ - name: Check out code
Review comment:
Why change the indentation of the existing code?
##########
File path: .github/workflows/build.yml
##########
@@ -56,6 +56,14 @@ jobs:
with:
submodules: recursive
+ - name: Cache deps
+ uses: actions/cache@v2
+ env:
+ cache-name: cache-deps
+ with:
+ path: ~/deps
Review comment:
The `~/deps` is defined but not used?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander commented on pull request #4026: chore: cache deps for CI
Posted by GitBox <gi...@apache.org>.
spacewander commented on pull request #4026:
URL: https://github.com/apache/apisix/pull/4026#issuecomment-817689284
The cache code can be removed now:
https://github.com/apache/apisix/blob/42ea885fb76400401f28f49cffcb2e54ba87ec49/ci/common.sh#L36-L41
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] nic-chen commented on a change in pull request #4026: chore: cache deps for CI
Posted by GitBox <gi...@apache.org>.
nic-chen commented on a change in pull request #4026:
URL: https://github.com/apache/apisix/pull/4026#discussion_r611500351
##########
File path: .github/workflows/centos7-ci.yml
##########
@@ -26,100 +26,108 @@ jobs:
ETCD_ADVERTISE_CLIENT_URLS: http://0.0.0.0:2379
steps:
- - name: Check out code
- uses: actions/checkout@v2
- with:
- submodules: recursive
-
- - name: Extract branch name
- if: ${{ startsWith(github.ref, 'refs/heads/release/') }}
- id: branch_env
- shell: bash
- run: |
- echo "##[set-output name=version;]$(echo ${GITHUB_REF##*/})"
-
- - name: Build rpm package
- if: ${{ startsWith(github.ref, 'refs/heads/release/') }}
- run: |
- export VERSION=${{ steps.branch_env.outputs.version }}
- sudo gem install --no-document fpm
- git clone https://github.com/api7/apisix-build-tools.git
- cd apisix-build-tools
- make package type=rpm app=apisix version=${VERSION} checkout=release/${VERSION}
- cd ..
- rm -rf $(ls -1 --ignore=apisix-build-tools --ignore=t --ignore=utils --ignore=ci --ignore=Makefile --ignore=rockspec)
-
- - name: Install Redis Cluster
- run: |
- docker run -d -p ${MASTER1_PORT}:6379 -p ${MASTER2_PORT}:6380 -p ${MASTER3_PORT}:6381 -p ${SLAVE1_PORT}:6382 -p ${SLAVE2_PORT}:6383 -p ${SLAVE3_PORT}:6384 --name redis-cluster vishnunair/docker-redis-cluster:latest
- env:
- MASTER1_PORT: 5000
- MASTER2_PORT: 5001
- MASTER3_PORT: 5002
- SLAVE1_PORT: 5003
- SLAVE2_PORT: 5004
- SLAVE3_PORT: 5005
-
- - name: Running Redis Cluster Test
- run: |
- sudo apt-get install -y redis-tools
- docker ps -a
- redis-cli -h 127.0.0.1 -p 5000 ping
- redis-cli -h 127.0.0.1 -p 5000 cluster nodes
-
- - name: Running etcd server with TLS
- run: |
- sudo docker run -d -p 12379:12379 -p 12380:12380 \
- -e ALLOW_NONE_AUTHENTICATION=yes \
- -e ETCD_ADVERTISE_CLIENT_URLS=https://0.0.0.0:12379 \
- -e ETCD_LISTEN_CLIENT_URLS=https://0.0.0.0:12379 \
- -e ETCD_CERT_FILE=/certs/etcd.pem \
- -e ETCD_KEY_FILE=/certs/etcd.key \
- -e GITHUB_ACTIONS=true \
- -e CI=true \
- -v /home/runner/work/apisix/apisix/t/certs:/certs \
- bitnami/etcd:3.4.0
-
- - name: Run centos7 docker and mapping apisix into container
- run: |
- docker run -itd -v /home/runner/work/apisix/apisix:/apisix --name centos7Instance --net="host" docker.io/centos:7 /bin/bash
- # docker exec centos7Instance bash -c "cp -r /tmp/apisix ./"
-
- - name: Run other docker containers for test
- run: |
- docker run --rm -itd -p 6379:6379 --name apisix_redis redis:3.0-alpine
- docker run --rm -itd -e HTTP_PORT=8888 -e HTTPS_PORT=9999 -p 8888:8888 -p 9999:9999 mendhak/http-https-echo
- docker run --rm -itd -e KEYCLOAK_USER=admin -e KEYCLOAK_PASSWORD=123456 -p 8090:8080 -p 8443:8443 sshniro/keycloak-apisix:1.0.0
- docker network create kafka-net --driver bridge
- docker run --name zookeeper-server -d -p 2181:2181 --network kafka-net -e ALLOW_ANONYMOUS_LOGIN=yes bitnami/zookeeper:3.6.0
- docker run --name kafka-server1 -d --network kafka-net -e ALLOW_PLAINTEXT_LISTENER=yes -e KAFKA_CFG_ZOOKEEPER_CONNECT=zookeeper-server:2181 -e KAFKA_CFG_ADVERTISED_LISTENERS=PLAINTEXT://127.0.0.1:9092 -p 9092:9092 -e KAFKA_CFG_AUTO_CREATE_TOPICS_ENABLE=true bitnami/kafka:latest
- docker run --name eureka -d -p 8761:8761 --env ENVIRONMENT=apisix --env spring.application.name=apisix-eureka --env server.port=8761 --env eureka.instance.ip-address=127.0.0.1 --env eureka.client.registerWithEureka=true --env eureka.client.fetchRegistry=false --env eureka.client.serviceUrl.defaultZone=http://127.0.0.1:8761/eureka/ bitinit/eureka
- sleep 5
- docker exec -i kafka-server1 /opt/bitnami/kafka/bin/kafka-topics.sh --create --zookeeper zookeeper-server:2181 --replication-factor 1 --partitions 1 --topic test2
- docker exec -i kafka-server1 /opt/bitnami/kafka/bin/kafka-topics.sh --create --zookeeper zookeeper-server:2181 --replication-factor 1 --partitions 3 --topic test3
- docker run --rm --name skywalking -d -p 1234:1234 -p 11800:11800 -p 12800:12800 apache/skywalking-oap-server:8.3.0-es6
- docker run --rm --name consul_1 -d -p 8500:8500 consul:1.7 consul agent -server -bootstrap-expect=1 -client 0.0.0.0 -log-level info -data-dir=/consul/data
- docker run --rm --name consul_2 -d -p 8600:8500 consul:1.7 consul agent -server -bootstrap-expect=1 -client 0.0.0.0 -log-level info -data-dir=/consul/data
-
- - name: Install dependencies
- run: |
- docker exec centos7Instance bash -c "cd apisix && ./utils/centos7-ci.sh install_dependencies"
-
- - name: Install rpm package
- if: ${{ startsWith(github.ref, 'refs/heads/release/') }}
- run: |
- docker exec centos7Instance bash -c "cd apisix && rpm -iv --prefix=/apisix ./apisix-build-tools/output/apisix-${{ steps.branch_env.outputs.version }}-0.x86_64.rpm"
- # Dependencies are attached with rpm, so revert `make deps`
- docker exec centos7Instance bash -c "cd apisix && rm -rf deps"
- docker exec centos7Instance bash -c "cd apisix && mv usr/bin . && mv usr/local/apisix/* ."
-
- - name: Run test cases
- run: |
- docker exec centos7Instance bash -c "cd apisix && ./utils/centos7-ci.sh run_case"
-
- - name: Publish Artifact
- if: ${{ startsWith(github.ref, 'refs/heads/release/') }}
- uses: actions/upload-artifact@v2.2.3
- with:
- name: "rpm"
- path: "./apisix-build-tools/output/apisix-${{ steps.branch_env.outputs.version }}-0.x86_64.rpm"
+ - name: Check out code
Review comment:
The original format is not standard, I think it should be fixed. Do I need to revert it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] nic-chen commented on pull request #4026: ci: cache deps
Posted by GitBox <gi...@apache.org>.
nic-chen commented on pull request #4026:
URL: https://github.com/apache/apisix/pull/4026#issuecomment-817713320
@spacewander updated. please have a look again when you have time. thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander merged pull request #4026: ci: cache deps
Posted by GitBox <gi...@apache.org>.
spacewander merged pull request #4026:
URL: https://github.com/apache/apisix/pull/4026
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org