You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/10/23 18:15:23 UTC

[GitHub] [pulsar] lhotari commented on a change in pull request #8358: [Issue 8346][Admin API] Validate retention policy

lhotari commented on a change in pull request #8358:
URL: https://github.com/apache/pulsar/pull/8358#discussion_r511058050



##########
File path: pom.xml
##########
@@ -126,7 +126,7 @@ flexible messaging model and an intuitive client API.</description>
     <protobuf3.version>3.11.4</protobuf3.version>
     <protoc3.version>3.11.4</protoc3.version>
     <grpc.version>1.31.0</grpc.version>
-    <protoc-gen-grpc-java.version>1.12.0</protoc-gen-grpc-java.version>
+    <protoc-gen-grpc-java.version>${grpc.version}</protoc-gen-grpc-java.version>

Review comment:
       yes, this is completely unrelated. I was running the experiment in this PR to see if I could fix the grpc upgrade. I'll remove the changes once #8363 has been merged.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org