You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2022/05/23 17:16:07 UTC

[GitHub] [rocketmq] GLBB opened a new issue, #4362: Optimized DefaultMQProducerImpl#checkConfig, remove unused check

GLBB opened a new issue, #4362:
URL: https://github.com/apache/rocketmq/issues/4362

   below code, `null == this.defaultMQProducer.getProducerGroup()` is redundancy, i wanna remove it.
   in org.apache.rocketmq.client.Validators#checkGroup has checked groupName is null. 
   
   ![image](https://user-images.githubusercontent.com/24810876/169872472-d9b380dc-f317-4700-9c27-5c7ab53729c5.png)
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] GLBB commented on issue #4362: Optimized DefaultMQProducerImpl#checkConfig, remove unused check

Posted by GitBox <gi...@apache.org>.

GLBB commented on issue #4362:
URL: https://github.com/apache/rocketmq/issues/4362#issuecomment-1134956814

   https://github.com/apache/rocketmq/pull/4363


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] duhenglucky closed issue #4362: Optimized DefaultMQProducerImpl#checkConfig, remove unused check

Posted by GitBox <gi...@apache.org>.

duhenglucky closed issue #4362: Optimized DefaultMQProducerImpl#checkConfig, remove unused check
URL: https://github.com/apache/rocketmq/issues/4362


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org