You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org> on 2023/04/15 17:58:34 UTC
[kudu-CR] [build] Update libraries to be excluded in SLES15 SP4
Abhishek Chennaka has uploaded this change for review. ( http://gerrit.cloudera.org:8080/19749
Change subject: [build] Update libraries to be excluded in SLES15 SP4
......................................................................
[build] Update libraries to be excluded in SLES15 SP4
Recently during the build of minicluster from
build-support/mini-cluster/build_mini_cluster_binaries.sh
we noticed the library libjitterentropy needs to be excluded
(as it is GPL-licensed) to avoid "unknown license" issue
reported from build-support/mini-cluster/check-license.pl.
Change-Id: I8152d7baaa944e1573c076b36980c73902c426ca
---
M build-support/mini-cluster/relocate_binaries_for_mini_cluster.py
1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/49/19749/1
--
To view, visit http://gerrit.cloudera.org:8080/19749
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I8152d7baaa944e1573c076b36980c73902c426ca
Gerrit-Change-Number: 19749
Gerrit-PatchSet: 1
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
[kudu-CR] [build] Update libraries to be excluded in SLES15 SP4
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/19749 )
Change subject: [build] Update libraries to be excluded in SLES15 SP4
......................................................................
[build] Update libraries to be excluded in SLES15 SP4
Recently during the build of minicluster from
build-support/mini-cluster/build_mini_cluster_binaries.sh
we found that libcurl built from third party is dependent on the
library libjitterentropy. While invesitgating if this dependency is
present just because libjitterentropy is present in the machine and
curl picking it up while building, we found that this library
libjitterentropy is present in SLES15 SP4 out of the box.
We also found having libjitterentropy in a RHEL 9 machine didn't cause
the dependency behavior from libcurl i.e. it is not dependent on
libjitterentropy.
To avoid these build issues in SELS 15 SP4, libjitterentropy needs to
be excluded when copying the libraries to be distributed. On a side
note libjitterentropy is also BSD and GPLv2 licensed.
Change-Id: I8152d7baaa944e1573c076b36980c73902c426ca
Reviewed-on: http://gerrit.cloudera.org:8080/19749
Tested-by: Kudu Jenkins
Reviewed-by: Alexey Serbin <al...@apache.org>
---
M build-support/mini-cluster/relocate_binaries_for_mini_cluster.py
1 file changed, 5 insertions(+), 1 deletion(-)
Approvals:
Kudu Jenkins: Verified
Alexey Serbin: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/19749
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I8152d7baaa944e1573c076b36980c73902c426ca
Gerrit-Change-Number: 19749
Gerrit-PatchSet: 5
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Ashwani Raina <ar...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [build] Update libraries to be excluded in SLES15 SP4
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/19749 )
Change subject: [build] Update libraries to be excluded in SLES15 SP4
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/19749/1/build-support/mini-cluster/relocate_binaries_for_mini_cluster.py
File build-support/mini-cluster/relocate_binaries_for_mini_cluster.py:
http://gerrit.cloudera.org:8080/#/c/19749/1/build-support/mini-cluster/relocate_binaries_for_mini_cluster.py@58
PS1, Line 58: PAT_LINUX_LIB_EXCLUDE = re.compile(r"""(libpthread|
Please add more information about libjitterentropy on SLES15 SP4.
--
To view, visit http://gerrit.cloudera.org:8080/19749
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8152d7baaa944e1573c076b36980c73902c426ca
Gerrit-Change-Number: 19749
Gerrit-PatchSet: 1
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Ashwani Raina <ar...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 18 Apr 2023 19:10:11 +0000
Gerrit-HasComments: Yes
[kudu-CR] [build] Update libraries to be excluded in SLES15 SP4
Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Ashwani Raina, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/19749
to look at the new patch set (#2).
Change subject: [build] Update libraries to be excluded in SLES15 SP4
......................................................................
[build] Update libraries to be excluded in SLES15 SP4
Recently during the build of minicluster from
build-support/mini-cluster/build_mini_cluster_binaries.sh
we found that libcurl built from third party is dependent on the
library libjitterentropy. While invesitgating if this dependency is
present just because libjitterentropy is present in the machine and
curl picking it up while building, we found that this library
libjitterentropy is present in SLES15 SP4 out of the box.
We also found having libjitterentropy in a RHEL 9 machine didn't cause
the dependency behavior from libcurl i.e. it is not dependent on
libjitterentropy.
To avoid these build issues in SELS 15 SP4, libjitterentropy needs to
be excluded when copying the libraries to be distributed. On a side
note libjitterentropy is also BSD and GPLv2 licensed.
Change-Id: I8152d7baaa944e1573c076b36980c73902c426ca
---
M build-support/mini-cluster/relocate_binaries_for_mini_cluster.py
1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/49/19749/2
--
To view, visit http://gerrit.cloudera.org:8080/19749
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I8152d7baaa944e1573c076b36980c73902c426ca
Gerrit-Change-Number: 19749
Gerrit-PatchSet: 2
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Ashwani Raina <ar...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [build] Update libraries to be excluded in SLES15 SP4
Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Ashwani Raina, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/19749
to look at the new patch set (#4).
Change subject: [build] Update libraries to be excluded in SLES15 SP4
......................................................................
[build] Update libraries to be excluded in SLES15 SP4
Recently during the build of minicluster from
build-support/mini-cluster/build_mini_cluster_binaries.sh
we found that libcurl built from third party is dependent on the
library libjitterentropy. While invesitgating if this dependency is
present just because libjitterentropy is present in the machine and
curl picking it up while building, we found that this library
libjitterentropy is present in SLES15 SP4 out of the box.
We also found having libjitterentropy in a RHEL 9 machine didn't cause
the dependency behavior from libcurl i.e. it is not dependent on
libjitterentropy.
To avoid these build issues in SELS 15 SP4, libjitterentropy needs to
be excluded when copying the libraries to be distributed. On a side
note libjitterentropy is also BSD and GPLv2 licensed.
Change-Id: I8152d7baaa944e1573c076b36980c73902c426ca
---
M build-support/mini-cluster/relocate_binaries_for_mini_cluster.py
1 file changed, 5 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/49/19749/4
--
To view, visit http://gerrit.cloudera.org:8080/19749
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I8152d7baaa944e1573c076b36980c73902c426ca
Gerrit-Change-Number: 19749
Gerrit-PatchSet: 4
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Ashwani Raina <ar...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [build] Update libraries to be excluded in SLES15 SP4
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/19749 )
Change subject: [build] Update libraries to be excluded in SLES15 SP4
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/19749/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/19749/1//COMMIT_MSG@11
PS1, Line 11: libjitterentropy
Where does it come from? What Kudu component needs libjitterentropy?
--
To view, visit http://gerrit.cloudera.org:8080/19749
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8152d7baaa944e1573c076b36980c73902c426ca
Gerrit-Change-Number: 19749
Gerrit-PatchSet: 1
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Ashwani Raina <ar...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 17 Apr 2023 23:12:31 +0000
Gerrit-HasComments: Yes
[kudu-CR] [build] Update libraries to be excluded in SLES15 SP4
Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Ashwani Raina, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/19749
to look at the new patch set (#3).
Change subject: [build] Update libraries to be excluded in SLES15 SP4
......................................................................
[build] Update libraries to be excluded in SLES15 SP4
Recently during the build of minicluster from
build-support/mini-cluster/build_mini_cluster_binaries.sh
we found that libcurl built from third party is dependent on the
library libjitterentropy. While invesitgating if this dependency is
present just because libjitterentropy is present in the machine and
curl picking it up while building, we found that this library
libjitterentropy is present in SLES15 SP4 out of the box.
We also found having libjitterentropy in a RHEL 9 machine didn't cause
the dependency behavior from libcurl i.e. it is not dependent on
libjitterentropy.
To avoid these build issues in SELS 15 SP4, libjitterentropy needs to
be excluded when copying the libraries to be distributed. On a side
note libjitterentropy is also BSD and GPLv2 licensed.
Change-Id: I8152d7baaa944e1573c076b36980c73902c426ca
---
M build-support/mini-cluster/relocate_binaries_for_mini_cluster.py
1 file changed, 5 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/49/19749/3
--
To view, visit http://gerrit.cloudera.org:8080/19749
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I8152d7baaa944e1573c076b36980c73902c426ca
Gerrit-Change-Number: 19749
Gerrit-PatchSet: 3
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Ashwani Raina <ar...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [build] Update libraries to be excluded in SLES15 SP4
Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/19749 )
Change subject: [build] Update libraries to be excluded in SLES15 SP4
......................................................................
Patch Set 3:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/19749/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/19749/1//COMMIT_MSG@11
PS1, Line 11: uilt from third
> Where does it come from? What Kudu component needs libjitterentropy?
As discussed, updated commit message to include these details.
http://gerrit.cloudera.org:8080/#/c/19749/1//COMMIT_MSG@12
PS1, Line 12: bjitterentro
> Actually, it's double licensed: BSD and GPLv2, both at RHEL9 and SLES15. S
As discussed, since this is specific to SLES 15 SP4, having it in build-support/mini-cluster/relocate_binaries_for_mini_cluster.py made more sense.
http://gerrit.cloudera.org:8080/#/c/19749/1/build-support/mini-cluster/relocate_binaries_for_mini_cluster.py
File build-support/mini-cluster/relocate_binaries_for_mini_cluster.py:
http://gerrit.cloudera.org:8080/#/c/19749/1/build-support/mini-cluster/relocate_binaries_for_mini_cluster.py@58
PS1, Line 58: # introduced by 'libselinux'.
> Please add more information about libjitterentropy on SLES15 SP4.
Done
--
To view, visit http://gerrit.cloudera.org:8080/19749
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8152d7baaa944e1573c076b36980c73902c426ca
Gerrit-Change-Number: 19749
Gerrit-PatchSet: 3
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Ashwani Raina <ar...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 18 Apr 2023 22:10:36 +0000
Gerrit-HasComments: Yes
[kudu-CR] [build] Update libraries to be excluded in SLES15 SP4
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/19749 )
Change subject: [build] Update libraries to be excluded in SLES15 SP4
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/19749/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/19749/1//COMMIT_MSG@12
PS1, Line 12: GPL-licensed
Actually, it's double licensed: BSD and GPLv2, both at RHEL9 and SLES15. Should we instead add its BSD license to build-support/mini-cluster/LICENSE-BINARY-JAR-LINUX.txt?
[root@rhel9]# locate jitterentropy
/usr/lib64/libjitterentropy.so.3
/usr/lib64/libjitterentropy.so.3.3.1
/usr/share/doc/jitterentropy
/usr/share/doc/jitterentropy/CHANGES.md
/usr/share/doc/jitterentropy/README.md
/usr/share/licenses/jitterentropy
/usr/share/licenses/jitterentropy/LICENSE
/usr/share/licenses/jitterentropy/LICENSE.bsd
/usr/share/licenses/jitterentropy/LICENSE.gplv2
[root@sles15]# locate jitterentropy
/usr/lib64/libjitterentropy.so.3
/usr/lib64/libjitterentropy.so.3.4.0
/usr/share/licenses/libjitterentropy3
/usr/share/licenses/libjitterentropy3/LICENSE
/usr/share/licenses/libjitterentropy3/LICENSE.bsd
/usr/share/licenses/libjitterentropy3/LICENSE.gplv2
--
To view, visit http://gerrit.cloudera.org:8080/19749
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8152d7baaa944e1573c076b36980c73902c426ca
Gerrit-Change-Number: 19749
Gerrit-PatchSet: 1
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Ashwani Raina <ar...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 17 Apr 2023 23:20:11 +0000
Gerrit-HasComments: Yes
[kudu-CR] [build] Update libraries to be excluded in SLES15 SP4
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/19749 )
Change subject: [build] Update libraries to be excluded in SLES15 SP4
......................................................................
Patch Set 4: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/19749
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8152d7baaa944e1573c076b36980c73902c426ca
Gerrit-Change-Number: 19749
Gerrit-PatchSet: 4
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Ashwani Raina <ar...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 18 Apr 2023 23:06:42 +0000
Gerrit-HasComments: No